Skip to content

[release/6.0] Bump the macOS image to one that isn't EOL yet - #75294

Merged
carlossanlop merged 2 commits into
dotnet:release/6.0from
lewing:bump-macos-release-6-0
Sep 13, 2022
Merged

[release/6.0] Bump the macOS image to one that isn't EOL yet#75294
carlossanlop merged 2 commits into
dotnet:release/6.0from
lewing:bump-macos-release-6-0

Conversation

@lewing

@lewinglewing commented Sep 8, 2022

Copy link
Copy Markdown
Member

No description provided.

@ghostghost assigned lewingSep 8, 2022
@ghost

ghost commented Sep 8, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:lewing
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@steveisoksteveisok mentioned this pull request Sep 8, 2022
Closed
4 tasks
@lewing
lewing requested a review from hoyosjsSeptember 8, 2022 18:52
@lewinglewing mentioned this pull request Sep 8, 2022
Merged
@lewing

lewing commented Sep 8, 2022

Copy link
Copy Markdown
MemberAuthor

needs #68847

@lewinglewing closed this Sep 12, 2022
@lewinglewing reopened this Sep 12, 2022
@carlossanlop

carlossanlop commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

needs #68847

Considering #68847 (comment) failed to backport, what's the plan with this?

@steveisok

steveisok commented Sep 12, 2022

Copy link
Copy Markdown
Member

needs #68847

Considering #68847 (comment) failed to backport, what's the plan with this?

Let me see what I can do to resolve this.

@steveisok

steveisok commented Sep 12, 2022

Copy link
Copy Markdown
Member

@tarekgh since the ICU changes needed to be manually integrated, can you please sanity check me?

tarekgh
tarekgh approved these changes Sep 12, 2022
View reviewed changes

@tarekghtarekgh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM.

I hope this change will stay for some time before releasing it to reduce the risk in the servicing release. I am not seeing any problem though.

@steveisoksteveisok added the Servicing-consider Issue for next servicing release review label Sep 13, 2022
@steveisok

steveisok commented Sep 13, 2022

Copy link
Copy Markdown
Member

Since this contains some ICU changes, I think having tactics approve / be aware is the right way to go.

@lewinglewing mentioned this pull request Sep 13, 2022
Closed
@ayakaelayakael mentioned this pull request Sep 13, 2022
Closed
9 tasks
@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 13, 2022
@rbhandarbhanda added this to the 6.0.10 milestone Sep 13, 2022
@carlossanlop

carlossanlop commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Approved, signed off, CI is green. Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit bc65e68 into dotnet:release/6.0Sep 13, 2022
@jkotasjkotas mentioned this pull request Sep 14, 2022
Merged
@lewing
lewing deleted the bump-macos-release-6-0 branch September 23, 2022 23:08
@tarekghtarekgh mentioned this pull request Oct 17, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@tarekghtarekghtarekgh approved these changes
@hoyosjshoyosjsAwaiting requested review from hoyosjs
+1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lewinglewing

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.10

Development

Successfully merging this pull request may close these issues.

5 participants

@lewing@carlossanlop@steveisok@tarekgh@rbhanda