Skip to content

Do not emit mangled names in mstat files#75328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 1 commit into from
Sep 11, 2022
Merged

Do not emit mangled names in mstat files #75328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/MstatObjectDumper.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ namespace ILCompiler
public class MstatObjectDumper : ObjectDumper
{
private const int VersionMajor = 1;
private const int VersionMinor = 0;
private const int VersionMinor = 1;

private readonly string _fileName;
private readonly TypeSystemMetadataEmitter _emitter;
Expand DownExpand Up@@ -81,7 +81,8 @@ private void SerializeSimpleEntry(InstructionEncoder encoder, TypeSystemEntity e
{
encoder.OpCode(ILOpCode.Ldtoken);
encoder.Token(_emitter.EmitMetadataHandleForTypeSystemEntity(entity));
encoder.LoadString(_emitter.GetUserStringHandle(mangledName));
// Would like to do this but mangled names are very long and go over the 16 MB string limit quickly.
// encoder.LoadString(_emitter.GetUserStringHandle(mangledName));
encoder.LoadConstantI4(blob.Data.Length);
}

Expand All@@ -92,7 +93,8 @@ internal override void End()
{
methods.OpCode(ILOpCode.Ldtoken);
methods.Token(_emitter.EmitMetadataHandleForTypeSystemEntity(m.Key));
methods.LoadString(_emitter.GetUserStringHandle(m.Value.MangledName));
// Would like to do this but mangled names are very long and go over the 16 MB string limit quickly.
// methods.LoadString(_emitter.GetUserStringHandle(m.Value.MangledName));
methods.LoadConstantI4(m.Value.Size);
methods.LoadConstantI4(m.Value.GcInfoSize);
methods.LoadConstantI4(_methodEhInfo.GetValueOrDefault(m.Key));
Expand Down