Skip to content

Change VerifyXmlResolver to use TcpListener over HttpListener - #75369

Merged
bartonjs merged 3 commits into
dotnet:mainfrom
bartonjs:VerifyXmlResolver_TcpListener
Sep 20, 2022
Merged

Change VerifyXmlResolver to use TcpListener over HttpListener#75369
bartonjs merged 3 commits into
dotnet:mainfrom
bartonjs:VerifyXmlResolver_TcpListener

Conversation

@bartonjs

@bartonjsbartonjs commented Sep 9, 2022

Copy link
Copy Markdown
Member

Addresses #74115 in main.

@bartonjsbartonjs added area-System.Security test-enhancement Improvements of test source code labels Sep 9, 2022
@bartonjsbartonjs added this to the 8.0.0 milestone Sep 9, 2022
@bartonjsbartonjs self-assigned this Sep 9, 2022
@ghost

ghost commented Sep 9, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Addresses #74115 in main.

Author:bartonjs
Assignees:bartonjs
Labels:

area-System.Security, test-enhancement

Milestone:8.0.0

wfurt
wfurt reviewed Sep 9, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs Outdated
stephentoub
stephentoub reviewed Sep 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs Outdated
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs Outdated
wfurt
wfurt reviewed Sep 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs Outdated
@jeffhandleyjeffhandley linked an issue Sep 16, 2022 that may be closed by this pull request
SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost. #74115
Open
@bartonjs

bartonjs commented Sep 19, 2022

Copy link
Copy Markdown
MemberAuthor

Any other feedback, @wfurt?

wfurt
wfurt approved these changes Sep 20, 2022
View reviewed changes

@wfurtwfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt

wfurt commented Sep 20, 2022

Copy link
Copy Markdown
Member

sorry for late response @bartonjs. it slipped from my radar.

@bartonjs
bartonjs merged commit 9e4829d into dotnet:mainSep 20, 2022
@bartonjs
bartonjs deleted the VerifyXmlResolver_TcpListener branch September 20, 2022 22:21
@bartonjs

bartonjs commented Sep 20, 2022

Copy link
Copy Markdown
MemberAuthor

If we don't see any intermittent failures by the weekend then it'll probably be good to backport to 7.

karelz added a commit that referenced this pull request Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver
e03fd16
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@karelzkarelz mentioned this pull request Sep 24, 2022
Merged
@karelz

karelz commented Sep 24, 2022

Copy link
Copy Markdown
Member

The failures are back -- I reopened #74115

karelz added a commit that referenced this pull request Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver (#76129)
2600909
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@ghostghost locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub left review comments
@wfurtwfurtwfurt approved these changes
@GrabYourPitchforksGrabYourPitchforksAwaiting requested review from GrabYourPitchforks

Assignees

@bartonjsbartonjs

Labels

area-System.Securitytest-enhancementImprovements of test source code

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.

4 participants

@bartonjs@wfurt@karelz@stephentoub
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Change VerifyXmlResolver to use TcpListener over HttpListener by bartonjs · Pull Request #75369 · dotnet/runtime · GitHub
Skip to content
Change VerifyXmlResolver to use TcpListener over HttpListener - #75369
Merged
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Sep 20, 2022
Merged
Change VerifyXmlResolver to use TcpListener over HttpListener#75369
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Conversation
@bartonjs
@bartonjsbartonjs
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
Addresses #74115 in main.
@bartonjsbartonjs
added

area-System.Security

test-enhancement
Improvements of test source code
labels
Sep 9, 2022
@bartonjsbartonjs
added this to the 8.0.0 milestone
Sep 9, 2022
@bartonjsbartonjs
self-assigned this
Sep 9, 2022
@ghost
ghost
commented
Sep 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

See info in area-owners.md if you want to be subscribed.
Issue Details
Addresses #74115 in main.
Author:bartonjs
Assignees:bartonjs
Labels:
area-System.Security, test-enhancement
Milestone:8.0.0
wfurt
wfurt
reviewed
Sep 9, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

stephentoub
stephentoub
reviewed
Sep 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

wfurt
wfurt
reviewed
Sep 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

@jeffhandleyjeffhandley
linked an issue
Sep 16, 2022
that may be
closed
by this pull request


SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.
#74115

Open

@bartonjs
bartonjs
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Any other feedback, @wfurt?
wfurt
wfurt
approved these changes
Sep 20, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wfurt
wfurt
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
sorry for late response @bartonjs. it slipped from my radar.
@bartonjs
bartonjs
merged commit 9e4829d
into
dotnet:mainSep 20, 2022
@bartonjs
bartonjs
deleted the

VerifyXmlResolver_TcpListener

branch
September 20, 2022 22:21
@bartonjs
bartonjs
commented
Sep 20, 2022

Copy link


Copy Markdown

MemberAuthor
If we don't see any intermittent failures by the weekend then it'll probably be good to backport to 7.
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver
e03fd16
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@karelzkarelz
mentioned this pull request
Sep 24, 2022
 Merged

@karelz
karelz
commented
Sep 24, 2022

Copy link


Copy Markdown

Member
The failures are back -- I reopened #74115
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver (#76129)
2600909
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@wfurtwfurtwfurt approved these changes
@GrabYourPitchforksGrabYourPitchforksAwaiting requested review from GrabYourPitchforks

Assignees

@bartonjsbartonjs

Labels

area-System.Securitytest-enhancementImprovements of test source code

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.


4 participants

@bartonjs@wfurt@karelz@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Change VerifyXmlResolver to use TcpListener over HttpListener by bartonjs · Pull Request #75369 · dotnet/runtime · GitHub
Skip to content
Change VerifyXmlResolver to use TcpListener over HttpListener - #75369
Merged
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Sep 20, 2022
Merged
Change VerifyXmlResolver to use TcpListener over HttpListener#75369
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Conversation
@bartonjs
@bartonjsbartonjs
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
Addresses #74115 in main.
@bartonjsbartonjs
added

area-System.Security

test-enhancement
Improvements of test source code
labels
Sep 9, 2022
@bartonjsbartonjs
added this to the 8.0.0 milestone
Sep 9, 2022
@bartonjsbartonjs
self-assigned this
Sep 9, 2022
@ghost
ghost
commented
Sep 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

See info in area-owners.md if you want to be subscribed.
Issue Details
Addresses #74115 in main.
Author:bartonjs
Assignees:bartonjs
Labels:
area-System.Security, test-enhancement
Milestone:8.0.0
wfurt
wfurt
reviewed
Sep 9, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

stephentoub
stephentoub
reviewed
Sep 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

wfurt
wfurt
reviewed
Sep 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

@jeffhandleyjeffhandley
linked an issue
Sep 16, 2022
that may be
closed
by this pull request


SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.
#74115

Open

@bartonjs
bartonjs
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Any other feedback, @wfurt?
wfurt
wfurt
approved these changes
Sep 20, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wfurt
wfurt
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
sorry for late response @bartonjs. it slipped from my radar.
@bartonjs
bartonjs
merged commit 9e4829d
into
dotnet:mainSep 20, 2022
@bartonjs
bartonjs
deleted the

VerifyXmlResolver_TcpListener

branch
September 20, 2022 22:21
@bartonjs
bartonjs
commented
Sep 20, 2022

Copy link


Copy Markdown

MemberAuthor
If we don't see any intermittent failures by the weekend then it'll probably be good to backport to 7.
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver
e03fd16
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@karelzkarelz
mentioned this pull request
Sep 24, 2022
 Merged

@karelz
karelz
commented
Sep 24, 2022

Copy link


Copy Markdown

Member
The failures are back -- I reopened #74115
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver (#76129)
2600909
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@wfurtwfurtwfurt approved these changes
@GrabYourPitchforksGrabYourPitchforksAwaiting requested review from GrabYourPitchforks

Assignees

@bartonjsbartonjs

Labels

area-System.Securitytest-enhancementImprovements of test source code

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.


4 participants

@bartonjs@wfurt@karelz@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Change VerifyXmlResolver to use TcpListener over HttpListener by bartonjs · Pull Request #75369 · dotnet/runtime · GitHub
Skip to content
Change VerifyXmlResolver to use TcpListener over HttpListener - #75369
Merged
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Sep 20, 2022
Merged
Change VerifyXmlResolver to use TcpListener over HttpListener#75369
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Conversation
@bartonjs
@bartonjsbartonjs
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
Addresses #74115 in main.
@bartonjsbartonjs
added

area-System.Security

test-enhancement
Improvements of test source code
labels
Sep 9, 2022
@bartonjsbartonjs
added this to the 8.0.0 milestone
Sep 9, 2022
@bartonjsbartonjs
self-assigned this
Sep 9, 2022
@ghost
ghost
commented
Sep 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

See info in area-owners.md if you want to be subscribed.
Issue Details
Addresses #74115 in main.
Author:bartonjs
Assignees:bartonjs
Labels:
area-System.Security, test-enhancement
Milestone:8.0.0
wfurt
wfurt
reviewed
Sep 9, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

stephentoub
stephentoub
reviewed
Sep 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

wfurt
wfurt
reviewed
Sep 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

@jeffhandleyjeffhandley
linked an issue
Sep 16, 2022
that may be
closed
by this pull request


SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.
#74115

Open

@bartonjs
bartonjs
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Any other feedback, @wfurt?
wfurt
wfurt
approved these changes
Sep 20, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wfurt
wfurt
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
sorry for late response @bartonjs. it slipped from my radar.
@bartonjs
bartonjs
merged commit 9e4829d
into
dotnet:mainSep 20, 2022
@bartonjs
bartonjs
deleted the

VerifyXmlResolver_TcpListener

branch
September 20, 2022 22:21
@bartonjs
bartonjs
commented
Sep 20, 2022

Copy link


Copy Markdown

MemberAuthor
If we don't see any intermittent failures by the weekend then it'll probably be good to backport to 7.
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver
e03fd16
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@karelzkarelz
mentioned this pull request
Sep 24, 2022
 Merged

@karelz
karelz
commented
Sep 24, 2022

Copy link


Copy Markdown

Member
The failures are back -- I reopened #74115
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver (#76129)
2600909
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@wfurtwfurtwfurt approved these changes
@GrabYourPitchforksGrabYourPitchforksAwaiting requested review from GrabYourPitchforks

Assignees

@bartonjsbartonjs

Labels

area-System.Securitytest-enhancementImprovements of test source code

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.


4 participants

@bartonjs@wfurt@karelz@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Change VerifyXmlResolver to use TcpListener over HttpListener by bartonjs · Pull Request #75369 · dotnet/runtime · GitHub
Skip to content
Change VerifyXmlResolver to use TcpListener over HttpListener - #75369
Merged
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Sep 20, 2022
Merged
Change VerifyXmlResolver to use TcpListener over HttpListener#75369
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Conversation
@bartonjs
@bartonjsbartonjs
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
Addresses #74115 in main.
@bartonjsbartonjs
added

area-System.Security

test-enhancement
Improvements of test source code
labels
Sep 9, 2022
@bartonjsbartonjs
added this to the 8.0.0 milestone
Sep 9, 2022
@bartonjsbartonjs
self-assigned this
Sep 9, 2022
@ghost
ghost
commented
Sep 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

See info in area-owners.md if you want to be subscribed.
Issue Details
Addresses #74115 in main.
Author:bartonjs
Assignees:bartonjs
Labels:
area-System.Security, test-enhancement
Milestone:8.0.0
wfurt
wfurt
reviewed
Sep 9, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

stephentoub
stephentoub
reviewed
Sep 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

wfurt
wfurt
reviewed
Sep 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

@jeffhandleyjeffhandley
linked an issue
Sep 16, 2022
that may be
closed
by this pull request


SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.
#74115

Open

@bartonjs
bartonjs
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Any other feedback, @wfurt?
wfurt
wfurt
approved these changes
Sep 20, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wfurt
wfurt
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
sorry for late response @bartonjs. it slipped from my radar.
@bartonjs
bartonjs
merged commit 9e4829d
into
dotnet:mainSep 20, 2022
@bartonjs
bartonjs
deleted the

VerifyXmlResolver_TcpListener

branch
September 20, 2022 22:21
@bartonjs
bartonjs
commented
Sep 20, 2022

Copy link


Copy Markdown

MemberAuthor
If we don't see any intermittent failures by the weekend then it'll probably be good to backport to 7.
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver
e03fd16
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@karelzkarelz
mentioned this pull request
Sep 24, 2022
 Merged

@karelz
karelz
commented
Sep 24, 2022

Copy link


Copy Markdown

Member
The failures are back -- I reopened #74115
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver (#76129)
2600909
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@wfurtwfurtwfurt approved these changes
@GrabYourPitchforksGrabYourPitchforksAwaiting requested review from GrabYourPitchforks

Assignees

@bartonjsbartonjs

Labels

area-System.Securitytest-enhancementImprovements of test source code

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.


4 participants

@bartonjs@wfurt@karelz@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Change VerifyXmlResolver to use TcpListener over HttpListener by bartonjs · Pull Request #75369 · dotnet/runtime · GitHub
Skip to content
Change VerifyXmlResolver to use TcpListener over HttpListener - #75369
Merged
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Sep 20, 2022
Merged
Change VerifyXmlResolver to use TcpListener over HttpListener#75369
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Conversation
@bartonjs
@bartonjsbartonjs
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
Addresses #74115 in main.
@bartonjsbartonjs
added

area-System.Security

test-enhancement
Improvements of test source code
labels
Sep 9, 2022
@bartonjsbartonjs
added this to the 8.0.0 milestone
Sep 9, 2022
@bartonjsbartonjs
self-assigned this
Sep 9, 2022
@ghost
ghost
commented
Sep 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

See info in area-owners.md if you want to be subscribed.
Issue Details
Addresses #74115 in main.
Author:bartonjs
Assignees:bartonjs
Labels:
area-System.Security, test-enhancement
Milestone:8.0.0
wfurt
wfurt
reviewed
Sep 9, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

stephentoub
stephentoub
reviewed
Sep 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

wfurt
wfurt
reviewed
Sep 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

@jeffhandleyjeffhandley
linked an issue
Sep 16, 2022
that may be
closed
by this pull request


SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.
#74115

Open

@bartonjs
bartonjs
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Any other feedback, @wfurt?
wfurt
wfurt
approved these changes
Sep 20, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wfurt
wfurt
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
sorry for late response @bartonjs. it slipped from my radar.
@bartonjs
bartonjs
merged commit 9e4829d
into
dotnet:mainSep 20, 2022
@bartonjs
bartonjs
deleted the

VerifyXmlResolver_TcpListener

branch
September 20, 2022 22:21
@bartonjs
bartonjs
commented
Sep 20, 2022

Copy link


Copy Markdown

MemberAuthor
If we don't see any intermittent failures by the weekend then it'll probably be good to backport to 7.
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver
e03fd16
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@karelzkarelz
mentioned this pull request
Sep 24, 2022
 Merged

@karelz
karelz
commented
Sep 24, 2022

Copy link


Copy Markdown

Member
The failures are back -- I reopened #74115
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver (#76129)
2600909
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@wfurtwfurtwfurt approved these changes
@GrabYourPitchforksGrabYourPitchforksAwaiting requested review from GrabYourPitchforks

Assignees

@bartonjsbartonjs

Labels

area-System.Securitytest-enhancementImprovements of test source code

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.


4 participants

@bartonjs@wfurt@karelz@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Change VerifyXmlResolver to use TcpListener over HttpListener by bartonjs · Pull Request #75369 · dotnet/runtime · GitHub
Skip to content
Change VerifyXmlResolver to use TcpListener over HttpListener - #75369
Merged
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Sep 20, 2022
Merged
Change VerifyXmlResolver to use TcpListener over HttpListener#75369
bartonjs merged 3 commits into
dotnet:mainfrom 
bartonjs:VerifyXmlResolver_TcpListener
Conversation
@bartonjs
@bartonjsbartonjs
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
Addresses #74115 in main.
@bartonjsbartonjs
added

area-System.Security

test-enhancement
Improvements of test source code
labels
Sep 9, 2022
@bartonjsbartonjs
added this to the 8.0.0 milestone
Sep 9, 2022
@bartonjsbartonjs
self-assigned this
Sep 9, 2022
@ghost
ghost
commented
Sep 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

See info in area-owners.md if you want to be subscribed.
Issue Details
Addresses #74115 in main.
Author:bartonjs
Assignees:bartonjs
Labels:
area-System.Security, test-enhancement
Milestone:8.0.0
wfurt
wfurt
reviewed
Sep 9, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

stephentoub
stephentoub
reviewed
Sep 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

wfurt
wfurt
reviewed
Sep 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated

@jeffhandleyjeffhandley
linked an issue
Sep 16, 2022
that may be
closed
by this pull request


SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.
#74115

Open

@bartonjs
bartonjs
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Any other feedback, @wfurt?
wfurt
wfurt
approved these changes
Sep 20, 2022
View reviewed changes
@wfurtwfurt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wfurt
wfurt
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
sorry for late response @bartonjs. it slipped from my radar.
@bartonjs
bartonjs
merged commit 9e4829d
into
dotnet:mainSep 20, 2022
@bartonjs
bartonjs
deleted the

VerifyXmlResolver_TcpListener

branch
September 20, 2022 22:21
@bartonjs
bartonjs
commented
Sep 20, 2022

Copy link


Copy Markdown

MemberAuthor
If we don't see any intermittent failures by the weekend then it'll probably be good to backport to 7.
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver
e03fd16
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@karelzkarelz
mentioned this pull request
Sep 24, 2022
 Merged

@karelz
karelz
commented
Sep 24, 2022

Copy link


Copy Markdown

Member
The failures are back -- I reopened #74115
karelz added a commit
that referenced
this pull request
Sep 24, 2022
@karelz
Disable failing test SignedXmlTest.VerifyXmlResolver (#76129)
2600909
PR #75369 tried to fix the problem and re-enabled the test, but it is still failing.
Tracked by #74115
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@wfurtwfurtwfurt approved these changes
@GrabYourPitchforksGrabYourPitchforksAwaiting requested review from GrabYourPitchforks

Assignees

@bartonjsbartonjs

Labels

area-System.Securitytest-enhancementImprovements of test source code

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

SignedXmlTest.VerifyXmlResolver sometimes failing due to failing to connect to localhost.


4 participants

@bartonjs@wfurt@karelz@stephentoub