Skip to content

Fix running WebAssembly Browser App from VS - #75384

Merged
lewing merged 13 commits into
dotnet:mainfrom
thaystg:thays_fix_75356
Sep 14, 2022
Merged

Fix running WebAssembly Browser App from VS#75384
lewing merged 13 commits into
dotnet:mainfrom
thaystg:thays_fix_75356

Conversation

@thaystg

@thaystgthaystg commented Sep 10, 2022•
edited by radical
Loading

Copy link
Copy Markdown
Member

As $(OutputPath) is not absolute path, we need to add $(MSBuildProjectDirectory)

Tested:

  • Create a new WebAssembly Browser App on VS and run, change WasmAppDir and run again.
  • Create a new WebAssembly Console App on VS and run, change WasmAppDir and run again.
  • Create a new wasmbrowser app using command line and run;
  • Create a new wasmconsole app using command line and run;
  • Create a new wasmbrowser app using command line and dotnet build and dotnet run --no-build;
  • Create a new wasmbrowser app using command line and dotnet build and dotnet run --debug;

Also, added tests for command line runs. But a few of the tests are disabled because the tests would be using 7.0 targets, but 7.0 doesn't have the fix yet.

Fix#75356

@thaystg
thaystg requested a review from lewingSeptember 10, 2022 00:37
@ghostghost assigned thaystgSep 10, 2022
@ghost

ghost commented Sep 10, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

As $(OutputPath) is not absolute path, we need to add $(MSBuildProjectDirectory)

Fix #75356

Author:thaystg
Assignees:-
Labels:

area-Infrastructure-mono

Milestone:-

@radicalradical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) arch-wasm WebAssembly architecture area-Build-mono and removed area-Infrastructure-mono labels Sep 11, 2022
@ghost

ghost commented Sep 11, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

As $(OutputPath) is not absolute path, we need to add $(MSBuildProjectDirectory)

Fix #75356

Author:thaystg
Assignees:thaystg
Labels:

NO-MERGE, arch-wasm, area-Build-mono

Milestone:-

radical
radical reviewed Sep 12, 2022
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.targets Outdated
@radicalradical removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 12, 2022
@radical

radical commented Sep 13, 2022

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

github-actionsBot commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3042387685

@github-actionsgithub-actionsBot mentioned this pull request Sep 13, 2022
Merged
@radical
Disable failing test
ee680f5
.. which is failing because the WBT is still using net7.0 on `main`,
thus using the 7.0 targets, which don't have the fix yet.
We can enable this once the fix is merged for 7.0 .
@radical

radical commented Sep 13, 2022

Copy link
Copy Markdown
Member

The corresponding 7.0 PR has been merged. Once the packages from that are available, the disabled test here can be enabled again.

@lewing

lewing commented Sep 14, 2022

Copy link
Copy Markdown
Member

failure is #74302

@lewing
lewing merged commit b55b256 into dotnet:mainSep 14, 2022
@ghostghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical left review comments
@lewinglewinglewing approved these changes

Assignees

@thaystgthaystg

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to run WebAssembly Browser App from VS or CLI

3 participants

@thaystg@radical@lewing