Uh oh!
There was an error while loading. Please reload this page.
load msquic early to avoid interference with RemoteExecutor - #75424
Conversation
ghost
commented
Sep 11, 2022
Tagging subscribers to this area: @dotnet/ncl Issue DetailsWhen msquic is loaded it will also initialize While the problem really lives in I wrote I had test runs over nigh and I did not see any problems on system where it was failing before.
|
jkotas
commented
Sep 11, 2022
Could you please re-enable disabled tests? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wfurt
commented
Sep 12, 2022
Run tests in loop since yesterday and still looks good. macOS test failures are unrelated. |
wfurt
commented
Sep 12, 2022
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3039384318 |
When msquic is loaded it will also initialize
lttng. That callswaitand it can reap processes fromRemoteExecutorand that will cause Assert inProcesscode. (long story and evidence is in #74795)While the problem really lives in
lttngthere is no quick fix for that. To void the problem this change tries to loadMsQuicearly via static variable and that will initializelttngbefore any tests actually start.I wrote
GetIsQuicSupportedso we can do more there if needed. e.g. call some msquic API to load everything permanently. It is not needed at this point so I left it out.I had test runs over nigh and I did not see any problems on system where it was failing before.
fixes#74795