') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); set session ID when TLS resume is enabled by wfurt · Pull Request #75435 · dotnet/runtime · GitHub
Skip to content

set session ID when TLS resume is enabled - #75435

Merged
wfurt merged 5 commits into
dotnet:mainfrom
wfurt:ctxId
Sep 13, 2022
Merged

set session ID when TLS resume is enabled#75435
wfurt merged 5 commits into
dotnet:mainfrom
wfurt:ctxId

Conversation

@wfurt

@wfurtwfurt commented Sep 12, 2022

Copy link
Copy Markdown
Member
 System.Security.Authentication.AuthenticationException: Authentication failed, see inner exception.
---> Interop+OpenSsl+SslException: SSL Handshake failed with OpenSSL error - SSL_ERROR_SSL.
---> Interop+Crypto+OpenSslCryptographicException: error:140D9115:SSL routines:ssl_get_prev_session:session id context uninitialized

There are several references to it on Internet. https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_session_id_context.html mentioning that this error may happen with client certificates.

This change will initialize ID to random bytes to prevent this error from happening.
So far I was unable to craft functional tests that could reproduce the issue. I have separate repro with Kestrel and Windows client as originally reported and this change fixes the observed failures.

contributes to #75079
I think e should take the fix for 7, leave it open for 8 to craft test that would reproduce the reported issue.

@wfurtwfurt added area-System.Net.Security os-linux Linux OS (any supported distro) labels Sep 12, 2022
@wfurt
wfurt requested review from a team, bartonjs and rzikmSeptember 12, 2022 05:50
@wfurtwfurt self-assigned this Sep 12, 2022
@ghost

ghost commented Sep 12, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details
 System.Security.Authentication.AuthenticationException: Authentication failed, see inner exception.
---> Interop+OpenSsl+SslException: SSL Handshake failed with OpenSSL error - SSL_ERROR_SSL.
---> Interop+Crypto+OpenSslCryptographicException: error:140D9115:SSL routines:ssl_get_prev_session:session id context uninitialized

There are several references to it on Internet. https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_session_id_context.html mentioning that this error may happen with client certificates.

This change will initialize ID to random bytes to prevent this error from happening.
So far I was unable to craft functional tests that could reproduce the issue. I have separate repro with Kestrel and Windows client as originally reported and this change fixes the observed failures.

contributes to #75079
I think e should take the fix for 7, leave it open for 8 to craft test that would reproduce the reported issue.

Author:wfurt
Assignees:wfurt
Labels:

area-System.Net.Security, os-linux

Milestone:-

bartonjs
bartonjs reviewed Sep 12, 2022
View reviewed changes
Comment threadsrc/native/libs/System.Security.Cryptography.Native/pal_ssl.c Outdated
@karelzkarelz added this to the 8.0.0 milestone Sep 12, 2022
bartonjs
bartonjs reviewed Sep 12, 2022
View reviewed changes
Comment threadsrc/native/libs/System.Security.Cryptography.Native/pal_ssl.h Outdated
bartonjs
bartonjs reviewed Sep 12, 2022
View reviewed changes
Comment threadsrc/native/libs/System.Security.Cryptography.Native/pal_ssl.c Outdated
@wfurt@bartonjs
Apply suggestions from code review
d9a278d
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
@wfurt
wfurt merged commit ecf9f2f into dotnet:mainSep 13, 2022
@wfurt

wfurt commented Sep 13, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3042209571

@github-actionsgithub-actionsBot mentioned this pull request Sep 13, 2022
Merged
@wfurt
wfurt deleted the ctxId branch September 13, 2022 03:49
@karelzkarelz mentioned this pull request Sep 13, 2022
Closed
1 task
@ghostghost locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjsbartonjsbartonjs approved these changes
@rzikmrzikmAwaiting requested review from rzikm

Assignees

@wfurtwfurt

Labels

area-System.Net.Securityos-linuxLinux OS (any supported distro)

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@wfurt@bartonjs@karelz