Skip to content

[release/7.0] Update MsQuic to 2.1.1 - #75479

Merged
carlossanlop merged 4 commits into
dotnet:release/7.0from
wfurt:quicUpdate7
Sep 14, 2022
Merged

[release/7.0] Update MsQuic to 2.1.1#75479
carlossanlop merged 4 commits into
dotnet:release/7.0from
wfurt:quicUpdate7

Conversation

@wfurt

@wfurtwfurt commented Sep 12, 2022

Copy link
Copy Markdown
Member

This is manual port of #75287, #75291, #75380 and #75534 to pick up MsQuic 2.1.1
(fixes#75262)

Customer Impact

as product change this impacts only Windows as we do not include MsQuic on Unix.
MsQuic 2.1.1 is bug fix releases and for .NET it is mostly needed for ARM64 on Linux.
The actual impact on Windows is small and it is mostly for consistently and to stay on top of stable msquic updates.
Also we will consume bits built and signed by MsQuic on all Windows architectures now. (we used out bits for x86 & x64 before)

The test only part updates Helix images so we can execute tests on various Linux distributions.

Testing

testing covered by runtime tests in main branch.

Risk

small

@wfurt

Copy link
Copy Markdown
MemberAuthor

please let me know if you have any concerns or if you approve it for 7.0 @danmoseley

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This is manual port of #75287 and #75380 to pick up MsQuic 2.1.1
(fixes #75262)

Customer Impact

as product change this impacts only Windows as we do not include MsQuic on Unix.
MsQuic 2.1.1 is bug fix releases and for .NET it is mostly needed for ARM64 on Linux.
The actual impact on Windows is small and it is mostly for consistently and to stay on top of stable msquic updates.
Also we will consume bits built and signed by MsQuic on all Windows architectures now. (we used out bits for x86 & x64 before)

The test only part updates Helix images so we can execute tests on various Linux distributions.

Testing

testing covered by runtime tests in main branch.

Risk

small

Author:wfurt
Assignees:-
Labels:

area-System.Net.Quic

Milestone:-

@wfurtwfurt added this to the 7.0.0 milestone Sep 12, 2022
@wfurtwfurt added the Servicing-consider Issue for next servicing release review label Sep 12, 2022
@danmoseley

Copy link
Copy Markdown
Contributor

Approved - we already discussed offline, this brings us into a consistent state.

Comment threadeng/pipelines/libraries/helix-queues-setup.yml Outdated
Comment threadeng/pipelines/libraries/helix-queues-setup.yml Outdated
Comment threadeng/pipelines/libraries/helix-queues-setup.yml
Comment threadeng/pipelines/libraries/helix-queues-setup.yml Outdated
@carlossanlopcarlossanlop removed the Servicing-consider Issue for next servicing release review label Sep 12, 2022
@carlossanlop

Copy link
Copy Markdown
Contributor

FYI - removing the servicing-consider label. The only requirements are a code review sign off ✔️, an M2 approval, ✔️, and a green CI 🔃.

@karelzkarelz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PR #75291 we are missing:

  • Lines 46 & 48 -- Debian 10 & 11 arm64 -- the lines do not exist in 7.0, that is fine, we added them later I assume
  • Line 84 - Debian.10.Amd64
  • Line 88 - Debian.10.Amd64

Addressed in follow up commit fad7d09

@carlossanlopcarlossanlop changed the title [release/7.0] udpate MsQuic to 2.1.1[release/7.0] Update MsQuic to 2.1.1Sep 13, 2022

@karelzkarelz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@danmoseley it is ready for your approval -- oh, you already approved it above

@karelzkarelz mentioned this pull request Sep 13, 2022
26 tasks
@wfurt

Copy link
Copy Markdown
MemberAuthor

#75545 opened for tracking missing test.

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All infra changes. LGTM.

@carlossanlop

Copy link
Copy Markdown
Contributor

@wfurt@karelz@rzikm can you take a look at the failures? There's one in Quic.

@wfurt

Copy link
Copy Markdown
MemberAuthor

https://helix.dot.net/api/2019-06-17/jobs/b9b3aaf6-e04e-423e-a6c0-2e1caf0798c0/workitems/System.Net.Quic.Functional.Tests/console is strange.
No output, no crash or message about hanging test.
I don't think we have seen anything like this on main.
I will kick re-run....

@rzikm

Copy link
Copy Markdown
Member

@wfurt can you cherry-pick this change as well? so we have updated OpenSUSE as well:
#75534

@rzikmrzikm mentioned this pull request Sep 13, 2022
@wfurt

Copy link
Copy Markdown
MemberAuthor

all tests are clean @carlossanlop

@carlossanlop

Copy link
Copy Markdown
Contributor

Approved, signed off, CI green. Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit adbfdfa into dotnet:release/7.0Sep 14, 2022
@ghostghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@wfurt@danmoseley@carlossanlop@rzikm@karelz