Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Update MsQuic to 2.1.1 - #75479
Conversation
wfurt
commented
Sep 12, 2022
please let me know if you have any concerns or if you approve it for 7.0 @danmoseley |
ghost
commented
Sep 12, 2022
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is manual port of #75287 and #75380 to pick up MsQuic 2.1.1 Customer Impactas product change this impacts only Windows as we do not include MsQuic on Unix. The test only part updates Helix images so we can execute tests on various Linux distributions. Testingtesting covered by runtime tests in Risksmall
|
danmoseley
commented
Sep 12, 2022
Approved - we already discussed offline, this brings us into a consistent state. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
carlossanlop
commented
Sep 12, 2022
FYI - removing the |
There was a problem hiding this comment.
LGTM, thanks!@danmoseley it is ready for your approval -- oh, you already approved it above
wfurt
commented
Sep 13, 2022
#75545 opened for tracking missing test. |
carlossanlop
left a comment
There was a problem hiding this comment.
All infra changes. LGTM.
carlossanlop
commented
Sep 13, 2022
wfurt
commented
Sep 13, 2022
https://helix.dot.net/api/2019-06-17/jobs/b9b3aaf6-e04e-423e-a6c0-2e1caf0798c0/workitems/System.Net.Quic.Functional.Tests/console is strange. |
rzikm
commented
Sep 13, 2022
wfurt
commented
Sep 14, 2022
all tests are clean @carlossanlop |
carlossanlop
commented
Sep 14, 2022
Approved, signed off, CI green. Ready to merge. |
This is manual port of #75287, #75291, #75380 and #75534 to pick up MsQuic 2.1.1
(fixes#75262)
Customer Impact
as product change this impacts only Windows as we do not include MsQuic on Unix.
MsQuic 2.1.1 is bug fix releases and for .NET it is mostly needed for ARM64 on Linux.
The actual impact on Windows is small and it is mostly for consistently and to stay on top of stable msquic updates.
Also we will consume bits built and signed by MsQuic on all Windows architectures now. (we used out bits for x86 & x64 before)
The test only part updates Helix images so we can execute tests on various Linux distributions.
Testing
testing covered by runtime tests in
mainbranch.Risk
small