Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Port workload fixes from 6.0 - #75486
Conversation
ghost
commented
Sep 12, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lewing
left a comment
There was a problem hiding this comment.
worload changes lgtm, someone else should look over the arcade related stuff
ghost
commented
Sep 12, 2022
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue Details
Most of the changes are in
|
@joeloff are these types of changes considered tell-mode or ask-mode? If it's the latter, we need M2 approval. If the former, I can sign-off. |
lewing
commented
Sep 12, 2022
this is build infrastructure supporting workload insertion and is tell mode as discussed in tactics |
The failures aren't because of the workload stuff, it looks like it is the sdk bump causing problems. @marcpopMSFT is this because the SDK bumped the 6.0.x runtime? |
lewing
commented
Sep 13, 2022
This can probably wait until servicing has gone out |
| across multiple VS builds to support multi-targeting. --> | ||
| <ItemGroup> | ||
| <SwixWorkloadPackProjects Include="@(SwixProjects)" Condition="'%(PackageType)' == 'msi-pack'" | ||
| ManifestOutputPath="$(VStemp)\p\%(SwixProjects.SdkFeatureBand)" |
There was a problem hiding this comment.
yup, p => packs, c => components... We've introduced additional naming elements for multitargeting and if we ever do SxS preview feature bands, then the package IDs can get quite long so I'm just avoiding things early on. And we already include the packs and component parts in the final artifact name, but we need separate folders to zip things up insolation.
carlossanlop
commented
Sep 13, 2022
Meaning this should wait until after the RC2 snap? |
joeloff
commented
Sep 13, 2022
That's fine, as long as we get this into RC2 after the snap otherwise we're going to have to go through all the manual work again for VS. |
carlossanlop
commented
Sep 13, 2022
There's a conflict. @joeloff can you please resolve it? |
joeloff
commented
Sep 13, 2022
Done. I picked the RC1 SDK since that's what |
carlossanlop
commented
Sep 13, 2022
Thanks @joeloff. I added the "no merge" label. Please remove it when this is ready to merge after the snap, and ping me. |
lewing
commented
Sep 14, 2022
failure is unrelated |
joeloff
commented
Sep 14, 2022
Verified a signed internal build and everything looks as expected. |
lewing
commented
Sep 14, 2022
failures are not related |
hoyosjs
commented
Sep 14, 2022
Failures are #75391 and PinObj_neg doesn't seem to have an associated issue, but there's other runs with the same failure mode - the output doesn't get more descriptive than |
Most of the changes are in
engdue to the Arcade update to obtain the latest copy of the workload build tasks. Those changes are unrelated to the workload fix, but appears to be necessary.