Uh oh!
There was an error while loading. Please reload this page.
[MONO] Move Marshal-ilgen into a component - #75542
Merged
Merged
Conversation
This was referenced Sep 29, 2022
nariccforce-pushed
the
naricc/marshal-component
branch
2 times, most recently
from
October 17, 2022 19:47
9587a95 to
f84b181Comparenaricc
marked this pull request as ready for review
October 17, 2022 20:07
naricc
requested review from
SamMonoRT, lambdageek, lewing, marek-safar, pavelsavara, radical, thaystg and vargaz
as code ownersOctober 17, 2022 20:07
lambdageek
commented
Nov 2, 2022
Member
@naricc you need to resolve the merge conflicts before the CI pipelines will run |
nariccforce-pushed
the
naricc/marshal-component
branch
from
November 2, 2022 19:45
62c3d76 to
4e0e605Comparenaricc
commented
Nov 2, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 3, 2022
naricc
commented
Nov 3, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
naricc
commented
Nov 3, 2022
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
nariccforce-pushed
the
naricc/marshal-component
branch
from
November 3, 2022 18:48
9a02194 to
091aa36Compare
naricc
commented
Nov 14, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
naricc
commented
Nov 14, 2022
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Uh oh!
There was an error while loading. Please reload this page.
added 7 commits
November 14, 2022 16:19
naricc
commented
Nov 15, 2022
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
naricc
commented
Nov 15, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
approved these changes
Nov 15, 2022
lambdageek
left a comment
Member
There was a problem hiding this comment.
LGTM. I'm excited that we finally have a chance to clean things up here
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
naricc
commented
Nov 15, 2022
ContributorAuthor
/azp run runtime-wasm |
naricc
commented
Nov 15, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move marhsal-ilgen into a component, ultimately saving approximately 100kb in the runtime when the component is not needed. This addresses issues seen on iOS last time this was attempted, and fixes a race condition.
I am still doing manual testing on xamarin-ios and xamarin-android, but think this is ready for review.