Skip to content

[release/7.0] [wasm][debugger] fixing setting a breakpoint in an invalid IL offset after hotreload - #75564

Merged
carlossanlop merged 6 commits into
release/7.0from
backport/pr-75561-to-release/7.0
Sep 14, 2022
Merged

[release/7.0] [wasm][debugger] fixing setting a breakpoint in an invalid IL offset after hotreload#75564
carlossanlop merged 6 commits into
release/7.0from
backport/pr-75561-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Backport of #75561 to release/7.0

/cc @thaystg

Customer Impact

When applying hot reload changes the browser could close because we had a crash on BrowserDebugProxy

Testing

Manually tested

Risk

Low risk, only protecting the return of setting the breakpoint to avoid a throw.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75561 to release/7.0

/cc @thaystg

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@radicalradical added the arch-wasm WebAssembly architecture label Sep 13, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75561 to release/7.0

/cc @thaystg

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

@carlossanlop

Copy link
Copy Markdown
Contributor

Double signed off by @lewing, so that's how I know we really want this merged 😁. CI is green. Ready. :shipit:

@carlossanlop
carlossanlop merged commit c623d96 into release/7.0Sep 14, 2022
@carlossanlop
carlossanlop deleted the backport/pr-75561-to-release/7.0 branch September 14, 2022 04:13
@ghostghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@radical@lewing@thaystg