Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Try enabling regions for native AOT. - #75599
[release/7.0] Try enabling regions for native AOT.#75599github-actions[bot] wants to merge 1 commit into
Conversation
ghost
commented
Sep 14, 2022
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #69108 to release/7.0 /cc @MichalStrehovsky@PeterSolMS Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
There's one segfault in https://github.com/dotnet/runtime/pull/69108/checks?check_run_id=8347611410 that would need to be investigated. I'm done for the day. Marking no merge. Still interested in test run results. |
MichalStrehovsky
commented
Sep 14, 2022
GC is asserting. We don't have all the necessary fixes here. Unclear which one(s) are missing. |
Backport of #69108 to release/7.0
/cc @MichalStrehovsky@PeterSolMS
Customer Impact
(This is quite pushing the RC2 bar at this point, but I want to at least try because shipping with GC configuration that is very different is not great either.)
We couldn't previously enable regions due to crashes. We've since fixed multiple stress issues in NativeAOT and the crashes are now all gone.
This PR allows us to use the GC in the same configuration that CoreCLR uses.
Testing
Passes all our NativeAOT testing.
Risk
There definitely is some.