Skip to content

Try re-enabling System.Transactions.Local tests on Arm64 - #75610

Merged
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:transations-arm64
Sep 15, 2022
Merged

Try re-enabling System.Transactions.Local tests on Arm64#75610
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:transations-arm64

Conversation

@jkotas

@jkotasjkotas commented Sep 14, 2022

Copy link
Copy Markdown
Member

No description provided.

@ghostghost assigned jkotasSep 14, 2022
@jkotasjkotas added the NO-REVIEW Experimental/testing PR, do NOT review it label Sep 14, 2022
@jkotas

jkotas commented Sep 14, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Sep 14, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Sep 15, 2022
@kunalspathak
Try re-enabling System.Transactions.Local tests on Arm64dotnet#75610
d9cd0a3
@jkotasjkotas removed the NO-REVIEW Experimental/testing PR, do NOT review it label Sep 15, 2022
@jkotas
jkotas requested a review from rojiSeptember 15, 2022 17:53
@jkotas
jkotas marked this pull request as ready for review September 15, 2022 17:54
roji
roji approved these changes Sep 15, 2022
View reviewed changes

@rojiroji left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are we saying we're no longer able to repro any failure, including with jitstress? The would likely mean that the GUID interop fixes (#74226, #74570) made this go away (though IIRC @kunalspathak was able to see the bug with them,
#74226 (comment)).

In any case, we can certainly see if the failures reappear in CI other elsewhere.

@roji

roji commented Sep 15, 2022

Copy link
Copy Markdown
Member

/cc @ajcvickers

@jkotas

jkotas commented Sep 15, 2022

Copy link
Copy Markdown
MemberAuthor

None of the failures are related to System.Transactions

@jkotas
jkotas merged commit b1f5e97 into dotnet:mainSep 15, 2022
@jkotas
jkotas deleted the transations-arm64 branch September 15, 2022 18:16
@jkotas

jkotas commented Sep 15, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0-rc2

@github-actions

github-actionsBot commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3062739478

@roji

roji commented Sep 15, 2022

Copy link
Copy Markdown
Member

@jkotas I know, but they were intermittent before as well.

@github-actionsgithub-actionsBot mentioned this pull request Sep 15, 2022
Merged
@jkotas

jkotas commented Sep 15, 2022

Copy link
Copy Markdown
MemberAuthor

@jkotas I know, but they were intermittent before as well.

The System.Transactions tests were run on Win Arm64 multiple times in the CI, and also locally. No crashes observed.

@ghostghost locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rojirojiroji approved these changes

Assignees

@jkotasjkotas

Labels

area-System.Transactions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkotas@roji