Skip to content

Use determinism instead of timing in cancellation tests - #75623

Merged
bartonjs merged 3 commits into
dotnet:mainfrom
bartonjs:stabilize_hash_cancellation_test
Sep 15, 2022
Merged

Use determinism instead of timing in cancellation tests#75623
bartonjs merged 3 commits into
dotnet:mainfrom
bartonjs:stabilize_hash_cancellation_test

Conversation

@bartonjs

@bartonjsbartonjs commented Sep 14, 2022

Copy link
Copy Markdown
Member

Addresses #75463 in main.

@ghostghost assigned bartonjsSep 14, 2022
@ghost

ghost commented Sep 14, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Addresses #75463 in main.

Author:bartonjs
Assignees:-
Labels:

area-System.Security

Milestone:-

stephentoub
stephentoub reviewed Sep 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography/tests/HashAlgorithmTest.cs
stephentoub
stephentoub reviewed Sep 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Security.Cryptography/tests/HashAlgorithmTest.cs Outdated
@bartonjs
bartonjs merged commit 9028dc2 into dotnet:mainSep 15, 2022
@bartonjs

bartonjs commented Sep 15, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0-rc2

@github-actions

github-actionsBot commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3057137562

@bartonjs
bartonjs deleted the stabilize_hash_cancellation_test branch September 15, 2022 01:13
@bartonjsbartonjs added the test-enhancement Improvements of test source code label Sep 15, 2022
@github-actionsgithub-actionsBot mentioned this pull request Sep 15, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@bartonjsbartonjs

Labels

area-System.Securitytest-enhancementImprovements of test source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bartonjs@stephentoub