Skip to content

[release/7.0] Update dependencies from dotnet/roslyn-analyzers - #75675

Merged
carlossanlop merged 5 commits into
release/7.0from
darc-release/7.0-bc4afbfd-2fa1-4ccd-8614-153e044a768f
Sep 19, 2022
Merged

[release/7.0] Update dependencies from dotnet/roslyn-analyzers#75675
carlossanlop merged 5 commits into
release/7.0from
darc-release/7.0-bc4afbfd-2fa1-4ccd-8614-153e044a768f

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Sep 15, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: a8b74935-5a68-4a8e-b089-08da7ef6355d
  • Build: 20220916.1
  • Date Produced: September 16, 2022 4:34:18 PM UTC
  • Commit: 10a460bb34f36dfb3be9fe463d343ad71a9a2961
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslyn-analyzersb…
a404b3e
…uild 20220914.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22452.2 -> To Version 7.0.0-preview1.22464.1
@ghostghost added the area-codeflow for labeling automated codeflow label Sep 15, 2022
@carlossanlop

carlossanlop commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

Almost all CI failed in this PR. @tannergooding I see some problems coming from Numerics. Can you please take a look?
cc @joperezr in case this looks familiar.

@tannergooding

tannergooding commented Sep 15, 2022

Copy link
Copy Markdown
Member

Look to be issues with the new analyzer. CC. @buyaa-n

@buyaa-n

buyaa-n commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

Hm strange, I have tested with runtime did not fail anything, looking

@buyaa-nbuyaa-n mentioned this pull request Sep 16, 2022
Merged
@buyaa-n

buyaa-n commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

The bug introduced with a code review updates which was not tested with runtime, the fix is up for review (tested with the repro), after this merged we could update the dogfood with next available build

@carlossanlop

carlossanlop commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

@buyaa-n I think your fix should get cherry-picked into this PR, so we merge both together and we don't break the branch.

@buyaa-n

buyaa-n commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

I don't think that would work, it is updating analyzers release version, not updating the code. As this PR is triggered automatically I hope after the next analyzer build it would trigger another PR (else we might bump manually). So think this PR better to be closed, but don't know how this process is handled in infra CC @ViktorHofer

@tannergooding

tannergooding commented Sep 16, 2022

Copy link
Copy Markdown
Member

Can the analyzer be temporarily disabled to unblock this PR and then re-enabled in the PR that includes the fix?

@buyaa-n

buyaa-n commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

Yes, I can update that in this PR if that is what we want

@buyaa-n

buyaa-n commented Sep 16, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

But there is a risk the bug cause issue for repos dogfooding the 7.0 sdk and using the default SDK analyzers

Update: Actually I don't think it is updating the SDK version, it should only apply to runtime. So I will push a commit disabling the analyzer

@buyaa-n
buyaa-nforce-pushed the darc-release/7.0-bc4afbfd-2fa1-4ccd-8614-153e044a768f branch from 4fc12f0 to 9997839CompareSeptember 16, 2022 17:24
This was referenced Sep 16, 2022
Closed
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslyn-analyzersb…
78487d3
…uild 20220916.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22452.2 -> To Version 7.0.0-preview1.22466.1
@ViktorHofer

ViktorHofer commented Sep 19, 2022

Copy link
Copy Markdown
Member

@buyaa-n the Maestro Bot just updated this PR with a newer version of the analyzer package which presumably includes your fix. You now want to revert the two editorconfig changes in this PR.

@runfoapprunfoappBot mentioned this pull request Sep 19, 2022
Closed
@buyaa-n

buyaa-n commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

You now want to revert the two editorconfig changes in this PR.

Done, now new failures are unrelated

@runfoapprunfoappBot mentioned this pull request Sep 19, 2022
Closed
This was referenced Sep 19, 2022
Closed
Closed
carlossanlop
carlossanlop approved these changes Sep 19, 2022
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now that the original failures have been fixed. :shipit:
Infra change only.

The existing failures are all unrelated:

Installer Build and Test coreclr Linux_musl_x64 Release

HostActivation failure: #75429 (marked as dupe of #74328)

Libraries Test Run release coreclr Linux x64 Debug

System.Net.Http.Functional.Tests failure is #75611

mono llvmaot Pri0 Runtime Tests Run Linux x64 release | mono monointerpreter Pri0 Runtime Tests Run OSX x64 release

PInvokeDetach failure: #73040

Build Browser wasm Linux Release AllSubsets_Mono_RuntimeTests

JIT Hardware intrinsics failure: #75391
JIT PGO failure: #75867

@carlossanlop
carlossanlop merged commit 2108047 into release/7.0Sep 19, 2022
@carlossanlop
carlossanlop deleted the darc-release/7.0-bc4afbfd-2fa1-4ccd-8614-153e044a768f branch September 19, 2022 22:54
@ghostghost locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@tannergooding@buyaa-n@ViktorHofer