[wasm] fix missing managed stack trace on managed exceptions marshaled to JS by pavelsavara · Pull Request #75678 · dotnet/runtime

pavelsavara · 2022-09-15T14:14:39Z

When we display managed exception marshaled to JS as ManagedError via toString we only print:

ManagedError(gc_handle: 214)

The fix makes it to print both managed and JS stack trace

 at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.ThrowFromJSExport(String message) in JavaScriptTestHelper.cs:line 41
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.__Wrapper_ThrowFromJSExport_849163347(JSMarshalerArgument* __arguments_buffer) in JSExports.g.cs:line 50
Error: -t-e-s-t-
at marshal_exception_to_js (dotnet.js:2803:22)
at invoke_method_and_handle_exception (dotnet.js:5030:19)
at bound_fn_1R (dotnet.js:4964:17)
at Module.catch1toString (JavaScriptTestHelper.mjs:117:9)
at bound_fn_2R (dotnet.js:4696:35)
at Object.mono_wasm_invoke_import (dotnet.js:4747:9)
at _mono_wasm_invoke_import (dotnet.js:16384:82)
at do_icall (do_icall (wasm://wasm/02e6dfee:wasm-function[308]:0x1dbed))
at do_icall_wrapper (do_icall_wrapper (wasm://wasm/02e6dfee:wasm-function[285]:0x1cd26))
at interp_exec_method (interp_exec_method (wasm://wasm/02e6dfee:wasm-function[235]:0xc4ca))
at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[234]:0xb1bd))
at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[15606]:0x27f8d3))
at do_runtime_invoke (do_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[3302]:0xe9376))
at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/02e6dfee:wasm-function[3300]:0xe9251))
at mono_runtime_try_invoke_span (mono_runtime_try_invoke_span (wasm://wasm/02e6dfee:wasm-function[3449]:0xf1d9d))
at mono_runtime_invoke_span_checked (mono_runtime_invoke_span_checked (wasm://wasm/02e6dfee:wasm-function[3450]:0xf21b8))
at ves_icall_InternalInvoke (ves_icall_InternalInvoke (wasm://wasm/02e6dfee:wasm-function[1974]:0xa0a88))
at ves_icall_InternalInvoke_raw (ves_icall_InternalInvoke_raw (wasm://wasm/02e6dfee:wasm-function[2197]:0xaeca0))
at do_icall (do_icall (wasm://wasm/02e6dfee:wasm-function[308]:0x1dc71))
at do_icall_wrapper (do_icall_wrapper (wasm://wasm/02e6dfee:wasm-function[285]:0x1cd26))
at interp_exec_method (interp_exec_method (wasm://wasm/02e6dfee:wasm-function[235]:0xc4ca))
at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[234]:0xb1bd))
at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[15606]:0x27f8d3))
at do_runtime_invoke (do_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[3302]:0xe9376))
at mono_runtime_try_invoke (mono_runtime_try_invoke (wasm://wasm/02e6dfee:wasm-function[3316]:0xea048))
at mono_runtime_invoke (mono_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[3382]:0xee01d))
at mono_wasm_invoke_method_bound (mono_wasm_invoke_method_bound (wasm://wasm/02e6dfee:wasm-function[129]:0x8efa))
at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (dotnet.js:17161:149)
at invoke_method_and_handle_exception (dotnet.js:5025:42)
at runtimeHelpers.javaScriptExports.complete_task (dotnet.js:5185:17)
at dotnet.js:3206:46

ghost · 2022-09-15T14:14:49Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

When we display managed exception marshaled to JS as ManagedError via toString we only print:

ManagedError(gc_handle: 214)

The fix makes use to print both managed and JS stack trace

System.ArgumentException: -t-e-s-t-
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.ThrowFromJSExport(String message) in JavaScriptTestHelper.cs:line 41
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.__Wrapper_ThrowFromJSExport_849163347(JSMarshalerArgument* __arguments_buffer) in JSExports.g.cs:line 50
Error: -t-e-s-t-
at marshal_exception_to_js (dotnet.js:2803:22)
at invoke_method_and_handle_exception (dotnet.js:5030:19)
at bound_fn_1R (dotnet.js:4964:17)
at Module.catch1toString (JavaScriptTestHelper.mjs:117:9)
at bound_fn_2R (dotnet.js:4696:35)
at Object.mono_wasm_invoke_import (dotnet.js:4747:9)
at _mono_wasm_invoke_import (dotnet.js:16384:82)
at do_icall (do_icall (wasm://wasm/02e6dfee:wasm-function[308]:0x1dbed))
at do_icall_wrapper (do_icall_wrapper (wasm://wasm/02e6dfee:wasm-function[285]:0x1cd26))
at interp_exec_method (interp_exec_method (wasm://wasm/02e6dfee:wasm-function[235]:0xc4ca))
at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[234]:0xb1bd))
at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[15606]:0x27f8d3))
at do_runtime_invoke (do_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[3302]:0xe9376))
at mono_runtime_invoke_checked (mono_runtime_invoke_checked (wasm://wasm/02e6dfee:wasm-function[3300]:0xe9251))
at mono_runtime_try_invoke_span (mono_runtime_try_invoke_span (wasm://wasm/02e6dfee:wasm-function[3449]:0xf1d9d))
at mono_runtime_invoke_span_checked (mono_runtime_invoke_span_checked (wasm://wasm/02e6dfee:wasm-function[3450]:0xf21b8))
at ves_icall_InternalInvoke (ves_icall_InternalInvoke (wasm://wasm/02e6dfee:wasm-function[1974]:0xa0a88))
at ves_icall_InternalInvoke_raw (ves_icall_InternalInvoke_raw (wasm://wasm/02e6dfee:wasm-function[2197]:0xaeca0))
at do_icall (do_icall (wasm://wasm/02e6dfee:wasm-function[308]:0x1dc71))
at do_icall_wrapper (do_icall_wrapper (wasm://wasm/02e6dfee:wasm-function[285]:0x1cd26))
at interp_exec_method (interp_exec_method (wasm://wasm/02e6dfee:wasm-function[235]:0xc4ca))
at interp_runtime_invoke (interp_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[234]:0xb1bd))
at mono_jit_runtime_invoke (mono_jit_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[15606]:0x27f8d3))
at do_runtime_invoke (do_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[3302]:0xe9376))
at mono_runtime_try_invoke (mono_runtime_try_invoke (wasm://wasm/02e6dfee:wasm-function[3316]:0xea048))
at mono_runtime_invoke (mono_runtime_invoke (wasm://wasm/02e6dfee:wasm-function[3382]:0xee01d))
at mono_wasm_invoke_method_bound (mono_wasm_invoke_method_bound (wasm://wasm/02e6dfee:wasm-function[129]:0x8efa))
at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (dotnet.js:17161:149)
at invoke_method_and_handle_exception (dotnet.js:5025:42)
at runtimeHelpers.javaScriptExports.complete_task (dotnet.js:5185:17)
at dotnet.js:3206:46

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	8.0.0

pavelsavara · 2022-09-15T14:15:03Z

/azp run runtime-wasm

azure-pipelines · 2022-09-15T14:15:16Z

Azure Pipelines successfully started running 1 pipeline(s).

kg

Looks fine other than the ManagedError inheritance question and toString

pavelsavara · 2022-09-16T16:32:36Z

/azp run runtime-wasm

azure-pipelines · 2022-09-16T16:32:47Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2022-09-17T12:23:29Z

/backport to release/7.0-rc2

github-actions · 2022-09-17T12:23:39Z

Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3073338553

github-actions · 2022-09-17T12:25:28Z

@pavelsavara backporting to release/7.0-rc2 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: fix missing managed stack trace on managed exceptions marshaled to JS
Using index info to reconstruct a base tree...
M	src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JSImportExportTest.cs
M	src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.cs
M	src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.mjs
M	src/mono/wasm/runtime/marshal-to-js.ts
M	src/mono/wasm/runtime/marshal.ts
M	src/mono/wasm/runtime/run.ts
M	src/mono/wasm/runtime/types.ts
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/runtime/types.ts
Auto-merging src/mono/wasm/runtime/run.ts
CONFLICT (content): Merge conflict in src/mono/wasm/runtime/run.ts
Auto-merging src/mono/wasm/runtime/marshal.ts
Auto-merging src/mono/wasm/runtime/marshal-to-js.ts
Auto-merging src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.mjs
Auto-merging src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.cs
Auto-merging src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JSImportExportTest.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix missing managed stack trace on managed exceptions marshaled to JS
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

fix missing managed stack trace on managed exceptions marshaled to JS
d5f2d5b

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript labels Sep 15, 2022

pavelsavara added this to the 8.0.0 milestone Sep 15, 2022

pavelsavara requested review from kg and maraf September 15, 2022 14:14

pavelsavara self-assigned this Sep 15, 2022

This comment was marked as outdated.
Sign in to view

pavelsavara marked this pull request as ready for review September 15, 2022 16:45

pavelsavara requested a review from lewing as a code owner September 15, 2022 16:45

lewing requested a review from thaystg September 15, 2022 16:57

kg reviewed Sep 15, 2022
View reviewed changes

Comment threadsrc/mono/wasm/runtime/logging.ts Outdated

kg reviewed Sep 15, 2022
View reviewed changes

Comment threadsrc/mono/wasm/runtime/marshal.ts Outdated

kg suggested changes Sep 15, 2022
View reviewed changes

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 15, 2022

pavelsavara added 2 commits September 16, 2022 13:40

Merge branch 'main' into wasm_js_stack_trace
a5daa76

feedback
1e50c5e

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 16, 2022

pavelsavara added 3 commits September 16, 2022 17:32

override get stack instead of toString
57aa8ea

fix tests
e760830

fix Firefox
9a88ea5

pavelsavara requested a review from kg September 16, 2022 16:32

kg approved these changes Sep 17, 2022
View reviewed changes

pavelsavara merged commit 7144b28 into dotnet:mainSep 17, 2022

pavelsavara mentioned this pull request Sep 17, 2022
[release/7.0-rc2] [wasm] fix missing managed stack trace on managed exceptions marshaled to JS #75799
Merged

pavelsavara deleted the wasm_js_stack_trace branch October 13, 2022 10:04

ghost locked as resolved and limited conversation to collaborators Nov 12, 2022

Navigation Menu

Uh oh!

[wasm] fix missing managed stack trace on managed exceptions marshaled to JS - #75678

[wasm] fix missing managed stack trace on managed exceptions marshaled to JS#75678
pavelsavara merged 6 commits into
dotnet:mainfrom
pavelsavara:wasm_js_stack_trace

pavelsavara commented Sep 15, 2022•
edited
Loading

Uh oh!

ghost commented Sep 15, 2022

Uh oh!

pavelsavara commented Sep 15, 2022

Uh oh!

azure-pipelinesBot commented Sep 15, 2022

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

kg left a comment

Uh oh!

pavelsavara commented Sep 16, 2022

Uh oh!

azure-pipelinesBot commented Sep 16, 2022

Uh oh!

pavelsavara commented Sep 17, 2022

Uh oh!

github-actionsBot commented Sep 17, 2022

Uh oh!

github-actionsBot commented Sep 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pavelsavara commented Sep 15, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 15, 2022

Uh oh!

pavelsavara commented Sep 15, 2022

Uh oh!

azure-pipelinesBot commented Sep 15, 2022

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

kg left a comment

Choose a reason for hiding this comment

Uh oh!

pavelsavara commented Sep 16, 2022

Uh oh!

azure-pipelinesBot commented Sep 16, 2022

Uh oh!

pavelsavara commented Sep 17, 2022

Uh oh!

github-actionsBot commented Sep 17, 2022

Uh oh!

github-actionsBot commented Sep 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pavelsavara commented Sep 15, 2022•
edited
Loading