Skip to content

Fix wasm template README - #75696

Merged
pavelsavara merged 4 commits into
dotnet:mainfrom
yamachu:fix-wasm-template
Sep 16, 2022
Merged

Fix wasm template README#75696
pavelsavara merged 4 commits into
dotnet:mainfrom
yamachu:fix-wasm-template

Conversation

@yamachu

@yamachuyamachu commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

README has some typos and invalid arguments that is passed to dotnet cli.

before

# ~/Projects/github.com/yamachu/try-net7-dotnet-webassembly/wasmconsole-rc1 $ [master]
LANG=en_US.UTF-8; dotnet run -c Debug -r browser-wasm -h=nodejs
Description:
.NET Run Command
Usage:
dotnet run [<applicationArguments>...] [options]
Arguments:
<applicationArguments> Arguments passed to the application that is being run. []
Options:
-c, --configuration <CONFIGURATION> The configuration to run for. The default for most projects is 'Debug'.
-f, --framework <FRAMEWORK> The target framework to run for. The target framework must also be specified in the project file.
-r, --runtime <RUNTIME_IDENTIFIER> The target runtime to run for.
--project <project> The path to the project file to run (defaults to the current directory if there is only one project).
-p, --property <property> Properties to be passed to MSBuild.
-lp, --launch-profile <launch-profile> The name of the launch profile (if any) to use when launching the application.
--no-launch-profile Do not attempt to use launchSettings.json to configure the application.
--no-build Do not build the project before running. Implies --no-restore.
--interactive Allows the command to stop and wait for user input or action (for example to complete authentication).
--no-restore Do not restore the project before building.
--sc, --self-contained Publish the .NET runtime with your application so the runtime doesn't need to be installed on the target machine.
The default is 'true' if a runtime identifier is specified.
--no-self-contained Publish your application as a framework dependent application. A compatible .NET runtime must be installed on the target machine to run your application.
-v, --verbosity <LEVEL> Set the MSBuild verbosity level. Allowed values are q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic].
-a, --arch <arch> The target architecture.
--os <os> The target operating system.
-?, -h, --help Show command line help.

after

# ~/Projects/github.com/yamachu/try-net7-dotnet-webassembly/wasmconsole-rc1 $ [master]
LANG=en_US.UTF-8; dotnet run -c Debug -r browser-wasm --h=node
/usr/local/share/dotnet/sdk/7.0.100-rc.1.22431.12/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(1136,5): warning NETSDK1179: One of '--self-contained' or '--no-self-contained' options are required when '--runtime' is used. [/Users/yk-yamada/Projects/github.com/yamachu/try-net7-dotnet-webassembly/wasmconsole-rc1/wasmconsole-rc1.csproj]
WasmAppHost --runtime-config /Users/yk-yamada/Projects/github.com/yamachu/try-net7-dotnet-webassembly/wasmconsole-rc1/bin/Debug/net7.0/browser-wasm/AppBundle//wasmconsole-rc1.runtimeconfig.json --h=node
Running: node main.mjs
Using working directory: /Users/yk-yamada/Projects/github.com/yamachu/try-net7-dotnet-webassembly/wasmconsole-rc1/bin/Debug/net7.0/browser-wasm/AppBundle
mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
Hello, World! Greetings from node version: v16.15.1
Hello, Console!

@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Sep 15, 2022
Comment threadsrc/mono/wasm/templates/templates/console/README.md Outdated

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threadsrc/mono/wasm/templates/templates/console/README.md Outdated
@ghostghost added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Sep 15, 2022

@pavelsavarapavelsavara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks!

@pavelsavara
pavelsavara merged commit 2d99ed7 into dotnet:mainSep 16, 2022
@pavelsavara

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3067629366

@github-actions

Copy link
Copy Markdown
Contributor

@pavelsavara an error occurred while backporting to release/7.0, please check the run log for details!

Error: @pavelsavara is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=pavelsavara

@pavelsavara

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3067647370

@pavelsavara

Copy link
Copy Markdown
Member

/backport to release/7.0-rc2

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3069479243

@ghostghost locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yamachu@pavelsavara@lambdageek