Skip to content

[wasm] Add workaround for msbuild issue in tests - #75743

Merged
radical merged 5 commits into
dotnet:mainfrom
radical:wasm-add-msbuild-workaround
Sep 17, 2022
Merged

[wasm] Add workaround for msbuild issue in tests#75743
radical merged 5 commits into
dotnet:mainfrom
radical:wasm-add-msbuild-workaround

Conversation

@radical

@radicalradical commented Sep 16, 2022

Copy link
Copy Markdown
Member

.. which causes it to crash. Issue - #74328 .

This can be removed once the sdk has a fix for this.

.. which causes it to crash. The issue is described in
dotnet/sdk#26965 besides other issues.
This can be removed once the sdk has a fix for this.
@radicalradical added arch-wasm WebAssembly architecture area-Build-mono labels Sep 16, 2022
@radical
radical requested a review from nariccSeptember 16, 2022 04:56
@ghostghost assigned radicalSep 16, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. which causes it to crash. The issue is described in dotnet/sdk#26965 besides other issues.

This can be removed once the sdk has a fix for this.

Author:radical
Assignees:-
Labels:

arch-wasm, area-Build-mono

Milestone:-

@radicalradical changed the title [wasm] Add workaround for msbuild issue[wasm] Add workaround for msbuild issue in testsSep 16, 2022
@lewing

Copy link
Copy Markdown
Member

#74328

@radical

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm-perf

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulikradekdoulik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radekdoulik

Copy link
Copy Markdown
Member

The failing test looks like #75606

@radical
radical merged commit 2e18999 into dotnet:mainSep 17, 2022
@lewing

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3114802206

@lewing

Copy link
Copy Markdown
Member

@karelz@marcpopMSFT@carlossanlop this was merged in main 6 days ago, do we have any of the msbuild failures in main after that?

@lewing

Copy link
Copy Markdown
Member

cc @rokonec

AR-May added a commit to AR-May/runtime that referenced this pull request Oct 3, 2022
@ghostghost locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@radical@lewing@radekdoulik