Skip to content

[wasm][debugger] Fix behavior of JMC - #75783

Merged
lewing merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_75763
Sep 19, 2022
Merged

[wasm][debugger] Fix behavior of JMC#75783
lewing merged 1 commit into
dotnet:mainfrom
thaystg:thays_fix_75763

Conversation

@thaystg

@thaystgthaystg commented Sep 16, 2022

Copy link
Copy Markdown
Member

We only should hide private members from types that are not UserCode when JMC is enabled.
I understood it wrongly when I implemented, fixing it now.

Fixes#75763

@ghostghost assigned thaystgSep 16, 2022
@ghost

ghost commented Sep 16, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

We only should hide private members from types that are not UserCode when JMC is enabled.
I understood it wrongly when I implemented, fixing it now.

Fixes #75763

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

radical
radical reviewed Sep 17, 2022
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberObjectsExplorer.cs
radical
radical reviewed Sep 17, 2022
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberObjectsExplorer.cs
typeName,
getPropertiesParamBuffer,
getCommandType.HasFlag(GetObjectCommandOptions.ForDebuggerProxyAttribute),
getCommandType,

@radicalradicalSep 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add GetObjectCommandOptions.AutoExpandable when passing this.

@radical

radical commented Sep 17, 2022

Copy link
Copy Markdown
Member

This applies to static members too, correct? Can we adjust any tests for that?

@radical

radical commented Sep 17, 2022

Copy link
Copy Markdown
Member

Would this work for derived classes shadowing private members in base classes?

@lewing
lewing merged commit e818708 into dotnet:mainSep 19, 2022
@thaystg

thaystg commented Sep 19, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0-rc2

@github-actions

github-actionsBot commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3082598820

@github-actionsgithub-actionsBot mentioned this pull request Sep 19, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes

Assignees

@thaystgthaystg

Labels

area-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Web Assembly Blazor debug issue - Childeren could not be evulated

3 participants

@thaystg@radical@lewing