Skip to content

Support a few "shifted register" operations on Arm64 - #75823

Merged
tannergooding merged 10 commits into
dotnet:mainfrom
tannergooding:fix-68028
Sep 27, 2022
Merged

Support a few "shifted register" operations on Arm64#75823
tannergooding merged 10 commits into
dotnet:mainfrom
tannergooding:fix-68028

Conversation

@tannergooding

@tannergoodingtannergooding commented Sep 19, 2022

Copy link
Copy Markdown
Member

This makes progress towards #68028

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 19, 2022
@ghost

ghost commented Sep 19, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes progress towards #68028

Author:tannergooding
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@tannergooding

tannergooding commented Sep 19, 2022

Copy link
Copy Markdown
MemberAuthor

This has more substantial diffs:

coreclr_tests.run.Linux.arm64.checked.mch

Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 490656348 (overridden on cmd)
Total bytes of diff: 490573808 (overridden on cmd)
Total bytes of delta: -82540 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.crossgen2.Linux.arm64.checked.mch:

Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 28398328 (overridden on cmd)
Total bytes of diff: 28392964 (overridden on cmd)
Total bytes of delta: -5364 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.pmi.Linux.arm64.checked.mch:

Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 62290396 (overridden on cmd)
Total bytes of diff: 62256676 (overridden on cmd)
Total bytes of delta: -33720 (-0.05 % of base)
diff is an improvement.
relative diff is an improvement.

libraries_tests.pmi.Linux.arm64.checked.mch:

Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 147821448 (overridden on cmd)
Total bytes of diff: 147787264 (overridden on cmd)
Total bytes of delta: -34184 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

Similar numbers exist for other platforms.

@tannergooding

tannergooding commented Sep 19, 2022

Copy link
Copy Markdown
MemberAuthor

Example diffs are things like:

- lsl w1, w1, #8- orr w0, w0, w1+ orr w0, w0, w1, LSL #8

The couple regressions that do show up are additional alignment bytes inserted, so not really regressions.

@tannergooding
tannergooding marked this pull request as ready for review September 19, 2022 18:19
@tannergooding

tannergooding commented Sep 23, 2022

Copy link
Copy Markdown
MemberAuthor

Rebase onto main to pick up #76061

@tannergooding

tannergooding commented Sep 26, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn

@azure-pipelines

azure-pipelinesBot commented Sep 26, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@tannergooding

tannergooding commented Sep 26, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn

@azure-pipelines

azure-pipelinesBot commented Sep 26, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@tannergooding

tannergooding commented Sep 27, 2022

Copy link
Copy Markdown
MemberAuthor

gcstress failures are unrelated arm32/x86 failures (all new code is under #ifdef TARGET_ARM64) and a case of a timeout that only repro'd 1/2 retries.

jitstress failures are related to the new disasm checks and are being resolved by #76202

@tannergooding

tannergooding commented Sep 27, 2022

Copy link
Copy Markdown
MemberAuthor

This should be ready for review, CC. @dotnet/jit-contrib

SingleAccretion
SingleAccretion reviewed Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp Outdated
Comment threadsrc/coreclr/jit/lowerarmarch.cpp Outdated
tannergooding
tannergooding commented Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
tannergooding
tannergooding commented Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp Outdated
tannergooding
tannergooding commented Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp Outdated
@tannergooding

tannergooding commented Sep 27, 2022

Copy link
Copy Markdown
MemberAuthor

Applied the formatting patch/squashed the applied fixes

SingleAccretion
SingleAccretion approved these changes Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp Outdated
@tannergooding@SingleAccretion
Apply suggestions from code review
00a5bd0
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
EgorBo
EgorBo approved these changes Sep 27, 2022
View reviewed changes

@EgorBoEgorBo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice diffs! and thanks @SingleAccretion for code review 🙂

@tannergooding
tannergooding merged commit 27f1398 into dotnet:mainSep 27, 2022
@tannergooding
tannergooding deleted the fix-68028 branch September 27, 2022 20:30
@kunalspathakkunalspathak mentioned this pull request Sep 29, 2022
Closed
@tannergoodingtannergooding mentioned this pull request Oct 3, 2022
Closed
@jakobbotschjakobbotsch mentioned this pull request Oct 5, 2022
Merged
@DrewScogginsDrewScoggins mentioned this pull request Oct 6, 2022
Open
@ghostghost locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes
+1 more reviewer
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo@SingleAccretion
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Support a few "shifted register" operations on Arm64 by tannergooding · Pull Request #75823 · dotnet/runtime · GitHub
Skip to content
Support a few "shifted register" operations on Arm64 - #75823
Merged
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Sep 27, 2022
Merged
Support a few "shifted register" operations on Arm64#75823
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Conversation
@tannergooding
@tannergoodingtannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
This makes progress towards #68028
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes progress towards #68028
Author:tannergooding
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
This has more substantial diffs:
coreclr_tests.run.Linux.arm64.checked.mch
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 490656348 (overridden on cmd)
Total bytes of diff: 490573808 (overridden on cmd)
Total bytes of delta: -82540 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.crossgen2.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 28398328 (overridden on cmd)
Total bytes of diff: 28392964 (overridden on cmd)
Total bytes of delta: -5364 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 62290396 (overridden on cmd)
Total bytes of diff: 62256676 (overridden on cmd)
Total bytes of delta: -33720 (-0.05 % of base)
diff is an improvement.
relative diff is an improvement.

libraries_tests.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 147821448 (overridden on cmd)
Total bytes of diff: 147787264 (overridden on cmd)
Total bytes of delta: -34184 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

Similar numbers exist for other platforms.
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Example diffs are things like:
- lsl w1, w1, #8- orr w0, w0, w1+ orr w0, w0, w1, LSL #8
The couple regressions that do show up are additional alignment bytes inserted, so not really regressions.
@tannergooding
tannergooding
marked this pull request as ready for review
September 19, 2022 18:19
@tannergooding
tannergooding
commented
Sep 23, 2022

Copy link


Copy Markdown

MemberAuthor
Rebase onto main to pick up #76061
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
gcstress failures are unrelated arm32/x86 failures (all new code is under #ifdef TARGET_ARM64) and a case of a timeout that only repro'd 1/2 retries.
jitstress failures are related to the new disasm checks and are being resolved by #76202
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
This should be ready for review, CC. @dotnet/jit-contrib
SingleAccretion
SingleAccretion
reviewed
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
Applied the formatting patch/squashed the applied fixes
SingleAccretion
SingleAccretion
approved these changes
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding@SingleAccretion
Apply suggestions from code review
00a5bd0
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
EgorBo
EgorBo
approved these changes
Sep 27, 2022
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice diffs! and thanks @SingleAccretion for code review 🙂
@tannergooding
tannergooding
merged commit 27f1398
into
dotnet:mainSep 27, 2022
@tannergooding
tannergooding
deleted the

fix-68028

branch
September 27, 2022 20:30
@kunalspathakkunalspathak
mentioned this pull request
Sep 29, 2022

Closed

@tannergoodingtannergooding
mentioned this pull request
Oct 3, 2022

Closed

@jakobbotschjakobbotsch
mentioned this pull request
Oct 5, 2022
 Merged

@DrewScogginsDrewScoggins
mentioned this pull request
Oct 6, 2022

Open

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support a few "shifted register" operations on Arm64 by tannergooding · Pull Request #75823 · dotnet/runtime · GitHub
Skip to content
Support a few "shifted register" operations on Arm64 - #75823
Merged
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Sep 27, 2022
Merged
Support a few "shifted register" operations on Arm64#75823
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Conversation
@tannergooding
@tannergoodingtannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
This makes progress towards #68028
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes progress towards #68028
Author:tannergooding
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
This has more substantial diffs:
coreclr_tests.run.Linux.arm64.checked.mch
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 490656348 (overridden on cmd)
Total bytes of diff: 490573808 (overridden on cmd)
Total bytes of delta: -82540 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.crossgen2.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 28398328 (overridden on cmd)
Total bytes of diff: 28392964 (overridden on cmd)
Total bytes of delta: -5364 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 62290396 (overridden on cmd)
Total bytes of diff: 62256676 (overridden on cmd)
Total bytes of delta: -33720 (-0.05 % of base)
diff is an improvement.
relative diff is an improvement.

libraries_tests.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 147821448 (overridden on cmd)
Total bytes of diff: 147787264 (overridden on cmd)
Total bytes of delta: -34184 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

Similar numbers exist for other platforms.
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Example diffs are things like:
- lsl w1, w1, #8- orr w0, w0, w1+ orr w0, w0, w1, LSL #8
The couple regressions that do show up are additional alignment bytes inserted, so not really regressions.
@tannergooding
tannergooding
marked this pull request as ready for review
September 19, 2022 18:19
@tannergooding
tannergooding
commented
Sep 23, 2022

Copy link


Copy Markdown

MemberAuthor
Rebase onto main to pick up #76061
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
gcstress failures are unrelated arm32/x86 failures (all new code is under #ifdef TARGET_ARM64) and a case of a timeout that only repro'd 1/2 retries.
jitstress failures are related to the new disasm checks and are being resolved by #76202
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
This should be ready for review, CC. @dotnet/jit-contrib
SingleAccretion
SingleAccretion
reviewed
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
Applied the formatting patch/squashed the applied fixes
SingleAccretion
SingleAccretion
approved these changes
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding@SingleAccretion
Apply suggestions from code review
00a5bd0
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
EgorBo
EgorBo
approved these changes
Sep 27, 2022
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice diffs! and thanks @SingleAccretion for code review 🙂
@tannergooding
tannergooding
merged commit 27f1398
into
dotnet:mainSep 27, 2022
@tannergooding
tannergooding
deleted the

fix-68028

branch
September 27, 2022 20:30
@kunalspathakkunalspathak
mentioned this pull request
Sep 29, 2022

Closed

@tannergoodingtannergooding
mentioned this pull request
Oct 3, 2022

Closed

@jakobbotschjakobbotsch
mentioned this pull request
Oct 5, 2022
 Merged

@DrewScogginsDrewScoggins
mentioned this pull request
Oct 6, 2022

Open

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support a few "shifted register" operations on Arm64 by tannergooding · Pull Request #75823 · dotnet/runtime · GitHub
Skip to content
Support a few "shifted register" operations on Arm64 - #75823
Merged
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Sep 27, 2022
Merged
Support a few "shifted register" operations on Arm64#75823
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Conversation
@tannergooding
@tannergoodingtannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
This makes progress towards #68028
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes progress towards #68028
Author:tannergooding
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
This has more substantial diffs:
coreclr_tests.run.Linux.arm64.checked.mch
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 490656348 (overridden on cmd)
Total bytes of diff: 490573808 (overridden on cmd)
Total bytes of delta: -82540 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.crossgen2.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 28398328 (overridden on cmd)
Total bytes of diff: 28392964 (overridden on cmd)
Total bytes of delta: -5364 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 62290396 (overridden on cmd)
Total bytes of diff: 62256676 (overridden on cmd)
Total bytes of delta: -33720 (-0.05 % of base)
diff is an improvement.
relative diff is an improvement.

libraries_tests.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 147821448 (overridden on cmd)
Total bytes of diff: 147787264 (overridden on cmd)
Total bytes of delta: -34184 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

Similar numbers exist for other platforms.
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Example diffs are things like:
- lsl w1, w1, #8- orr w0, w0, w1+ orr w0, w0, w1, LSL #8
The couple regressions that do show up are additional alignment bytes inserted, so not really regressions.
@tannergooding
tannergooding
marked this pull request as ready for review
September 19, 2022 18:19
@tannergooding
tannergooding
commented
Sep 23, 2022

Copy link


Copy Markdown

MemberAuthor
Rebase onto main to pick up #76061
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
gcstress failures are unrelated arm32/x86 failures (all new code is under #ifdef TARGET_ARM64) and a case of a timeout that only repro'd 1/2 retries.
jitstress failures are related to the new disasm checks and are being resolved by #76202
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
This should be ready for review, CC. @dotnet/jit-contrib
SingleAccretion
SingleAccretion
reviewed
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
Applied the formatting patch/squashed the applied fixes
SingleAccretion
SingleAccretion
approved these changes
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding@SingleAccretion
Apply suggestions from code review
00a5bd0
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
EgorBo
EgorBo
approved these changes
Sep 27, 2022
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice diffs! and thanks @SingleAccretion for code review 🙂
@tannergooding
tannergooding
merged commit 27f1398
into
dotnet:mainSep 27, 2022
@tannergooding
tannergooding
deleted the

fix-68028

branch
September 27, 2022 20:30
@kunalspathakkunalspathak
mentioned this pull request
Sep 29, 2022

Closed

@tannergoodingtannergooding
mentioned this pull request
Oct 3, 2022

Closed

@jakobbotschjakobbotsch
mentioned this pull request
Oct 5, 2022
 Merged

@DrewScogginsDrewScoggins
mentioned this pull request
Oct 6, 2022

Open

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Support a few "shifted register" operations on Arm64 by tannergooding · Pull Request #75823 · dotnet/runtime · GitHub
Skip to content
Support a few "shifted register" operations on Arm64 - #75823
Merged
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Sep 27, 2022
Merged
Support a few "shifted register" operations on Arm64#75823
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Conversation
@tannergooding
@tannergoodingtannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
This makes progress towards #68028
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes progress towards #68028
Author:tannergooding
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
This has more substantial diffs:
coreclr_tests.run.Linux.arm64.checked.mch
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 490656348 (overridden on cmd)
Total bytes of diff: 490573808 (overridden on cmd)
Total bytes of delta: -82540 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.crossgen2.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 28398328 (overridden on cmd)
Total bytes of diff: 28392964 (overridden on cmd)
Total bytes of delta: -5364 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 62290396 (overridden on cmd)
Total bytes of diff: 62256676 (overridden on cmd)
Total bytes of delta: -33720 (-0.05 % of base)
diff is an improvement.
relative diff is an improvement.

libraries_tests.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 147821448 (overridden on cmd)
Total bytes of diff: 147787264 (overridden on cmd)
Total bytes of delta: -34184 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

Similar numbers exist for other platforms.
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Example diffs are things like:
- lsl w1, w1, #8- orr w0, w0, w1+ orr w0, w0, w1, LSL #8
The couple regressions that do show up are additional alignment bytes inserted, so not really regressions.
@tannergooding
tannergooding
marked this pull request as ready for review
September 19, 2022 18:19
@tannergooding
tannergooding
commented
Sep 23, 2022

Copy link


Copy Markdown

MemberAuthor
Rebase onto main to pick up #76061
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
gcstress failures are unrelated arm32/x86 failures (all new code is under #ifdef TARGET_ARM64) and a case of a timeout that only repro'd 1/2 retries.
jitstress failures are related to the new disasm checks and are being resolved by #76202
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
This should be ready for review, CC. @dotnet/jit-contrib
SingleAccretion
SingleAccretion
reviewed
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
Applied the formatting patch/squashed the applied fixes
SingleAccretion
SingleAccretion
approved these changes
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding@SingleAccretion
Apply suggestions from code review
00a5bd0
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
EgorBo
EgorBo
approved these changes
Sep 27, 2022
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice diffs! and thanks @SingleAccretion for code review 🙂
@tannergooding
tannergooding
merged commit 27f1398
into
dotnet:mainSep 27, 2022
@tannergooding
tannergooding
deleted the

fix-68028

branch
September 27, 2022 20:30
@kunalspathakkunalspathak
mentioned this pull request
Sep 29, 2022

Closed

@tannergoodingtannergooding
mentioned this pull request
Oct 3, 2022

Closed

@jakobbotschjakobbotsch
mentioned this pull request
Oct 5, 2022
 Merged

@DrewScogginsDrewScoggins
mentioned this pull request
Oct 6, 2022

Open

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support a few "shifted register" operations on Arm64 by tannergooding · Pull Request #75823 · dotnet/runtime · GitHub
Skip to content
Support a few "shifted register" operations on Arm64 - #75823
Merged
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Sep 27, 2022
Merged
Support a few "shifted register" operations on Arm64#75823
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Conversation
@tannergooding
@tannergoodingtannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
This makes progress towards #68028
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes progress towards #68028
Author:tannergooding
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
This has more substantial diffs:
coreclr_tests.run.Linux.arm64.checked.mch
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 490656348 (overridden on cmd)
Total bytes of diff: 490573808 (overridden on cmd)
Total bytes of delta: -82540 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.crossgen2.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 28398328 (overridden on cmd)
Total bytes of diff: 28392964 (overridden on cmd)
Total bytes of delta: -5364 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 62290396 (overridden on cmd)
Total bytes of diff: 62256676 (overridden on cmd)
Total bytes of delta: -33720 (-0.05 % of base)
diff is an improvement.
relative diff is an improvement.

libraries_tests.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 147821448 (overridden on cmd)
Total bytes of diff: 147787264 (overridden on cmd)
Total bytes of delta: -34184 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

Similar numbers exist for other platforms.
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Example diffs are things like:
- lsl w1, w1, #8- orr w0, w0, w1+ orr w0, w0, w1, LSL #8
The couple regressions that do show up are additional alignment bytes inserted, so not really regressions.
@tannergooding
tannergooding
marked this pull request as ready for review
September 19, 2022 18:19
@tannergooding
tannergooding
commented
Sep 23, 2022

Copy link


Copy Markdown

MemberAuthor
Rebase onto main to pick up #76061
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
gcstress failures are unrelated arm32/x86 failures (all new code is under #ifdef TARGET_ARM64) and a case of a timeout that only repro'd 1/2 retries.
jitstress failures are related to the new disasm checks and are being resolved by #76202
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
This should be ready for review, CC. @dotnet/jit-contrib
SingleAccretion
SingleAccretion
reviewed
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
Applied the formatting patch/squashed the applied fixes
SingleAccretion
SingleAccretion
approved these changes
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding@SingleAccretion
Apply suggestions from code review
00a5bd0
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
EgorBo
EgorBo
approved these changes
Sep 27, 2022
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice diffs! and thanks @SingleAccretion for code review 🙂
@tannergooding
tannergooding
merged commit 27f1398
into
dotnet:mainSep 27, 2022
@tannergooding
tannergooding
deleted the

fix-68028

branch
September 27, 2022 20:30
@kunalspathakkunalspathak
mentioned this pull request
Sep 29, 2022

Closed

@tannergoodingtannergooding
mentioned this pull request
Oct 3, 2022

Closed

@jakobbotschjakobbotsch
mentioned this pull request
Oct 5, 2022
 Merged

@DrewScogginsDrewScoggins
mentioned this pull request
Oct 6, 2022

Open

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support a few "shifted register" operations on Arm64 by tannergooding · Pull Request #75823 · dotnet/runtime · GitHub
Skip to content
Support a few "shifted register" operations on Arm64 - #75823
Merged
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Sep 27, 2022
Merged
Support a few "shifted register" operations on Arm64#75823
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Conversation
@tannergooding
@tannergoodingtannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
This makes progress towards #68028
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes progress towards #68028
Author:tannergooding
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
This has more substantial diffs:
coreclr_tests.run.Linux.arm64.checked.mch
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 490656348 (overridden on cmd)
Total bytes of diff: 490573808 (overridden on cmd)
Total bytes of delta: -82540 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.crossgen2.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 28398328 (overridden on cmd)
Total bytes of diff: 28392964 (overridden on cmd)
Total bytes of delta: -5364 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 62290396 (overridden on cmd)
Total bytes of diff: 62256676 (overridden on cmd)
Total bytes of delta: -33720 (-0.05 % of base)
diff is an improvement.
relative diff is an improvement.

libraries_tests.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 147821448 (overridden on cmd)
Total bytes of diff: 147787264 (overridden on cmd)
Total bytes of delta: -34184 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

Similar numbers exist for other platforms.
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Example diffs are things like:
- lsl w1, w1, #8- orr w0, w0, w1+ orr w0, w0, w1, LSL #8
The couple regressions that do show up are additional alignment bytes inserted, so not really regressions.
@tannergooding
tannergooding
marked this pull request as ready for review
September 19, 2022 18:19
@tannergooding
tannergooding
commented
Sep 23, 2022

Copy link


Copy Markdown

MemberAuthor
Rebase onto main to pick up #76061
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
gcstress failures are unrelated arm32/x86 failures (all new code is under #ifdef TARGET_ARM64) and a case of a timeout that only repro'd 1/2 retries.
jitstress failures are related to the new disasm checks and are being resolved by #76202
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
This should be ready for review, CC. @dotnet/jit-contrib
SingleAccretion
SingleAccretion
reviewed
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
Applied the formatting patch/squashed the applied fixes
SingleAccretion
SingleAccretion
approved these changes
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding@SingleAccretion
Apply suggestions from code review
00a5bd0
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
EgorBo
EgorBo
approved these changes
Sep 27, 2022
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice diffs! and thanks @SingleAccretion for code review 🙂
@tannergooding
tannergooding
merged commit 27f1398
into
dotnet:mainSep 27, 2022
@tannergooding
tannergooding
deleted the

fix-68028

branch
September 27, 2022 20:30
@kunalspathakkunalspathak
mentioned this pull request
Sep 29, 2022

Closed

@tannergoodingtannergooding
mentioned this pull request
Oct 3, 2022

Closed

@jakobbotschjakobbotsch
mentioned this pull request
Oct 5, 2022
 Merged

@DrewScogginsDrewScoggins
mentioned this pull request
Oct 6, 2022

Open

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Support a few "shifted register" operations on Arm64 by tannergooding · Pull Request #75823 · dotnet/runtime · GitHub
Skip to content
Support a few "shifted register" operations on Arm64 - #75823
Merged
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Sep 27, 2022
Merged
Support a few "shifted register" operations on Arm64#75823
tannergooding merged 10 commits into
dotnet:mainfrom 
tannergooding:fix-68028
Conversation
@tannergooding
@tannergoodingtannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
This makes progress towards #68028
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
This makes progress towards #68028
Author:tannergooding
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
This has more substantial diffs:
coreclr_tests.run.Linux.arm64.checked.mch
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 490656348 (overridden on cmd)
Total bytes of diff: 490573808 (overridden on cmd)
Total bytes of delta: -82540 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.crossgen2.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 28398328 (overridden on cmd)
Total bytes of diff: 28392964 (overridden on cmd)
Total bytes of delta: -5364 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

libraries.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 62290396 (overridden on cmd)
Total bytes of diff: 62256676 (overridden on cmd)
Total bytes of delta: -33720 (-0.05 % of base)
diff is an improvement.
relative diff is an improvement.

libraries_tests.pmi.Linux.arm64.checked.mch:
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 147821448 (overridden on cmd)
Total bytes of diff: 147787264 (overridden on cmd)
Total bytes of delta: -34184 (-0.02 % of base)
diff is an improvement.
relative diff is an improvement.

Similar numbers exist for other platforms.
@tannergooding
tannergooding
commented
Sep 19, 2022

Copy link


Copy Markdown

MemberAuthor
Example diffs are things like:
- lsl w1, w1, #8- orr w0, w0, w1+ orr w0, w0, w1, LSL #8
The couple regressions that do show up are additional alignment bytes inserted, so not really regressions.
@tannergooding
tannergooding
marked this pull request as ready for review
September 19, 2022 18:19
@tannergooding
tannergooding
commented
Sep 23, 2022

Copy link


Copy Markdown

MemberAuthor
Rebase onto main to pick up #76061
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 26, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr gcstress0x3-gcstress0xc, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 26, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
gcstress failures are unrelated arm32/x86 failures (all new code is under #ifdef TARGET_ARM64) and a case of a timeout that only repro'd 1/2 retries.
jitstress failures are related to the new disasm checks and are being resolved by #76202
@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
This should be ready for review, CC. @dotnet/jit-contrib
SingleAccretion
SingleAccretion
reviewed
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

tannergooding
tannergooding
commented
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding
tannergooding
commented
Sep 27, 2022

Copy link


Copy Markdown

MemberAuthor
Applied the formatting patch/squashed the applied fixes
SingleAccretion
SingleAccretion
approved these changes
Sep 27, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
Outdated

@tannergooding@SingleAccretion
Apply suggestions from code review
00a5bd0
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
EgorBo
EgorBo
approved these changes
Sep 27, 2022
View reviewed changes
@EgorBoEgorBo
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice diffs! and thanks @SingleAccretion for code review 🙂
@tannergooding
tannergooding
merged commit 27f1398
into
dotnet:mainSep 27, 2022
@tannergooding
tannergooding
deleted the

fix-68028

branch
September 27, 2022 20:30
@kunalspathakkunalspathak
mentioned this pull request
Sep 29, 2022

Closed

@tannergoodingtannergooding
mentioned this pull request
Oct 3, 2022

Closed

@jakobbotschjakobbotsch
mentioned this pull request
Oct 5, 2022
 Merged

@DrewScogginsDrewScoggins
mentioned this pull request
Oct 6, 2022

Open

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes

+1 more reviewer

@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding@EgorBo@SingleAccretion