Uh oh!
There was an error while loading. Please reload this page.
Initial unification of DynamicMethod to be shareable between runtimes - #75829
Merged
Conversation
marek-safarforce-pushed
the
dynmethod
branch
5 times, most recently
from
September 20, 2022 07:40
c93b304 to
edf58a6Comparemarek-safar
marked this pull request as ready for review
September 20, 2022 14:19
marek-safar
requested review from
lambdageek, thaystg and vargaz
as code ownersSeptember 20, 2022 14:19
jkotas
reviewed
Sep 20, 2022
Uh oh!
There was an error while loading. Please reload this page.
jkotas
reviewed
Sep 20, 2022
Uh oh!
There was an error while loading. Please reload this page.
jkotas
approved these changes
Sep 20, 2022
jkotas
left a comment
Member
There was a problem hiding this comment.
CoreCLR changes LGTM, modulo naming nit.
jkotas
reviewed
Sep 21, 2022
| { | ||
| public sealed partial class DynamicMethod : MethodInfo | ||
| { | ||
| private RuntimeType[] parameterTypes; |
Member
There was a problem hiding this comment.
The naming convention is to prefix field names with underscore: https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/coding-style.md
(I should have said to strip the m prefix, not m_ prefix.)
vargaz
commented
Sep 21, 2022
Contributor
The runtime changes look ok to me. |
marek-safar
commented
Sep 22, 2022
ContributorAuthor
Failures are from #75952 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.