Skip to content

Include hostcommon sources in hostfxr static library - #75858

Merged
elinor-fung merged 1 commit into
dotnet:mainfrom
rseanhall:static-hostcommon
Oct 13, 2022
Merged

Include hostcommon sources in hostfxr static library#75858
elinor-fung merged 1 commit into
dotnet:mainfrom
rseanhall:static-hostcommon

Conversation

@rseanhall

@rseanhallrseanhall commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

The hostfxr static library can't be used without this.

@ghostghost added area-Host community-contribution Indicates that the PR has been added by a community member labels Sep 19, 2022
@ghost

ghost commented Sep 19, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

The hostfxr static library can't be used without this.

Author:rseanhall
Assignees:-
Labels:

area-Host

Milestone:-

@rseanhall

rseanhall commented Sep 19, 2022

Copy link
Copy Markdown
ContributorAuthor

I don't know if there's anything that can be done with the build process, but it was harder than I would like to build this change. All I wanted was to build the Microsoft.NETCore.DotNetAppHost packages so I tried to run build -subset host. This failed with:

 InjectResource -> C:\src\dotnet-runtime\artifacts\bin\coreclr\windows.x64.Debug\InjectResource\InjectResource.dll
C:\src\dotnet-runtime\src\native\corehost\corehost.proj(48,5): error MSB3030: Could not copy the file "C:\src\dotnet-ru
ntime\artifacts\bin\coreclr\windows.x64.Debug\/corehost/singlefilehost.exe" because it was not found.

I ended up copying a dummy singlefilehost.exe into the right place and disabling the PrepareSingleFileHostWithEmbeddedDac target because I didn't want to build anything else.

@jkotas

jkotas commented Sep 19, 2022

Copy link
Copy Markdown
Member

Microsoft.NETCore.DotNetAppHost package is bundled into the SDK and installed under c:\Program Files\dotnet\packs\Microsoft.NETCore.App.Host.win-x64. We are adding more stuff to it for niche scenarios that do not look like a good fit for default .NET SDK download.

Do we need to rethink the package structure?

@rseanhall

rseanhall commented Sep 20, 2022

Copy link
Copy Markdown
ContributorAuthor

@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.

Sometime later, the code was refactored and parts of hostfxr were moved into the hostcommon static lib. This is just adding the missing code. I would be fine with a custom host package, but it seems like changing the distribution of these assets seems to be low priority for everyone.

jkotas
jkotas reviewed Sep 20, 2022
View reviewed changes
Comment threadsrc/native/corehost/fxr/standalone/CMakeLists.txt Outdated
@jkotas

jkotas commented Sep 20, 2022

Copy link
Copy Markdown
Member

@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.

Ok, I got confused by the two very similar packages with overlapping content: Microsoft.NETCore.App.Host (bundled into SDK) and Microsoft.NETCore.DotNetAppHost (not bundled into SDK). This change is only adding this to Microsoft.NETCore.DotNetAppHost so my concern about SDK download size is moot.

@vitek-karas For my education: Why do have so much stuff in the package that is bundled into the SDK - how are we deciding what should go into each of these two package?

@jkotas

jkotas commented Sep 20, 2022

Copy link
Copy Markdown
Member

BTW: A solution that was implemented in #72896 for similar problem was to ship the relevant C/C++ sources in the nuget package. I expect we will prefer shipping C/C++ sources for these situations going forward. It avoids the problems with fragility of C/C++ .libs and compiler settings.

@rseanhallrseanhall changed the title Publish hostcommon static libraryInclude hostcommon sources in hostfxr static libraryOct 10, 2022
@build-analysisbuild-analysisBot mentioned this pull request Oct 10, 2022
Closed
2 tasks
@rseanhall

rseanhall commented Oct 11, 2022

Copy link
Copy Markdown
ContributorAuthor
runtime (Build Build OSX x64 release NativeAOT) failure
Building tests via "/Users/runner/work/1/s/eng/common/msbuild.sh" --warnAsError false /Users/runner/work/1/s/src/tests/build.proj /t:TestBuild /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /nodeReuse:false /maxcpucount "/flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log" "/flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn" "/flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err" "/bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog" /p:NUMBER_OF_PROCESSORS=4
/Users/runner/work/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn /flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err /flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /p:NUMBER_OF_PROCESSORS=4 /t:TestBuild /Users/runner/work/1/s/src/tests/build.proj
[17:10:30.75] Restoring all packages...
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies_fs/test_dependencies.fsproj (in 30.52 sec).
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies/test_dependencies.csproj (in 10.14 sec).
/Users/runner/work/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/Users/runner/work/1/s/.dotnet/dotnet" restore -r osx-x64 Common/test_dependencies/test_dependencies.csproj /p:SetTFMForRestore=true /p:TargetOS=OSX /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.
Build FAILED.

This is #74328?

runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.

jkotas
jkotas approved these changes Oct 11, 2022
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas

jkotas commented Oct 11, 2022

Copy link
Copy Markdown
Member

@vitek-karas@elinor-fung Any additional feedback?

elinor-fung
elinor-fung approved these changes Oct 11, 2022
View reviewed changes

@elinor-fungelinor-fung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rseanhall!

@elinor-fung

elinor-fung commented Oct 11, 2022

Copy link
Copy Markdown
Member

runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure

2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.

I think this is #72114.

@elinor-fungelinor-fung mentioned this pull request Oct 11, 2022
Closed
@elinor-fung
elinor-fung merged commit 7c4bd4f into dotnet:mainOct 13, 2022
@ghostghost locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vitek-karasvitek-karasvitek-karas left review comments
@jkotasjkotasjkotas approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@VSadovVSadovAwaiting requested review from VSadov

Assignees

@elinor-fungelinor-fung

Labels

area-Hostcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rseanhall@jkotas@elinor-fung@vitek-karas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Include hostcommon sources in hostfxr static library by rseanhall · Pull Request #75858 · dotnet/runtime · GitHub
Skip to content
Include hostcommon sources in hostfxr static library - #75858
Merged
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Oct 13, 2022
Merged
Include hostcommon sources in hostfxr static library#75858
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Conversation
@rseanhall
@rseanhallrseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

Contributor
The hostfxr static library can't be used without this.
@ghostghost
added

area-Host

community-contribution
Indicates that the PR has been added by a community member
labels
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
The hostfxr static library can't be used without this.
Author:rseanhall
Assignees:-
Labels:
area-Host
Milestone:-
@rseanhall
rseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't know if there's anything that can be done with the build process, but it was harder than I would like to build this change. All I wanted was to build the Microsoft.NETCore.DotNetAppHost packages so I tried to run build -subset host. This failed with:
 InjectResource -> C:\src\dotnet-runtime\artifacts\bin\coreclr\windows.x64.Debug\InjectResource\InjectResource.dll
C:\src\dotnet-runtime\src\native\corehost\corehost.proj(48,5): error MSB3030: Could not copy the file "C:\src\dotnet-ru
ntime\artifacts\bin\coreclr\windows.x64.Debug\/corehost/singlefilehost.exe" because it was not found.

I ended up copying a dummy singlefilehost.exe into the right place and disabling the PrepareSingleFileHostWithEmbeddedDac target because I didn't want to build anything else.
@jkotas
jkotas
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
Microsoft.NETCore.DotNetAppHost package is bundled into the SDK and installed under c:\Program Files\dotnet\packs\Microsoft.NETCore.App.Host.win-x64. We are adding more stuff to it for niche scenarios that do not look like a good fit for default .NET SDK download.
Do we need to rethink the package structure?
@rseanhall
rseanhall
commented
Sep 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Sometime later, the code was refactored and parts of hostfxr were moved into the hostcommon static lib. This is just adding the missing code. I would be fine with a custom host package, but it seems like changing the distribution of these assets seems to be low priority for everyone.
jkotas
jkotas
reviewed
Sep 20, 2022
View reviewed changes
Comment threadsrc/native/corehost/fxr/standalone/CMakeLists.txt
Outdated

@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Ok, I got confused by the two very similar packages with overlapping content: Microsoft.NETCore.App.Host (bundled into SDK) and Microsoft.NETCore.DotNetAppHost (not bundled into SDK). This change is only adding this to Microsoft.NETCore.DotNetAppHost so my concern about SDK download size is moot.
@vitek-karas For my education: Why do have so much stuff in the package that is bundled into the SDK - how are we deciding what should go into each of these two package?
@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
BTW: A solution that was implemented in #72896 for similar problem was to ship the relevant C/C++ sources in the nuget package. I expect we will prefer shipping C/C++ sources for these situations going forward. It avoids the problems with fragility of C/C++ .libs and compiler settings.
@rseanhallrseanhall
changed the title
Publish hostcommon static libraryInclude hostcommon sources in hostfxr static libraryOct 10, 2022
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 10, 2022

Closed

2 tasks
@rseanhall
rseanhall
commented
Oct 11, 2022

Copy link


Copy Markdown

ContributorAuthor
runtime (Build Build OSX x64 release NativeAOT) failure
Building tests via "/Users/runner/work/1/s/eng/common/msbuild.sh" --warnAsError false /Users/runner/work/1/s/src/tests/build.proj /t:TestBuild /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /nodeReuse:false /maxcpucount "/flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log" "/flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn" "/flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err" "/bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog" /p:NUMBER_OF_PROCESSORS=4
/Users/runner/work/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn /flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err /flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /p:NUMBER_OF_PROCESSORS=4 /t:TestBuild /Users/runner/work/1/s/src/tests/build.proj
[17:10:30.75] Restoring all packages...
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies_fs/test_dependencies.fsproj (in 30.52 sec).
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies/test_dependencies.csproj (in 10.14 sec).
/Users/runner/work/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/Users/runner/work/1/s/.dotnet/dotnet" restore -r osx-x64 Common/test_dependencies/test_dependencies.csproj /p:SetTFMForRestore=true /p:TargetOS=OSX /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.
Build FAILED.

This is #74328?
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
jkotas
jkotas
approved these changes
Oct 11, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jkotas
jkotas
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
@vitek-karas@elinor-fung Any additional feedback?
elinor-fung
elinor-fung
approved these changes
Oct 11, 2022
View reviewed changes
@elinor-fungelinor-fung
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rseanhall!
@elinor-fung
elinor-fung
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
I think this is #72114.
@elinor-fungelinor-fung
mentioned this pull request
Oct 11, 2022

Closed

@elinor-fung
elinor-fung
merged commit 7c4bd4f
into
dotnet:mainOct 13, 2022
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@vitek-karasvitek-karasvitek-karas left review comments
@jkotasjkotasjkotas approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@VSadovVSadovAwaiting requested review from VSadov

Assignees

@elinor-fungelinor-fung

Labels

area-Hostcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rseanhall@jkotas@elinor-fung@vitek-karas

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Include hostcommon sources in hostfxr static library by rseanhall · Pull Request #75858 · dotnet/runtime · GitHub
Skip to content
Include hostcommon sources in hostfxr static library - #75858
Merged
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Oct 13, 2022
Merged
Include hostcommon sources in hostfxr static library#75858
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Conversation
@rseanhall
@rseanhallrseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

Contributor
The hostfxr static library can't be used without this.
@ghostghost
added

area-Host

community-contribution
Indicates that the PR has been added by a community member
labels
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
The hostfxr static library can't be used without this.
Author:rseanhall
Assignees:-
Labels:
area-Host
Milestone:-
@rseanhall
rseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't know if there's anything that can be done with the build process, but it was harder than I would like to build this change. All I wanted was to build the Microsoft.NETCore.DotNetAppHost packages so I tried to run build -subset host. This failed with:
 InjectResource -> C:\src\dotnet-runtime\artifacts\bin\coreclr\windows.x64.Debug\InjectResource\InjectResource.dll
C:\src\dotnet-runtime\src\native\corehost\corehost.proj(48,5): error MSB3030: Could not copy the file "C:\src\dotnet-ru
ntime\artifacts\bin\coreclr\windows.x64.Debug\/corehost/singlefilehost.exe" because it was not found.

I ended up copying a dummy singlefilehost.exe into the right place and disabling the PrepareSingleFileHostWithEmbeddedDac target because I didn't want to build anything else.
@jkotas
jkotas
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
Microsoft.NETCore.DotNetAppHost package is bundled into the SDK and installed under c:\Program Files\dotnet\packs\Microsoft.NETCore.App.Host.win-x64. We are adding more stuff to it for niche scenarios that do not look like a good fit for default .NET SDK download.
Do we need to rethink the package structure?
@rseanhall
rseanhall
commented
Sep 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Sometime later, the code was refactored and parts of hostfxr were moved into the hostcommon static lib. This is just adding the missing code. I would be fine with a custom host package, but it seems like changing the distribution of these assets seems to be low priority for everyone.
jkotas
jkotas
reviewed
Sep 20, 2022
View reviewed changes
Comment threadsrc/native/corehost/fxr/standalone/CMakeLists.txt
Outdated

@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Ok, I got confused by the two very similar packages with overlapping content: Microsoft.NETCore.App.Host (bundled into SDK) and Microsoft.NETCore.DotNetAppHost (not bundled into SDK). This change is only adding this to Microsoft.NETCore.DotNetAppHost so my concern about SDK download size is moot.
@vitek-karas For my education: Why do have so much stuff in the package that is bundled into the SDK - how are we deciding what should go into each of these two package?
@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
BTW: A solution that was implemented in #72896 for similar problem was to ship the relevant C/C++ sources in the nuget package. I expect we will prefer shipping C/C++ sources for these situations going forward. It avoids the problems with fragility of C/C++ .libs and compiler settings.
@rseanhallrseanhall
changed the title
Publish hostcommon static libraryInclude hostcommon sources in hostfxr static libraryOct 10, 2022
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 10, 2022

Closed

2 tasks
@rseanhall
rseanhall
commented
Oct 11, 2022

Copy link


Copy Markdown

ContributorAuthor
runtime (Build Build OSX x64 release NativeAOT) failure
Building tests via "/Users/runner/work/1/s/eng/common/msbuild.sh" --warnAsError false /Users/runner/work/1/s/src/tests/build.proj /t:TestBuild /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /nodeReuse:false /maxcpucount "/flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log" "/flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn" "/flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err" "/bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog" /p:NUMBER_OF_PROCESSORS=4
/Users/runner/work/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn /flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err /flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /p:NUMBER_OF_PROCESSORS=4 /t:TestBuild /Users/runner/work/1/s/src/tests/build.proj
[17:10:30.75] Restoring all packages...
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies_fs/test_dependencies.fsproj (in 30.52 sec).
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies/test_dependencies.csproj (in 10.14 sec).
/Users/runner/work/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/Users/runner/work/1/s/.dotnet/dotnet" restore -r osx-x64 Common/test_dependencies/test_dependencies.csproj /p:SetTFMForRestore=true /p:TargetOS=OSX /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.
Build FAILED.

This is #74328?
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
jkotas
jkotas
approved these changes
Oct 11, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jkotas
jkotas
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
@vitek-karas@elinor-fung Any additional feedback?
elinor-fung
elinor-fung
approved these changes
Oct 11, 2022
View reviewed changes
@elinor-fungelinor-fung
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rseanhall!
@elinor-fung
elinor-fung
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
I think this is #72114.
@elinor-fungelinor-fung
mentioned this pull request
Oct 11, 2022

Closed

@elinor-fung
elinor-fung
merged commit 7c4bd4f
into
dotnet:mainOct 13, 2022
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@vitek-karasvitek-karasvitek-karas left review comments
@jkotasjkotasjkotas approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@VSadovVSadovAwaiting requested review from VSadov

Assignees

@elinor-fungelinor-fung

Labels

area-Hostcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rseanhall@jkotas@elinor-fung@vitek-karas

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Include hostcommon sources in hostfxr static library by rseanhall · Pull Request #75858 · dotnet/runtime · GitHub
Skip to content
Include hostcommon sources in hostfxr static library - #75858
Merged
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Oct 13, 2022
Merged
Include hostcommon sources in hostfxr static library#75858
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Conversation
@rseanhall
@rseanhallrseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

Contributor
The hostfxr static library can't be used without this.
@ghostghost
added

area-Host

community-contribution
Indicates that the PR has been added by a community member
labels
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
The hostfxr static library can't be used without this.
Author:rseanhall
Assignees:-
Labels:
area-Host
Milestone:-
@rseanhall
rseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't know if there's anything that can be done with the build process, but it was harder than I would like to build this change. All I wanted was to build the Microsoft.NETCore.DotNetAppHost packages so I tried to run build -subset host. This failed with:
 InjectResource -> C:\src\dotnet-runtime\artifacts\bin\coreclr\windows.x64.Debug\InjectResource\InjectResource.dll
C:\src\dotnet-runtime\src\native\corehost\corehost.proj(48,5): error MSB3030: Could not copy the file "C:\src\dotnet-ru
ntime\artifacts\bin\coreclr\windows.x64.Debug\/corehost/singlefilehost.exe" because it was not found.

I ended up copying a dummy singlefilehost.exe into the right place and disabling the PrepareSingleFileHostWithEmbeddedDac target because I didn't want to build anything else.
@jkotas
jkotas
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
Microsoft.NETCore.DotNetAppHost package is bundled into the SDK and installed under c:\Program Files\dotnet\packs\Microsoft.NETCore.App.Host.win-x64. We are adding more stuff to it for niche scenarios that do not look like a good fit for default .NET SDK download.
Do we need to rethink the package structure?
@rseanhall
rseanhall
commented
Sep 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Sometime later, the code was refactored and parts of hostfxr were moved into the hostcommon static lib. This is just adding the missing code. I would be fine with a custom host package, but it seems like changing the distribution of these assets seems to be low priority for everyone.
jkotas
jkotas
reviewed
Sep 20, 2022
View reviewed changes
Comment threadsrc/native/corehost/fxr/standalone/CMakeLists.txt
Outdated

@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Ok, I got confused by the two very similar packages with overlapping content: Microsoft.NETCore.App.Host (bundled into SDK) and Microsoft.NETCore.DotNetAppHost (not bundled into SDK). This change is only adding this to Microsoft.NETCore.DotNetAppHost so my concern about SDK download size is moot.
@vitek-karas For my education: Why do have so much stuff in the package that is bundled into the SDK - how are we deciding what should go into each of these two package?
@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
BTW: A solution that was implemented in #72896 for similar problem was to ship the relevant C/C++ sources in the nuget package. I expect we will prefer shipping C/C++ sources for these situations going forward. It avoids the problems with fragility of C/C++ .libs and compiler settings.
@rseanhallrseanhall
changed the title
Publish hostcommon static libraryInclude hostcommon sources in hostfxr static libraryOct 10, 2022
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 10, 2022

Closed

2 tasks
@rseanhall
rseanhall
commented
Oct 11, 2022

Copy link


Copy Markdown

ContributorAuthor
runtime (Build Build OSX x64 release NativeAOT) failure
Building tests via "/Users/runner/work/1/s/eng/common/msbuild.sh" --warnAsError false /Users/runner/work/1/s/src/tests/build.proj /t:TestBuild /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /nodeReuse:false /maxcpucount "/flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log" "/flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn" "/flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err" "/bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog" /p:NUMBER_OF_PROCESSORS=4
/Users/runner/work/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn /flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err /flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /p:NUMBER_OF_PROCESSORS=4 /t:TestBuild /Users/runner/work/1/s/src/tests/build.proj
[17:10:30.75] Restoring all packages...
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies_fs/test_dependencies.fsproj (in 30.52 sec).
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies/test_dependencies.csproj (in 10.14 sec).
/Users/runner/work/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/Users/runner/work/1/s/.dotnet/dotnet" restore -r osx-x64 Common/test_dependencies/test_dependencies.csproj /p:SetTFMForRestore=true /p:TargetOS=OSX /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.
Build FAILED.

This is #74328?
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
jkotas
jkotas
approved these changes
Oct 11, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jkotas
jkotas
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
@vitek-karas@elinor-fung Any additional feedback?
elinor-fung
elinor-fung
approved these changes
Oct 11, 2022
View reviewed changes
@elinor-fungelinor-fung
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rseanhall!
@elinor-fung
elinor-fung
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
I think this is #72114.
@elinor-fungelinor-fung
mentioned this pull request
Oct 11, 2022

Closed

@elinor-fung
elinor-fung
merged commit 7c4bd4f
into
dotnet:mainOct 13, 2022
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@vitek-karasvitek-karasvitek-karas left review comments
@jkotasjkotasjkotas approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@VSadovVSadovAwaiting requested review from VSadov

Assignees

@elinor-fungelinor-fung

Labels

area-Hostcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rseanhall@jkotas@elinor-fung@vitek-karas

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Include hostcommon sources in hostfxr static library by rseanhall · Pull Request #75858 · dotnet/runtime · GitHub
Skip to content
Include hostcommon sources in hostfxr static library - #75858
Merged
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Oct 13, 2022
Merged
Include hostcommon sources in hostfxr static library#75858
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Conversation
@rseanhall
@rseanhallrseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

Contributor
The hostfxr static library can't be used without this.
@ghostghost
added

area-Host

community-contribution
Indicates that the PR has been added by a community member
labels
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
The hostfxr static library can't be used without this.
Author:rseanhall
Assignees:-
Labels:
area-Host
Milestone:-
@rseanhall
rseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't know if there's anything that can be done with the build process, but it was harder than I would like to build this change. All I wanted was to build the Microsoft.NETCore.DotNetAppHost packages so I tried to run build -subset host. This failed with:
 InjectResource -> C:\src\dotnet-runtime\artifacts\bin\coreclr\windows.x64.Debug\InjectResource\InjectResource.dll
C:\src\dotnet-runtime\src\native\corehost\corehost.proj(48,5): error MSB3030: Could not copy the file "C:\src\dotnet-ru
ntime\artifacts\bin\coreclr\windows.x64.Debug\/corehost/singlefilehost.exe" because it was not found.

I ended up copying a dummy singlefilehost.exe into the right place and disabling the PrepareSingleFileHostWithEmbeddedDac target because I didn't want to build anything else.
@jkotas
jkotas
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
Microsoft.NETCore.DotNetAppHost package is bundled into the SDK and installed under c:\Program Files\dotnet\packs\Microsoft.NETCore.App.Host.win-x64. We are adding more stuff to it for niche scenarios that do not look like a good fit for default .NET SDK download.
Do we need to rethink the package structure?
@rseanhall
rseanhall
commented
Sep 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Sometime later, the code was refactored and parts of hostfxr were moved into the hostcommon static lib. This is just adding the missing code. I would be fine with a custom host package, but it seems like changing the distribution of these assets seems to be low priority for everyone.
jkotas
jkotas
reviewed
Sep 20, 2022
View reviewed changes
Comment threadsrc/native/corehost/fxr/standalone/CMakeLists.txt
Outdated

@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Ok, I got confused by the two very similar packages with overlapping content: Microsoft.NETCore.App.Host (bundled into SDK) and Microsoft.NETCore.DotNetAppHost (not bundled into SDK). This change is only adding this to Microsoft.NETCore.DotNetAppHost so my concern about SDK download size is moot.
@vitek-karas For my education: Why do have so much stuff in the package that is bundled into the SDK - how are we deciding what should go into each of these two package?
@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
BTW: A solution that was implemented in #72896 for similar problem was to ship the relevant C/C++ sources in the nuget package. I expect we will prefer shipping C/C++ sources for these situations going forward. It avoids the problems with fragility of C/C++ .libs and compiler settings.
@rseanhallrseanhall
changed the title
Publish hostcommon static libraryInclude hostcommon sources in hostfxr static libraryOct 10, 2022
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 10, 2022

Closed

2 tasks
@rseanhall
rseanhall
commented
Oct 11, 2022

Copy link


Copy Markdown

ContributorAuthor
runtime (Build Build OSX x64 release NativeAOT) failure
Building tests via "/Users/runner/work/1/s/eng/common/msbuild.sh" --warnAsError false /Users/runner/work/1/s/src/tests/build.proj /t:TestBuild /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /nodeReuse:false /maxcpucount "/flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log" "/flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn" "/flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err" "/bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog" /p:NUMBER_OF_PROCESSORS=4
/Users/runner/work/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn /flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err /flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /p:NUMBER_OF_PROCESSORS=4 /t:TestBuild /Users/runner/work/1/s/src/tests/build.proj
[17:10:30.75] Restoring all packages...
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies_fs/test_dependencies.fsproj (in 30.52 sec).
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies/test_dependencies.csproj (in 10.14 sec).
/Users/runner/work/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/Users/runner/work/1/s/.dotnet/dotnet" restore -r osx-x64 Common/test_dependencies/test_dependencies.csproj /p:SetTFMForRestore=true /p:TargetOS=OSX /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.
Build FAILED.

This is #74328?
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
jkotas
jkotas
approved these changes
Oct 11, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jkotas
jkotas
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
@vitek-karas@elinor-fung Any additional feedback?
elinor-fung
elinor-fung
approved these changes
Oct 11, 2022
View reviewed changes
@elinor-fungelinor-fung
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rseanhall!
@elinor-fung
elinor-fung
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
I think this is #72114.
@elinor-fungelinor-fung
mentioned this pull request
Oct 11, 2022

Closed

@elinor-fung
elinor-fung
merged commit 7c4bd4f
into
dotnet:mainOct 13, 2022
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@vitek-karasvitek-karasvitek-karas left review comments
@jkotasjkotasjkotas approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@VSadovVSadovAwaiting requested review from VSadov

Assignees

@elinor-fungelinor-fung

Labels

area-Hostcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rseanhall@jkotas@elinor-fung@vitek-karas

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Include hostcommon sources in hostfxr static library by rseanhall · Pull Request #75858 · dotnet/runtime · GitHub
Skip to content
Include hostcommon sources in hostfxr static library - #75858
Merged
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Oct 13, 2022
Merged
Include hostcommon sources in hostfxr static library#75858
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Conversation
@rseanhall
@rseanhallrseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

Contributor
The hostfxr static library can't be used without this.
@ghostghost
added

area-Host

community-contribution
Indicates that the PR has been added by a community member
labels
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
The hostfxr static library can't be used without this.
Author:rseanhall
Assignees:-
Labels:
area-Host
Milestone:-
@rseanhall
rseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't know if there's anything that can be done with the build process, but it was harder than I would like to build this change. All I wanted was to build the Microsoft.NETCore.DotNetAppHost packages so I tried to run build -subset host. This failed with:
 InjectResource -> C:\src\dotnet-runtime\artifacts\bin\coreclr\windows.x64.Debug\InjectResource\InjectResource.dll
C:\src\dotnet-runtime\src\native\corehost\corehost.proj(48,5): error MSB3030: Could not copy the file "C:\src\dotnet-ru
ntime\artifacts\bin\coreclr\windows.x64.Debug\/corehost/singlefilehost.exe" because it was not found.

I ended up copying a dummy singlefilehost.exe into the right place and disabling the PrepareSingleFileHostWithEmbeddedDac target because I didn't want to build anything else.
@jkotas
jkotas
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
Microsoft.NETCore.DotNetAppHost package is bundled into the SDK and installed under c:\Program Files\dotnet\packs\Microsoft.NETCore.App.Host.win-x64. We are adding more stuff to it for niche scenarios that do not look like a good fit for default .NET SDK download.
Do we need to rethink the package structure?
@rseanhall
rseanhall
commented
Sep 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Sometime later, the code was refactored and parts of hostfxr were moved into the hostcommon static lib. This is just adding the missing code. I would be fine with a custom host package, but it seems like changing the distribution of these assets seems to be low priority for everyone.
jkotas
jkotas
reviewed
Sep 20, 2022
View reviewed changes
Comment threadsrc/native/corehost/fxr/standalone/CMakeLists.txt
Outdated

@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Ok, I got confused by the two very similar packages with overlapping content: Microsoft.NETCore.App.Host (bundled into SDK) and Microsoft.NETCore.DotNetAppHost (not bundled into SDK). This change is only adding this to Microsoft.NETCore.DotNetAppHost so my concern about SDK download size is moot.
@vitek-karas For my education: Why do have so much stuff in the package that is bundled into the SDK - how are we deciding what should go into each of these two package?
@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
BTW: A solution that was implemented in #72896 for similar problem was to ship the relevant C/C++ sources in the nuget package. I expect we will prefer shipping C/C++ sources for these situations going forward. It avoids the problems with fragility of C/C++ .libs and compiler settings.
@rseanhallrseanhall
changed the title
Publish hostcommon static libraryInclude hostcommon sources in hostfxr static libraryOct 10, 2022
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 10, 2022

Closed

2 tasks
@rseanhall
rseanhall
commented
Oct 11, 2022

Copy link


Copy Markdown

ContributorAuthor
runtime (Build Build OSX x64 release NativeAOT) failure
Building tests via "/Users/runner/work/1/s/eng/common/msbuild.sh" --warnAsError false /Users/runner/work/1/s/src/tests/build.proj /t:TestBuild /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /nodeReuse:false /maxcpucount "/flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log" "/flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn" "/flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err" "/bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog" /p:NUMBER_OF_PROCESSORS=4
/Users/runner/work/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn /flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err /flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /p:NUMBER_OF_PROCESSORS=4 /t:TestBuild /Users/runner/work/1/s/src/tests/build.proj
[17:10:30.75] Restoring all packages...
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies_fs/test_dependencies.fsproj (in 30.52 sec).
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies/test_dependencies.csproj (in 10.14 sec).
/Users/runner/work/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/Users/runner/work/1/s/.dotnet/dotnet" restore -r osx-x64 Common/test_dependencies/test_dependencies.csproj /p:SetTFMForRestore=true /p:TargetOS=OSX /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.
Build FAILED.

This is #74328?
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
jkotas
jkotas
approved these changes
Oct 11, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jkotas
jkotas
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
@vitek-karas@elinor-fung Any additional feedback?
elinor-fung
elinor-fung
approved these changes
Oct 11, 2022
View reviewed changes
@elinor-fungelinor-fung
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rseanhall!
@elinor-fung
elinor-fung
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
I think this is #72114.
@elinor-fungelinor-fung
mentioned this pull request
Oct 11, 2022

Closed

@elinor-fung
elinor-fung
merged commit 7c4bd4f
into
dotnet:mainOct 13, 2022
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@vitek-karasvitek-karasvitek-karas left review comments
@jkotasjkotasjkotas approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@VSadovVSadovAwaiting requested review from VSadov

Assignees

@elinor-fungelinor-fung

Labels

area-Hostcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rseanhall@jkotas@elinor-fung@vitek-karas

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Include hostcommon sources in hostfxr static library by rseanhall · Pull Request #75858 · dotnet/runtime · GitHub
Skip to content
Include hostcommon sources in hostfxr static library - #75858
Merged
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Oct 13, 2022
Merged
Include hostcommon sources in hostfxr static library#75858
elinor-fung merged 1 commit into
dotnet:mainfrom 
rseanhall:static-hostcommon
Conversation
@rseanhall
@rseanhallrseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

Contributor
The hostfxr static library can't be used without this.
@ghostghost
added

area-Host

community-contribution
Indicates that the PR has been added by a community member
labels
Sep 19, 2022
@ghost
ghost
commented
Sep 19, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
The hostfxr static library can't be used without this.
Author:rseanhall
Assignees:-
Labels:
area-Host
Milestone:-
@rseanhall
rseanhall
commented
Sep 19, 2022

Copy link


Copy Markdown

ContributorAuthor
I don't know if there's anything that can be done with the build process, but it was harder than I would like to build this change. All I wanted was to build the Microsoft.NETCore.DotNetAppHost packages so I tried to run build -subset host. This failed with:
 InjectResource -> C:\src\dotnet-runtime\artifacts\bin\coreclr\windows.x64.Debug\InjectResource\InjectResource.dll
C:\src\dotnet-runtime\src\native\corehost\corehost.proj(48,5): error MSB3030: Could not copy the file "C:\src\dotnet-ru
ntime\artifacts\bin\coreclr\windows.x64.Debug\/corehost/singlefilehost.exe" because it was not found.

I ended up copying a dummy singlefilehost.exe into the right place and disabling the PrepareSingleFileHostWithEmbeddedDac target because I didn't want to build anything else.
@jkotas
jkotas
commented
Sep 19, 2022

Copy link


Copy Markdown

Member
Microsoft.NETCore.DotNetAppHost package is bundled into the SDK and installed under c:\Program Files\dotnet\packs\Microsoft.NETCore.App.Host.win-x64. We are adding more stuff to it for niche scenarios that do not look like a good fit for default .NET SDK download.
Do we need to rethink the package structure?
@rseanhall
rseanhall
commented
Sep 20, 2022

Copy link


Copy Markdown

ContributorAuthor
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Sometime later, the code was refactored and parts of hostfxr were moved into the hostcommon static lib. This is just adding the missing code. I would be fine with a custom host package, but it seems like changing the distribution of these assets seems to be low priority for everyone.
jkotas
jkotas
reviewed
Sep 20, 2022
View reviewed changes
Comment threadsrc/native/corehost/fxr/standalone/CMakeLists.txt
Outdated

@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
@jkotas That is not what I see. I added libhostfxr.lib to the package in .NET 6 and I don't see that file in the path you provided for .NET 6.0.8 or .NET 7 RC1.
Ok, I got confused by the two very similar packages with overlapping content: Microsoft.NETCore.App.Host (bundled into SDK) and Microsoft.NETCore.DotNetAppHost (not bundled into SDK). This change is only adding this to Microsoft.NETCore.DotNetAppHost so my concern about SDK download size is moot.
@vitek-karas For my education: Why do have so much stuff in the package that is bundled into the SDK - how are we deciding what should go into each of these two package?
@jkotas
jkotas
commented
Sep 20, 2022

Copy link


Copy Markdown

Member
BTW: A solution that was implemented in #72896 for similar problem was to ship the relevant C/C++ sources in the nuget package. I expect we will prefer shipping C/C++ sources for these situations going forward. It avoids the problems with fragility of C/C++ .libs and compiler settings.
@rseanhallrseanhall
changed the title
Publish hostcommon static libraryInclude hostcommon sources in hostfxr static libraryOct 10, 2022
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 10, 2022

Closed

2 tasks
@rseanhall
rseanhall
commented
Oct 11, 2022

Copy link


Copy Markdown

ContributorAuthor
runtime (Build Build OSX x64 release NativeAOT) failure
Building tests via "/Users/runner/work/1/s/eng/common/msbuild.sh" --warnAsError false /Users/runner/work/1/s/src/tests/build.proj /t:TestBuild /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /nodeReuse:false /maxcpucount "/flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log" "/flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn" "/flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err" "/bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog" /p:NUMBER_OF_PROCESSORS=4
/Users/runner/work/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m /maxcpucount -verbosity:m /v:minimal /bl:/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.binlog /clp:Summary /flp1:WarningsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.wrn /flp2:ErrorsOnly;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.err /flp:Verbosity=normal;LogFile=/Users/runner/work/1/s/artifacts/log/TestBuild.OSX.x64.Release.log /nr:true /nodeReuse:false /p:TreatWarningsAsErrors=false /p:ContinuousIntegrationBuild=false /p:TargetArchitecture=x64 /p:Configuration=Release /p:TargetOS=OSX /p:NUMBER_OF_PROCESSORS=4 /t:TestBuild /Users/runner/work/1/s/src/tests/build.proj
[17:10:30.75] Restoring all packages...
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies_fs/test_dependencies.fsproj (in 30.52 sec).
Determining projects to restore...
Restored /Users/runner/work/1/s/src/tests/Common/test_dependencies/test_dependencies.csproj (in 10.14 sec).
/Users/runner/work/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/Users/runner/work/1/s/.dotnet/dotnet" restore -r osx-x64 Common/test_dependencies/test_dependencies.csproj /p:SetTFMForRestore=true /p:TargetOS=OSX /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.
Build FAILED.

This is #74328?
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
jkotas
jkotas
approved these changes
Oct 11, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jkotas
jkotas
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
@vitek-karas@elinor-fung Any additional feedback?
elinor-fung
elinor-fung
approved these changes
Oct 11, 2022
View reviewed changes
@elinor-fungelinor-fung
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rseanhall!
@elinor-fung
elinor-fung
commented
Oct 11, 2022

Copy link


Copy Markdown

Member
runtime (Build mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) failure
2022-10-10T17:37:44.1809505Z /__w/1/s/src/mono/msbuild/aot-compile.proj(19,9): error MSB3073: The command "/__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /__w/1/s/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/xunit.execution.dotnet.dll" exited with code 255.
2022-10-10T17:37:44.1810593Z BEGIN : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]
2022-10-10T17:37:44.1811488Z END : coreclr_initialize failed - error : 0x80004005 [/__w/1/s/src/mono/msbuild/aot-compile.proj]

I don't think this was caused by my change. If it were, I would expect the arm64 build to have failed as well.
I think this is #72114.
@elinor-fungelinor-fung
mentioned this pull request
Oct 11, 2022

Closed

@elinor-fung
elinor-fung
merged commit 7c4bd4f
into
dotnet:mainOct 13, 2022
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 12, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@vitek-karasvitek-karasvitek-karas left review comments
@jkotasjkotasjkotas approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@VSadovVSadovAwaiting requested review from VSadov

Assignees

@elinor-fungelinor-fung

Labels

area-Hostcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@rseanhall@jkotas@elinor-fung@vitek-karas