Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Fix servicing failures when building coreclr nuget packages - #75899
Conversation
Fixes the failures in the 7.0.1 test servicing build: ``` /__w/1/s/.packages/microsoft.dotnet.build.tasks.packaging/7.0.0-beta.22416.1/build/Packaging.targets(800,5): error : No VersionSuffix was set. Ensure it is set before targets in packaging are ran. [/__w/1/s/src/coreclr/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj] ##[error].packages/microsoft.dotnet.build.tasks.packaging/7.0.0-beta.22416.1/build/Packaging.targets(800,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) No VersionSuffix was set. Ensure it is set before targets in packaging are ran. /__w/1/s/.packages/microsoft.dotnet.build.tasks.packaging/7.0.0-beta.22416.1/build/Packaging.targets(800,5): error : No VersionSuffix was set. Ensure it is set before targets in packaging are ran. [/__w/1/s/src/coreclr/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj] ##[error].packages/microsoft.dotnet.build.tasks.packaging/7.0.0-beta.22416.1/build/Packaging.targets(800,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) No VersionSuffix was set. Ensure it is set before targets in packaging are ran. ```
ghost
commented
Sep 20, 2022
Tagging subscribers to this area: @hoyosjs Issue DetailsBackport of #75884 to release/7.0 /cc @ViktorHofer Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
ViktorHofer
commented
Sep 20, 2022
@jeffschwMSFT this infrastructure change is necessary to successfully build 7.0.x servicing bits. This was already part of release/6.0 but was never forward ported into main. Please see the linked issue for more details. I assume this is a tell-mode only change and can be merged without additional approvals? |
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. agree this is tell mode. is the failing ci related?
ViktorHofer
commented
Sep 20, 2022
I don't think so. Seems to be another AzDO flakiness/outage: |
Backport of #75884 to release/7.0
/cc @ViktorHofer
Customer Impact
Testing
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.