Skip to content

[wasm] Don't use MS.Build.NoTargets SDK for runtime tests - #75939

Merged
lewing merged 1 commit into
dotnet:mainfrom
radical:wasm-runtimetests
Sep 21, 2022
Merged

[wasm] Don't use MS.Build.NoTargets SDK for runtime tests#75939
lewing merged 1 commit into
dotnet:mainfrom
radical:wasm-runtimetests

Conversation

@radical

@radicalradical commented Sep 21, 2022

Copy link
Copy Markdown
Member

This will also avoid intermittent failures like #75391

@radical
[wasm] Don't use MS.Build.NoTargets SDK for runtime tests
ddeb41c
This will also avoid intermittent failures like dotnet#75391
@ghostghost assigned radicalSep 21, 2022
@ghost

ghost commented Sep 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This will also avoid intermittent failures like #75391

Author:radical
Assignees:radical
Labels:

area-Infrastructure-mono

Milestone:-

@radical
radical marked this pull request as ready for review September 21, 2022 02:13
@lewing
lewing merged commit 0d765e9 into dotnet:mainSep 21, 2022
@radical
radical deleted the wasm-runtimetests branch September 21, 2022 02:51
@nariccnaricc mentioned this pull request Sep 23, 2022
Closed
@radical

radical commented Sep 23, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3116150518

@github-actionsgithub-actionsBot mentioned this pull request Sep 23, 2022
Merged
@ViktorHofer

ViktorHofer commented Sep 26, 2022

Copy link
Copy Markdown
Member

Were you able to root cause why the Microsoft.Build.NoTargets SDK caused problems? cc @jeffkl

@jeffkl

jeffkl commented Sep 26, 2022

Copy link
Copy Markdown

Were you able to root cause why the Microsoft.Build.NoTargets SDK caused problems? cc @jeffkl

It looks like an issue with the NuGet-based MSBuild project SDK resolver. This is tracked here: NuGet/Home#10935

And I'm actively working on major improvements to the resolver: NuGet/Home#11441

Not using NoTargets is a fine workaround in the meantime though, especially if you don't really need it.

@ghostghost locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@nariccnariccAwaiting requested review from naricc
@steveisoksteveisokAwaiting requested review from steveisok

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@ViktorHofer@jeffkl@lewing