Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Fix public key token of Serialization.Schema contract assembly - #75973
Conversation
The Microsoft public key token was only applied to the source assembly but not to the contract.
ghost
commented
Sep 21, 2022
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #75963 to release/7.0 /cc @ViktorHofer Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
ViktorHofer
commented
Sep 21, 2022
I talked with @ericstj about this offline and we want to treat this as an infrastructure change as nothing is impacted yet but presumably a library in this repo could start referencing the Serialization.Schema library still before GA. |
ViktorHofer
commented
Sep 21, 2022
Tell mode change, cc @ericstj@danmoseley |
Backport of #75963 to release/7.0
/cc @ViktorHofer
Customer Impact
Right now, this change doesn't correct any observable broken customer impact as no library in dotnet/runtime yet bind against Serialization.Schema. Still, I decided to create a backport as presumably a library in this repo could start referencing it and then backport such a change into release/7.0.
Testing
I verified that the produced contract and implementation assembly now contain the Microsoft strong name public key token. Automation to capture this as part of the build will be enabled in main as part of #73263.
Risk
Low. The public key token in the contract will be changed from Open to Microsoft. The package only supports modern .NET (net7.0), which means this isn't applicable to .NET Framework and the contract assembly doesn't even ship inside the package. This only affects libraries inside dotnet/runtiem that bind against the Serialization.Schema's contract assembly (via a ProjectReference).