Skip to content

[release/7.0] Remove locks from COM events delegate management. - #76034

Merged
carlossanlop merged 9 commits into
release/7.0from
backport/pr-75863-to-release/7.0
Sep 27, 2022
Merged

[release/7.0] Remove locks from COM events delegate management.#76034
carlossanlop merged 9 commits into
release/7.0from
backport/pr-75863-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Backport of #75863 to release/7.0

/cc @AaronRobinsonMSFT, @stephentoub

Customer Impact

This is a customer reported issue - #75863, both internal and external to Microsoft. The issue is triggering a COM Event A when handling a COM Event A. It represents a regression form .NET Framework. It was introduced in .NET Core 3.1, but as more people start to move onto .NET 5+ this will hit more. It is limited to COM Events so narrow in customer base, but those that use it will find it difficult to adopt as there is no workaround.

Testing

Validated this using a customer reproduction example. No new test was added due to the complexity of scenario and the narrowness of impact. The implementation was reduced in complexity substantially and is now more in line with best-practice concurrency related solutions in .NET Core.

Risk

This is a minor risk. Invoke locks were removed and immutability of a collection introduced. The reduction of complexity represented in the functional change makes this lower risk but the scenario is limited to COM Events which are even rarer so supporting a minor risk designation.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75863 to release/7.0

/cc @AaronRobinsonMSFT

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-System.Runtime.InteropServices

Milestone:-

@AaronRobinsonMSFTAaronRobinsonMSFT added the Servicing-consider Issue for next servicing release review label Sep 22, 2022
@AaronRobinsonMSFTAaronRobinsonMSFT added this to the 7.0.x milestone Sep 22, 2022

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review. we will take for consideration in 7 ga

@carlossanlop

Copy link
Copy Markdown
Contributor

@AaronRobinsonMSFT don't forget to send the email to Tactics requesting approval, if you haven't done so.

@jeffschwMSFT

Copy link
Copy Markdown
Member

We can take during tactics tomorrow

@JulieLeeMSFT

Copy link
Copy Markdown
Member

@carlossanlop, this is approved over an email.

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 27, 2022
@carlossanlopcarlossanlop modified the milestones: 7.0.x, 7.0.0Sep 27, 2022
@carlossanlop

Copy link
Copy Markdown
Contributor

Approved by Tactics, signed off, CI is green. Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit f1451fc into release/7.0Sep 27, 2022
@carlossanlop
carlossanlop deleted the backport/pr-75863-to-release/7.0 branch September 27, 2022 20:25
@ghostghost locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@carlossanlop@jeffschwMSFT@JulieLeeMSFT@stephentoub@AaronRobinsonMSFT