Skip to content

Ensure gc collects memory for CriticalFinalizer test - #76046

Closed
HJLeee wants to merge 1 commit into
dotnet:mainfrom
HJLeee:cft
Closed

Ensure gc collects memory for CriticalFinalizer test#76046
HJLeee wants to merge 1 commit into
dotnet:mainfrom
HJLeee:cft

Conversation

@HJLeee

Copy link
Copy Markdown
Contributor

Test assumes GC.Collect() successfully collects allocated Normal and Critical objects.

Finalized 0 Normal and 0 Critical objects.
The first Critical object was finalized after 0 Normal objects.

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-76007-merge-ac12cc893b1f4aa0bc/baseservices.finalization/1/console.34afcb43.log?helixlogtype=result

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Sep 22, 2022
@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@AntonLapounov

Copy link
Copy Markdown
Contributor

Thank you. This does not answer the question why the array is not collected on the first GC.Collect() call. I think assigning arr = null may be a better fix; testing that now.

@HJLeee

Copy link
Copy Markdown
ContributorAuthor

Please close this if arr = null is successful. :)

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Test assumes GC.Collect() successfully collects allocated Normal and Critical objects.

Finalized 0 Normal and 0 Critical objects.
The first Critical object was finalized after 0 Normal objects.

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-76007-merge-ac12cc893b1f4aa0bc/baseservices.finalization/1/console.34afcb43.log?helixlogtype=result

Author:HJLeee
Assignees:-
Labels:

area-GC-coreclr, community-contribution

Milestone:-

@AntonLapounov

Copy link
Copy Markdown
Contributor

Investigating the root issue here: #76041 (comment).

@ghostghost locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HJLeee@AntonLapounov@danmoseley