') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/7.0] [mono][debugger] fix exception while decoding value that has a byref field by github-actions[bot] · Pull Request #76086 · dotnet/runtime · GitHub
Skip to content

[release/7.0] [mono][debugger] fix exception while decoding value that has a byref field - #76086

Merged
carlossanlop merged 2 commits into
release/7.0from
backport/pr-75774-to-release/7.0
Sep 26, 2022
Merged

[release/7.0] [mono][debugger] fix exception while decoding value that has a byref field#76086
carlossanlop merged 2 commits into
release/7.0from
backport/pr-75774-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 23, 2022•
edited by thaystg
Loading

Copy link
Copy Markdown
Contributor

Backport of #75774 to release/7.0

/cc @thaystg

Customer Impact

While inspecting a NULL variable of type System.ReadOnlySpan on wasm the user wasn't able to see the variable value. On mobile the user would see a crash on runtime.

Testing

Manually tested on desktop and mobile, and unit test created for wasm.

Risk

Low risk, only changing the behavior for NULL values on wasm, and allocating an extra pointer when it's decoding a ref value.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost

ghost commented Sep 23, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75774 to release/7.0

/cc @thaystg

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@lewing

lewing commented Sep 23, 2022

Copy link
Copy Markdown
Member

@rokonec mutex timeout here

@carlossanlop

carlossanlop commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

@thaystg please fill out the template, add the servicing-consider label, and send the email to Tactics with an approval request.

@thaystgthaystg added the Servicing-consider Issue for next servicing release review label Sep 23, 2022
@lewinglewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 23, 2022
@lewing

lewing commented Sep 23, 2022

Copy link
Copy Markdown
Member

approved in email

@carlossanlop

carlossanlop commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

JIT failures are #75391

Approved, signed off, ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit a3b37f1 into release/7.0Sep 26, 2022
@carlossanlop
carlossanlop deleted the backport/pr-75774-to-release/7.0 branch September 26, 2022 17:56
@ghostghost locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@radicalradicalAwaiting requested review from radicalradical is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner

Assignees

@thaystgthaystg

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lewing@carlossanlop@thaystg