Uh oh!
There was an error while loading. Please reload this page.
Process primitives in local morph - #76155
Merged
Merged
Conversation
ghost
commented
Sep 25, 2022
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsOne more step towards Some small improvements and some smaller regressions from copy propagation.
|
SingleAccretionforce-pushed
the
LclMorph-Primitives
branch
2 times, most recently
from
September 26, 2022 12:32
638353d to
e9b0deeCompareOnly for RETURN users for now.
We should really delete TYP_BOOL.
The code isn't actually set up for this. No diffs.
SingleAccretionforce-pushed
the
LclMorph-Primitives
branch
from
September 26, 2022 17:36
031a398 to
d2580c8CompareSingleAccretionforce-pushed
the
LclMorph-Primitives
branch
from
September 26, 2022 19:46
d2580c8 to
007f156Compare
Closed
SingleAccretion
marked this pull request as ready for review
September 30, 2022 17:47
SingleAccretion
commented
Sep 30, 2022
ContributorAuthor
@dotnet/jit-contrib |
AndyAyersMS
approved these changes
Oct 2, 2022
| } | ||
| // See if the variable is equal to another variable or a constant. | ||
| // See if the variable is equal to another variable. |
Member
There was a problem hiding this comment.
Strange, I thought I had already removed this.
Also fgMorphTree already iterates, assuming there are opportunities to chain assertions.
AndyAyersMS
commented
Oct 2, 2022
Member
Thank you for your continued work on the jit. |
jkotas added a commit
to jkotas/runtime
that referenced
this pull request
Oct 5, 2022
This reverts commit ca6fb31.
This was referenced Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more step towards
ADDRdeletion.Some small improvements and some smaller regressions from copy propagation. The regression in the tests collection is large because it is duplicated across many (generated) HWI tests.