Skip to content

[LoongArch64] Fix the assert error for genSetRegToIcon() - #76164

Merged
kunalspathak merged 2 commits into
dotnet:mainfrom
shushanhf:LA_regConst
Sep 27, 2022
Merged

[LoongArch64] Fix the assert error for genSetRegToIcon()#76164
kunalspathak merged 2 commits into
dotnet:mainfrom
shushanhf:LA_regConst

Conversation

@shushanhf

@shushanhfshushanhf commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Fix the assert error for genSetRegToIcon() called by genSetRegToIcon().

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Sep 26, 2022
@ghost

ghost commented Sep 26, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

Fix the assert error for genSetRegToIcon() called by genSetRegToIcon().

Author:shushanhf
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@shushanhf

shushanhf commented Sep 26, 2022

Copy link
Copy Markdown
ContributorAuthor

Hi, @jakobbotsch
Could you review this PR ?
thanks

@JulieLeeMSFT

JulieLeeMSFT commented Sep 26, 2022

Copy link
Copy Markdown
Member

cc @kunalspathak.

@JulieLeeMSFTJulieLeeMSFT added this to the 8.0.0 milestone Sep 26, 2022
kunalspathak
kunalspathak reviewed Sep 26, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/codegenloongarch64.cpp
kunalspathak
kunalspathak approved these changes Sep 27, 2022
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak
kunalspathak merged commit 1f688ed into dotnet:mainSep 27, 2022
@shushanhf
shushanhf deleted the LA_regConst branch September 28, 2022 00:48
@ghostghost locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-loongarch64area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@shushanhf@JulieLeeMSFT@kunalspathak@teo-tsirpanis