Skip to content

[wasm] Templates nits - #76182

Merged
maraf merged 6 commits into
dotnet:mainfrom
maraf:WasmTemplatesNits
Sep 29, 2022
Merged

[wasm] Templates nits#76182
maraf merged 6 commits into
dotnet:mainfrom
maraf:WasmTemplatesNits

Conversation

@maraf

@marafmaraf commented Sep 26, 2022

Copy link
Copy Markdown
Member
  • Add template descriptions.
  • Unify string quotes.

Closes#75771#75741

@marafmaraf added arch-wasm WebAssembly architecture area-Build-mono labels Sep 26, 2022
@marafmaraf added this to the 8.0.0 milestone Sep 26, 2022
@marafmaraf self-assigned this Sep 26, 2022
@ghost

ghost commented Sep 26, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add template descriptions.
  • Unify string quotes.

Closes #75771#75741

Author:maraf
Assignees:maraf
Labels:

arch-wasm, area-Build-mono

Milestone:8.0.0

@lewing
lewing requested a review from radicalSeptember 26, 2022 16:02
@radical

radical commented Sep 26, 2022

Copy link
Copy Markdown
Member

WBT test failures

radical
radical reviewed Sep 26, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/console/main.mjs Outdated
@maraf
maraf marked this pull request as ready for review September 27, 2022 08:24
maraf
maraf commented Sep 27, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/browser/main.js Outdated
pavelsavara
pavelsavara reviewed Sep 27, 2022
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/WasmTemplateTests.cs Outdated
pavelsavara
pavelsavara reviewed Sep 27, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/browser/main.js Outdated
radical
radical reviewed Sep 27, 2022
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/WasmTemplateTests.cs
@maraf
maraf merged commit da9b348 into dotnet:mainSep 29, 2022
@maraf
maraf deleted the WasmTemplatesNits branch September 29, 2022 07:42
@radical

radical commented Sep 29, 2022

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

github-actionsBot commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3150984190

@github-actionsgithub-actionsBot mentioned this pull request Sep 29, 2022
Merged
@pavelsavarapavelsavara mentioned this pull request Sep 30, 2022
Open
3 tasks
@ghostghost locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner

Assignees

@marafmaraf

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Update experimental WebAssembly templates to use consistent string quotes in JS

3 participants

@maraf@radical@pavelsavara