Uh oh!
There was an error while loading. Please reload this page.
Revert "Allocate RuntimeType objects on Frozen Object Heap - #76235
Merged
Conversation
ghost
commented
Sep 27, 2022
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jkotas
commented
Sep 27, 2022
MemberAuthor
@EgorBo I am sorry this needs to be reverted until the crash is understood and fixed to unblock the codeflow. |
EgorBo
approved these changes
Sep 27, 2022
dakersnar
commented
Oct 4, 2022
Contributor
These reverts have taken away some recent improvements: dotnet/perf-autofiling-issues#8818 |
EgorBo added a commit
to EgorBo/runtime-1
that referenced
this pull request
Oct 5, 2022
…otnet#76235)" This reverts commit 91706f1.
EgorBo added a commit
that referenced
this pull request
Oct 6, 2022
…en objects" (#76649) This PR reverts #76235 with a few manual modifications: The main issue why the initial PRs (#75573 and #76135) were reverted has just been resolved via #76251: GC could collect some associated (with frozen objects) objects as unreachable, e.g. it could collect a SyncBlock, WeakReferences and Dependent handles associated with frozen objects which could (e.g. for a short period of time) be indeed unreachable but return back to life after. Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #76219