[release/7.0] WasmAppHost: Fix crash when starting wasmbrowser project

[radical]

/cc @lewing@thaystg@pavelsavara

Customer impact

On 7.0, we created a new template to create a wasm browser app without using blazor, but running it would crash because we try to read the web server addresses right after await host.StartAsync, but they might not be available at that time. Instead, we now read the addresses in response to the ApplicationStarted event.

This could fail like:

WasmAppHost --runtime-config /tmp/cc/bin/Debug/net7.0/browser-wasm/AppBundle/cc.runtimeconfig.json --forward-console
Unhandled exception. System.InvalidOperationException: Failed to determine web server's IP address or port
at Microsoft.WebAssembly.AppHost.WebServer.StartAsync(WebServerOptions options, ILogger logger, CancellationToken token)
at Microsoft.WebAssembly.AppHost.BrowserHost.StartWebServerAsync(String appPath, Boolean forwardConsole, String[] urls, CancellationToken token)
at Microsoft.WebAssembly.AppHost.BrowserHost.RunAsync(ILoggerFactory loggerFactory, CancellationToken token)
at Microsoft.WebAssembly.AppHost.BrowserHost.InvokeAsync(CommonConfiguration commonArgs, ILoggerFactory loggerFactory, ILogger logger, CancellationToken token)
at Microsoft.WebAssembly.AppHost.WasmAppHost.Main(String[] args)
at Microsoft.WebAssembly.AppHost.WasmAppHost.<Main>(String[] args)

Testing

Unit tests with workloads, and manual testing.

Risk

Low risk, prevents a crash.

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This could fail like:

WasmAppHost --runtime-config /tmp/cc/bin/Debug/net7.0/browser-wasm/AppBundle/cc.runtimeconfig.json --forward-console
Unhandled exception. System.InvalidOperationException: Failed to determine web server's IP address or port
at Microsoft.WebAssembly.AppHost.WebServer.StartAsync(WebServerOptions options, ILogger logger, CancellationToken token)
at Microsoft.WebAssembly.AppHost.BrowserHost.StartWebServerAsync(String appPath, Boolean forwardConsole, String[] urls, CancellationToken token)
at Microsoft.WebAssembly.AppHost.BrowserHost.RunAsync(ILoggerFactory loggerFactory, CancellationToken token)
at Microsoft.WebAssembly.AppHost.BrowserHost.InvokeAsync(CommonConfiguration commonArgs, ILoggerFactory loggerFactory, ILogger logger, CancellationToken token)
at Microsoft.WebAssembly.AppHost.WasmAppHost.Main(String[] args)
at Microsoft.WebAssembly.AppHost.WasmAppHost.<Main>(String[] args)

Instead read the addresses on application lifetime's ApplicationStarted event.

Author:	radical
Assignees:	-
Labels:	arch-wasm, area-VM-meta-mono
Milestone:	-

[pavelsavara]

Also could we remove --forward-console option from the host ?
It's not doing anything right now. There is internal withConsoleForwarding() we use for WBT.

[pavelsavara]

Also we had the issue with "unsafe ports" (as considered by browsers) on helix . Should we try to avoid those port numbers here too ?

[carlossanlop]

@radical is this a product code change? If yes, can you please fill out the template in the description, add the servicing-consider label and then send an email to Tactics to request approval?

[radical]

@carlossanlop approved over email

[radical]

The wasm/aot failure is #76110 .
And the other one is an unrelated timeout.

[carlossanlop]

@radical some pending things:

• Do you plan on addressing @pavelsavara 's suggestions in this PR?
• Can you please resolve the merge conflicts?
• Can you please get a code review sign-off when ready?

[radical]

@radical some pending things:

• Do you plan on addressing @pavelsavara 's suggestions in this PR?

Not in this PR.

• Can you please resolve the merge conflicts?

Done

• Can you please get a code review sign-off when ready?

cc @lewing@thaystg

[radical]

@pavelsavara about the unsafe ports, is there a list of the ports that chrome would reject? And I guess, other browsers.

[pavelsavara]

@pavelsavara about the unsafe ports, is there a list of the ports that chrome would reject? And I guess, other browsers.

Chrome
https://chromium.googlesource.com/chromium/src.git/+/refs/heads/master/net/base/port_util.cc#27

FF
https://www-archive.mozilla.org/projects/netlib/portbanning#portlist

Safari
https://github.com/WebKit/WebKit/blob/42f5a93823a7f087a800cd65c6bc0551dbeb55d3/Source/WTF/wtf/URL.cpp#L969

[radical]

@carlossanlop this is ready to go!

[carlossanlop]

Let's do this! 💪🏼 💪🏼