Skip to content

Enable multi-reg LONG nodes on 32 bit - #76263

Merged
kunalspathak merged 1 commit into
dotnet:mainfrom
SingleAccretion:Multi-Reg-Longs-Upstream
Oct 25, 2022
Merged

Enable multi-reg LONG nodes on 32 bit#76263
kunalspathak merged 1 commit into
dotnet:mainfrom
SingleAccretion:Multi-Reg-Longs-Upstream

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Or, rather, enable promotion of multi-reg LONG variables, unblocking field enregistration.

The diffs (x86) are nice and simple:

- mov dword ptr [esp], eax- mov dword ptr [esp+04H], edx- mov eax, dword ptr [esp]- mov edx, dword ptr [esp+04H]
add eax, -1
adc edx, -1

And also numerous (-35K for the benchmarks collection on x86).

@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Sep 27, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Or, rather, enable promotion of multi-reg LONG variables, unblocking field enregistration.

The diffs are nice and simple:

- mov dword ptr [esp], eax- mov dword ptr [esp+04H], edx- mov eax, dword ptr [esp]- mov edx, dword ptr [esp+04H]
add eax, -1
adc edx, -1

And also numerous (-35K for the benchmarks collection on x86).

Author:SingleAccretion
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@SingleAccretion
SingleAccretion marked this pull request as ready for review September 27, 2022 22:08
@SingleAccretion

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

@AndyAyersMS

Copy link
Copy Markdown
Member

@TIHan perhaps you can review this one?

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit comment and a question.

Comment threadsrc/coreclr/jit/decomposelongs.cpp
Comment threadsrc/coreclr/jit/codegenlinear.cpp
@kunalspathak

Copy link
Copy Markdown
Contributor

I am not able to see arm Release failures. Tried rerunning the jobs, but they are not getting scheduled. Do you remember what the failure was?

@SingleAccretion

Copy link
Copy Markdown
ContributorAuthor

No, unfortunately... Let's rerun the whole CI to get fresher coverage.

@SingleAccretion

Copy link
Copy Markdown
ContributorAuthor

@kunalspathak
kunalspathak merged commit 041aa3b into dotnet:mainOct 25, 2022
@SingleAccretion
SingleAccretion deleted the Multi-Reg-Longs-Upstream branch October 25, 2022 16:23
@ghostghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@kunalspathak@JulieLeeMSFT