Skip to content

Add BinaryPrimitives.ReverseEndianness for spans of elements - #76339

Merged
adamsitnik merged 9 commits into
dotnet:mainfrom
stephentoub:reverseendianness
Nov 4, 2022
Merged

Add BinaryPrimitives.ReverseEndianness for spans of elements#76339
adamsitnik merged 9 commits into
dotnet:mainfrom
stephentoub:reverseendianness

Conversation

@stephentoub

@stephentoubstephentoub commented Sep 28, 2022

Copy link
Copy Markdown
Member

Fixes#75901
Contributes to #72107

@ghost

ghost commented Sep 28, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Sep 28, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #75901
Contributes to #72107

Author:stephentoub
Assignees:-
Labels:

area-System.Memory, new-api-needs-documentation

Milestone:-

gfoidl
gfoidl reviewed Sep 29, 2022
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Buffers/Binary/Reader.cs
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs Outdated
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs Outdated
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs Outdated
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs
gfoidl
gfoidl reviewed Oct 10, 2022
View reviewed changes
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs Outdated
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs Outdated
This was referenced Oct 10, 2022
Closed
Closed
Closed
@build-analysisbuild-analysisBot mentioned this pull request Oct 12, 2022
Closed
2 tasks
@stephentoub

stephentoub commented Nov 2, 2022

Copy link
Copy Markdown
MemberAuthor

Could someone help me with a review of this? @adamsitnik? @tannergooding? @GrabYourPitchforks?

This was referenced Nov 3, 2022
Open
Closed
Closed
adamsitnik
adamsitnik approved these changes Nov 3, 2022
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @stephentoub and apologies for the delay in the review!

Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs Outdated
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs
Comment thread...aries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReverseEndianness.cs
@stephentoub

stephentoub commented Nov 4, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks for the review, @adamsitnik.

@adamsitnikadamsitnik added this to the 8.0.0 milestone Nov 4, 2022
@adamsitnik
adamsitnik merged commit 7de0d40 into dotnet:mainNov 4, 2022
@stephentoub
stephentoub deleted the reverseendianness branch November 4, 2022 13:30
This was referenced Nov 9, 2022
Open
Open
@ghostghost locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes
@tannergoodingtannergoodingAwaiting requested review from tannergooding
+1 more reviewer
@gfoidlgfoidlgfoidl left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoubstephentoub

Labels

area-System.Memorynew-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: BinaryPrimitives.ReverseEndianness

4 participants

@stephentoub@gfoidl@adamsitnik@tannergooding