Disable asm checking for JITMinOpts

[BruceForstall]

Fixes#76344

Extension of #76276

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #76344

Extension of #76276

Author:	BruceForstall
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[BruceForstall]

/azp run runtime-coreclr jitstress

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[TIHan]

Thank you @BruceForstall for this. I remember seeing this same check from "JitOptimizationSensitive". However, some of the FileCheck (csproj) tests themselves forcefully set TieredCompilation=0 and JitMinOpts=0 - which means FileCheck won't run as you are checking for a zero-length JitMinOpts env var. See:

https://github.com/dotnet/runtime/blob/main/src/tests/JIT/Regression/JitBlue/Runtime_33972/Runtime_33972.csproj#L12
https://github.com/dotnet/runtime/blob/main/src/tests/JIT/Regression/JitBlue/Runtime_34937/Runtime_34937.csproj#L12

[TIHan]

Isn't this already fixed by #76276 ? The link to the issue you mentioned is against a commit from yesterday, I just merged #76276 today - we had problems with Linux/Mac specifically not including precommands that would force set JitMinOpts to be zero.

may already be fixed

[BruceForstall]

Isn't this already fixed by #76276 ? The link to the issue you mentioned is against a commit from yesterday, I just merged #76276 today - we had problems with Linux/Mac specifically not including precommands that would force set JitMinOpts to be zero.

It appears to be, since the overnight jitstress job didn't have these failures:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=34429&view=ms.vss-test-web.build-test-results-tab

However, doesn't that just assume that any FileCheck test is required to force TieredCompilation=0 / JITMinOpts=0 and have the block:

runtime/src/tests/JIT/Regression/JitBlue/Runtime_33972/Runtime_33972.csproj

Lines 9 to 18 in 6098669

	<CLRTestBatchPreCommands><![CDATA[
	$(CLRTestBatchPreCommands)
	set COMPlus_TieredCompilation=0
	set COMPlus_JITMinOpts=0
	]]></CLRTestBatchPreCommands>
	<BashCLRTestPreCommands><![CDATA[
	$(BashCLRTestPreCommands)
	export COMPlus_TieredCompilation=0
	export COMPlus_JITMinOpts=0
	]]></BashCLRTestPreCommands>

?

Shouldn't we allow the test to run in any configuration, but only disable the FileCheck part of the testing in non-default conditions, like TieredCompilation != 0, or JITMinOpts != 0?