Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] [mono][arm] Fix rethrow instruction size - #76393
Merged
Conversation
It is the same as throw
github-actionsBot
requested review from
SamMonoRT, lambdageek and vargaz
as code ownersSeptember 29, 2022 16:55
vargaz
approved these changes
Sep 29, 2022
carlossanlop
commented
Sep 29, 2022
Contributor
@BrzVlad or @lambdageek: when this is ready, can you please fill out the template, add the |
SamMonoRT
commented
Sep 30, 2022
Member
Tactics approved via email |
carlossanlop
commented
Sep 30, 2022
Contributor
Approved, signed off, CI green. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #76387 to release/7.0
/cc @lambdageek@BrzVlad
Customer Impact
Inability to use maui on certain android arm devices.
Testing
The fix was tested on customer device to verify that the previously crashing sample application runs correctly. Since the fix involves common arm codegen, it is tested as part of CI lanes.
Risk
Very low risk. This change just slightly increases the memory reserved for an instruction so we don't overflow during codegen. No impact whatsoever to the generated code.