Uh oh!
There was an error while loading. Please reload this page.
[mono][sgen] Update memory load information after world is resumed - #76400
Conversation
Following recent cgroup support, mono_determine_physical_ram_size is no longer safe to call during GC.
ghost
commented
Sep 29, 2022
Tagging subscribers to this area: @BrzVlad Issue DetailsFollowing recent cgroup support (#74237), mono_determine_physical_ram_size is no longer safe to call during GC.
|
BrzVlad
commented
Sep 29, 2022
@nealef@akoeplinger Any idea if this impacts android ? |
naricc
commented
Sep 30, 2022
What part of #74237 makes it unsafe to call |
nealef
commented
Sep 30, 2022
The new code explicitly excludes Android. That is, it uses the previous code path. |
BrzVlad
commented
Sep 30, 2022
@naricc |
akoeplinger
commented
Sep 30, 2022
I didn't realize we query the ram size on each GC stw cycle, do we know if the cgroup additions have any perf impact? We'll also need to backport this to 7.0 since we backported the cgroup change. |
I have not seen any perf regressions that I could attribute to this, although the microbenchmarks are so micro I am not sure how many of them exercise the GC much. There was also some missing data on some platforms around the time this was merged. |
akoeplinger
commented
Oct 3, 2022
Failures are unrelated. |
akoeplinger
commented
Oct 3, 2022
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3174227750 |
Following recent cgroup support (#74237), mono_determine_physical_ram_size is no longer safe to call during GC.