Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Disable gen 1 budget accounting fix for segments - #76412
Conversation
…lementation of GC behaves like .NET 6.0 did.
ghost
commented
Sep 29, 2022
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #76365 to release/7.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approve. please get a code review and we can take for consideration in 7 ga.
carlossanlop
commented
Sep 30, 2022
Approved by Tactics via email. Signed off. CI is green. This is fully baked and ready to merge. |
jeffschwMSFT
commented
Sep 30, 2022
@carlossanlop the 'no-merge' as on this one as we were still discussing. @Maoni0 with your signoff is it all good? |
Maoni0
commented
Sep 30, 2022
all good, thanks! |
Backport of #76365 to release/7.0
/cc @Maoni0@PeterSolMS
Customer Impact
Given that we expect some customers will see working set or performance regressions with regions, we want to make sure that clrgc.dll using segments performs just like .NET 6.0 did. So this change disables a gen 1 budget tuning change we did in the 7.0 time frame.
Testing
Ran GCPerfSim scenarios on both WKS and SVR, for both regions and segments.
Risk
Risk should be small because we are undoing a change introduced in 7.0. There is no change for regions, only for segments. Also change is minimal and straightforward.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.