Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Enable logging managed stack trace for AV to event log - #76428
Merged
Conversation
.NET Framework was logging managed stack trace of access violations that happened in external native code in the event log. .NET core only logs the address and error code of the exception, which makes it difficult for developers to figure out which part of their managed code has called the failing native code. The reason why .NET core doesn't print the stack trace is that the access violation is now handled as fail fast instead of regular unhandled exception. And while we report managed stack traces in the EEPolicy::FatalError for fail fasts called from our runtime and managed code in both runtime and user code, we don't report it when we come to that method due to the access violation. This change enables printing the stack trace for that case too.
jkotas
approved these changes
Sep 30, 2022
jeffschwMSFT
approved these changes
Sep 30, 2022
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. this is good for overall diagnostics. we will take for consideration in 7 ga.
carlossanlop
commented
Sep 30, 2022
Contributor
Approved, signed off, CI is green. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #75721 to release/7.0
/cc @janvorli
Customer Impact
.NET Framework was logging managed stack trace of access violations that happened in external native code in the event log. .NET core only logs the address and error code of the exception, which makes it difficult for developers to figure out which part of their managed code has called the failing native code on their customer's machines.
Testing
Local directed test, coreclr and libraries tests.
Risk
Very low, the change affects only the final part of fatal error process exit where we are enabling logging of the stack trace for one more case.