Skip to content

SPMI: Avoid division by zero - #76544

Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom
jakobbotsch:fix-76542
Oct 3, 2022
Merged

SPMI: Avoid division by zero#76544
jakobbotsch merged 1 commit into
dotnet:mainfrom
jakobbotsch:fix-76542

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

With the MinOpts/FullOpts split it is common/expected to see some of these being completely empty, and we hit DivisionByZero in those cases.

Fix#76542

With the MinOpts/FullOpts split it is common/expected to see some of
these being completely empty, and we hit DivisionByZero in those cases.
Fixdotnet#76542
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 3, 2022
@ghostghost assigned jakobbotschOct 3, 2022
@ghost

ghost commented Oct 3, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

With the MinOpts/FullOpts split it is common/expected to see some of these being completely empty, and we hit DivisionByZero in those cases.

Fix #76542

Author:jakobbotsch
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@jakobbotsch

jakobbotsch commented Oct 3, 2022

Copy link
Copy Markdown
MemberAuthor

Quoting from #76542 (comment):

Current libraries.crossgen2 collection has 0 minopts contexts which is why we hit the problem. I'm not sure why there were any minopts contexts before, seems odd.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

cc @dotnet/jit-contrib PTAL @BruceForstall

@jakobbotsch
jakobbotsch merged commit 32e856a into dotnet:mainOct 3, 2022
@jakobbotsch
jakobbotsch deleted the fix-76542 branch October 3, 2022 19:23
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

superpmi-diffs failures/timeouts

2 participants

@jakobbotsch@BruceForstall