Skip to content

Rename request count to permit count on System.Threading.RateLimiting - #76558

Merged
BrennanConroy merged 1 commit into
dotnet:mainfrom
AliKhalili:issue-76557-ratelimit-improve-naming
Oct 5, 2022
Merged

Rename request count to permit count on System.Threading.RateLimiting#76558
BrennanConroy merged 1 commit into
dotnet:mainfrom
AliKhalili:issue-76557-ratelimit-improve-naming

Conversation

@AliKhalili

@AliKhaliliAliKhalili commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Proposed fix for #76557

@ghost

ghost commented Oct 3, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Oct 3, 2022
@ghost

ghost commented Oct 3, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Proposed fix for #76557

Author:AliKhalili
Assignees:-
Labels:

area-System.Threading, new-api-needs-documentation

Milestone:-

@dnfadmin

dnfadmin commented Oct 3, 2022•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@BrennanConroy

BrennanConroy commented Oct 4, 2022

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

github-actionsBot commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3184104726

@github-actionsgithub-actionsBot mentioned this pull request Oct 4, 2022
Merged
@BrennanConroy

BrennanConroy commented Oct 5, 2022

Copy link
Copy Markdown
Member

Thanks for catching this! Also updated 7.0 before we locked down RTM 😃

@BrennanConroy
BrennanConroy merged commit 3e347d7 into dotnet:mainOct 5, 2022
@BrennanConroyBrennanConroy mentioned this pull request Oct 5, 2022
Closed
@AliKhalili
AliKhalili deleted the issue-76557-ratelimit-improve-naming branch October 5, 2022 18:55
@ghostghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrennanConroyBrennanConroyBrennanConroy approved these changes

Assignees

No one assigned

Labels

area-System.Threadingcommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AliKhalili@dnfadmin@BrennanConroy