Skip to content

[release/7.0][Android] Backport fix NetworkInterface.GetAllNetworkInterfaces - #76565

Merged
carlossanlop merged 2 commits into
dotnet:release/7.0from
simonrozsival:backport-android-fix-get-all-network-interfaces
Oct 5, 2022
Merged

[release/7.0][Android] Backport fix NetworkInterface.GetAllNetworkInterfaces#76565
carlossanlop merged 2 commits into
dotnet:release/7.0from
simonrozsival:backport-android-fix-get-all-network-interfaces

Conversation

@simonrozsival

@simonrozsivalsimonrozsival commented Oct 3, 2022•
edited by karelz
Loading

Copy link
Copy Markdown
Member

Backport of #76370 and #76541 to release/7.0

Fixes#75809
Fixes#76493
Fixesdotnet/android#6973

/cc @steveisok@akoeplinger

Customer impact

Several customers reported problems with the current implementation in #75809 and #76493

Testing

  • unit tests in CI
  • locally on physical device (Android API 31) and Android emulator (API level 21)

Risk

Low. The change is inspired by an existing implementation in Xamarin.Android.

simonrozsivaland others added 2 commits October 3, 2022 21:55
@simonrozsival@akoeplinger
[Android] Fix NetworkInterface.GetAllNetworkInterfaces (dotnet#76370)
4d1081a
* Revert "[Android] Port getifaddrs implementation from Xamarin.Android (dotnet#71943)"
This reverts commit 1de4a5c.
* Fix allocating memory block for interfaces and addresses on recent Android SDKs
* Detect loopback interface on Android
* Add comment with explanation
* Simplify the changes to be closer to the original code
* Fix build
* Fix typos
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Improve comment
* Indent using spaces instead of tabs
* Remove check for ifaddrs.h
* Add ANDROID_GETIFADDRS_WORKAROUND
* Update comment
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@simonrozsival
[Android] Fix NetworkInterface.GetAllNetworkInterfaces on API 21-23 (d…
47494a6
…otnet#76541)
* Bring back pal_ifaddrs
* Update the header file
@simonrozsivalsimonrozsival added Servicing-consider Issue for next servicing release review os-android labels Oct 3, 2022
@simonrozsivalsimonrozsival added this to the 7.0.0 milestone Oct 3, 2022
@ghost

ghost commented Oct 3, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #76370 and #76541 to release/7.0

/cc @steveisok@akoeplinger

Customer impact

Several customers reported problems with the current implementation in #75809 and #76493

Testing

  • unit tests in CI
  • locally on physical device (Android API 31) and Android emulator (API level 21)

Risk

Low. The change is inspired by an existing implementation in Xamarin.Android.

Author:simonrozsival
Assignees:-
Labels:

Servicing-consider, os-android

Milestone:7.0.0

@ghostghost added the area-System.Net label Oct 3, 2022
@ghost

ghost commented Oct 3, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #76370 and #76541 to release/7.0

/cc @steveisok@akoeplinger

Customer impact

Several customers reported problems with the current implementation in #75809 and #76493

Testing

  • unit tests in CI
  • locally on physical device (Android API 31) and Android emulator (API level 21)

Risk

Low. The change is inspired by an existing implementation in Xamarin.Android.

Author:simonrozsival
Assignees:simonrozsival
Labels:

Servicing-consider, area-System.Net, os-android

Milestone:7.0.0

@simonrozsival

simonrozsival commented Oct 3, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Oct 3, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop

carlossanlop commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

@simonrozsival if you haven't done so, please send an email to Tactics requesting approval.
@akoeplinger and/or @steveisok, please provide a code review sign-off.

@steveisoksteveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 3, 2022
steveisok
steveisok approved these changes Oct 3, 2022
View reviewed changes

@steveisoksteveisok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by tactics over email

@simonrozsival

simonrozsival commented Oct 4, 2022

Copy link
Copy Markdown
MemberAuthor

The failing tests are unrelated to this change

This was referenced Oct 5, 2022
Closed
Closed
Closed
Closed
Closed
@carlossanlop

carlossanlop commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Alright. I went through all the failures, and I am linking them here:

This has been signed off and approved by Tactics. Ready to merge.

@carlossanlop
carlossanlop merged commit 450b8f4 into dotnet:release/7.0Oct 5, 2022
@simonrozsivalsimonrozsival mentioned this pull request Oct 20, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Netos-androidServicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@simonrozsival@carlossanlop@steveisok