Skip to content

AOT Runtime.Base: Change AttributeTargets and AttributeUsageAttribute to public - #76573

Merged
jkotas merged 2 commits into
dotnet:mainfrom
cston:nativeaot-attribute-types
Oct 4, 2022
Merged

AOT Runtime.Base: Change AttributeTargets and AttributeUsageAttribute to public#76573
jkotas merged 2 commits into
dotnet:mainfrom
cston:nativeaot-attribute-types

Conversation

@cston

@cstoncston commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

AttributeTargets and AttributeUsageAttribute must be public to allow the C# compiler to emit [module: RefSafetyRules] successfully.

See #76459 (comment).

@ghostghost assigned cstonOct 3, 2022
@cston
cston marked this pull request as ready for review October 3, 2022 23:26
@cston

cston commented Oct 3, 2022

Copy link
Copy Markdown
ContributorAuthor

cc @jaredpar, @stephentoub

@jkotas

Copy link
Copy Markdown
Member

Tools unit tests passed.

@jkotas
jkotas merged commit ad7f31d into dotnet:mainOct 4, 2022
@cston
cston deleted the nativeaot-attribute-types branch October 4, 2022 03:58

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cston@jkotas@jaredpar@stephentoub