Skip to content

CI: Run runtime-extra-platforms with batched builds for release - #76587

Merged
radical merged 1 commit into
dotnet:mainfrom
radical:ci-fixes
Oct 4, 2022
Merged

CI: Run runtime-extra-platforms with batched builds for release#76587
radical merged 1 commit into
dotnet:mainfrom
radical:ci-fixes

Conversation

@radical

Copy link
Copy Markdown
Member

.. branches.

Currently, for release/* branches, the pipeline is run twice a day, if there are any changes since the last successful run. In contrast, the runtime pipeline only runs batched builds for the release branches.

This can get into a situation like:

  1. commit ABC pushed to the release branch
  2. runtime builds for ABC -- batched build
  3. runtime-extra-platforms builds on a schedule, but this pipeline is unstable, and fails.
  4. runtime-extra-platforms now runs twice a day, till we have a new commit, because the pipeline is never green

Instead, this changes the behavior to match runtime pipeline, and only run batched builds.

.. branches.
Currently, for `release/*` branches, the pipeline is run twice a day, if
there are any changes since the last *successful* run. In contrast, the
`runtime` pipeline only runs batched builds for the release branches.
This can get into a situation like:
1. commit ABC pushed to the release branch
2. `runtime` builds for ABC -- batched build
3. `runtime-extra-platforms` builds on a schedule, but this pipeline is
unstable, and fails.
4. `runtime-extra-platforms` now runs twice a day, till we have a new
commit, because the pipeline is never green
Instead, this changes the behavior to match `runtime` pipeline, and only
run batched builds.
@ghost

ghost commented Oct 4, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. branches.

Currently, for release/* branches, the pipeline is run twice a day, if there are any changes since the last successful run. In contrast, the runtime pipeline only runs batched builds for the release branches.

This can get into a situation like:

  1. commit ABC pushed to the release branch
  2. runtime builds for ABC -- batched build
  3. runtime-extra-platforms builds on a schedule, but this pipeline is unstable, and fails.
  4. runtime-extra-platforms now runs twice a day, till we have a new commit, because the pipeline is never green

Instead, this changes the behavior to match runtime pipeline, and only run batched builds.

Author:radical
Assignees:-
Labels:

arch-wasm, area-Infrastructure

Milestone:-

@ghostghost assigned radicalOct 4, 2022
@ghost

ghost commented Oct 4, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

.. branches.

Currently, for release/* branches, the pipeline is run twice a day, if there are any changes since the last successful run. In contrast, the runtime pipeline only runs batched builds for the release branches.

This can get into a situation like:

  1. commit ABC pushed to the release branch
  2. runtime builds for ABC -- batched build
  3. runtime-extra-platforms builds on a schedule, but this pipeline is unstable, and fails.
  4. runtime-extra-platforms now runs twice a day, till we have a new commit, because the pipeline is never green

Instead, this changes the behavior to match runtime pipeline, and only run batched builds.

Author:radical
Assignees:-
Labels:

arch-wasm, area-Infrastructure

Milestone:-

@radical

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical
radical merged commit 04f67a5 into dotnet:mainOct 4, 2022
@radical
radical deleted the ci-fixes branch October 4, 2022 15:33
@radical

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3183480938

@github-actions

Copy link
Copy Markdown
Contributor

@radical backporting to release/7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: CI: Run `runtime-extra-platforms` with batched builds for release
Using index info to reconstruct a base tree...
M	eng/pipelines/runtime-extra-platforms.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/runtime-extra-platforms.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime-extra-platforms.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 CI: Run `runtime-extra-platforms` with batched builds for release
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

radical added a commit to radical/runtime that referenced this pull request Oct 4, 2022
…tnet#76587)
.. branches.
Currently, for `release/*` branches, the pipeline is run twice a day, if
there are any changes since the last *successful* run. In contrast, the
`runtime` pipeline only runs batched builds for the release branches.
This can get into a situation like:
1. commit ABC pushed to the release branch
2. `runtime` builds for ABC -- batched build
3. `runtime-extra-platforms` builds on a schedule, but this pipeline is
unstable, and fails.
4. `runtime-extra-platforms` now runs twice a day, till we have a new
commit, because the pipeline is never green
Instead, this changes the behavior to match `runtime` pipeline, and only
run batched builds.
carlossanlop pushed a commit that referenced this pull request Oct 4, 2022
…6587) (#76615)
.. branches.
Currently, for `release/*` branches, the pipeline is run twice a day, if
there are any changes since the last *successful* run. In contrast, the
`runtime` pipeline only runs batched builds for the release branches.
This can get into a situation like:
1. commit ABC pushed to the release branch
2. `runtime` builds for ABC -- batched build
3. `runtime-extra-platforms` builds on a schedule, but this pipeline is
unstable, and fails.
4. `runtime-extra-platforms` now runs twice a day, till we have a new
commit, because the pipeline is never green
Instead, this changes the behavior to match `runtime` pipeline, and only
run batched builds.
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@radical@akoeplinger