Skip to content

Ensure we cleanup the marshalling for elements of collections (stateful and stateless) - #76629

Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom
jkoritzinsky:element-free-fix
Oct 5, 2022
Merged

Ensure we cleanup the marshalling for elements of collections (stateful and stateless)#76629
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom
jkoritzinsky:element-free-fix

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Oct 4, 2022

Copy link
Copy Markdown
Member

We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.

Verified manually that we emit the right code for the case in #76584

Fixes#76584

Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.

@jkoritzinskyjkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Oct 4, 2022
@ghost

ghost commented Oct 4, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.

Verified manually that we emit the right code for the case in #76584

Fixes #76584

Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.

Author:jkoritzinsky
Assignees:-
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone:-

@elinor-fung

elinor-fung commented Oct 4, 2022

Copy link
Copy Markdown
Member

What do you think about adding tests that just validate the Free of a marshaller implementation gets called? Similar to ones we have for OnInvoked and the guaranteed unmarshalling methods.

@jkoritzinsky

jkoritzinsky commented Oct 4, 2022

Copy link
Copy Markdown
MemberAuthor

I'll try to come up with a test.

@AaronRobinsonMSFT

AaronRobinsonMSFT commented Oct 4, 2022

Copy link
Copy Markdown
Member

Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.

Yes, it is.

@runfoapprunfoappBot mentioned this pull request Oct 5, 2022
Closed
@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit 3a578af into dotnet:mainOct 5, 2022
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Oct 5, 2022

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

github-actionsBot commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3193476808

@github-actionsgithub-actionsBot mentioned this pull request Oct 5, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Nov 5, 2022
@jkoritzinsky
jkoritzinsky deleted the element-free-fix branch March 22, 2024 01:25
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@jkotasjkotasAwaiting requested review from jkotas

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MARSHALLED_UNICODE_STRING[] array marshalling leaks memory

3 participants

@jkoritzinsky@elinor-fung@AaronRobinsonMSFT
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) by jkoritzinsky · Pull Request #76629 · dotnet/runtime · GitHub
Skip to content
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) - #76629
Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Oct 5, 2022
Merged
Ensure we cleanup the marshalling for elements of collections (stateful and stateless)#76629
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes#76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
@jkoritzinskyjkoritzinsky
added

area-System.Runtime.InteropServices

source-generator
Indicates an issue with a source generator feature
labels
Oct 4, 2022
@ghost
ghost
commented
Oct 4, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib

See info in area-owners.md if you want to be subscribed.
Issue Details
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes #76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Author:jkoritzinsky
Assignees:-
Labels:
area-System.Runtime.InteropServices, source-generator
Milestone:-
@elinor-fung
elinor-fung
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
What do you think about adding tests that just validate the Free of a marshaller implementation gets called? Similar to ones we have for OnInvoked and the guaranteed unmarshalling methods.
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
I'll try to come up with a test.
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Yes, it is.
@runfoapprunfoappBot
mentioned this pull request
Oct 5, 2022

Closed

@AaronRobinsonMSFT
AaronRobinsonMSFT
merged commit 3a578af
into
dotnet:mainOct 5, 2022
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 5, 2022

Copy link


Copy Markdown

Member
/backport to release/7.0
@github-actions
github-actionsBot
commented
Oct 5, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3193476808
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 5, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2022
@jkoritzinsky
jkoritzinsky
deleted the

element-free-fix

branch
March 22, 2024 01:25
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@jkotasjkotasAwaiting requested review from jkotas

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

MARSHALLED_UNICODE_STRING[] array marshalling leaks memory


3 participants

@jkoritzinsky@elinor-fung@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) by jkoritzinsky · Pull Request #76629 · dotnet/runtime · GitHub
Skip to content
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) - #76629
Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Oct 5, 2022
Merged
Ensure we cleanup the marshalling for elements of collections (stateful and stateless)#76629
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes#76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
@jkoritzinskyjkoritzinsky
added

area-System.Runtime.InteropServices

source-generator
Indicates an issue with a source generator feature
labels
Oct 4, 2022
@ghost
ghost
commented
Oct 4, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib

See info in area-owners.md if you want to be subscribed.
Issue Details
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes #76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Author:jkoritzinsky
Assignees:-
Labels:
area-System.Runtime.InteropServices, source-generator
Milestone:-
@elinor-fung
elinor-fung
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
What do you think about adding tests that just validate the Free of a marshaller implementation gets called? Similar to ones we have for OnInvoked and the guaranteed unmarshalling methods.
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
I'll try to come up with a test.
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Yes, it is.
@runfoapprunfoappBot
mentioned this pull request
Oct 5, 2022

Closed

@AaronRobinsonMSFT
AaronRobinsonMSFT
merged commit 3a578af
into
dotnet:mainOct 5, 2022
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 5, 2022

Copy link


Copy Markdown

Member
/backport to release/7.0
@github-actions
github-actionsBot
commented
Oct 5, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3193476808
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 5, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2022
@jkoritzinsky
jkoritzinsky
deleted the

element-free-fix

branch
March 22, 2024 01:25
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@jkotasjkotasAwaiting requested review from jkotas

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

MARSHALLED_UNICODE_STRING[] array marshalling leaks memory


3 participants

@jkoritzinsky@elinor-fung@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) by jkoritzinsky · Pull Request #76629 · dotnet/runtime · GitHub
Skip to content
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) - #76629
Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Oct 5, 2022
Merged
Ensure we cleanup the marshalling for elements of collections (stateful and stateless)#76629
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes#76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
@jkoritzinskyjkoritzinsky
added

area-System.Runtime.InteropServices

source-generator
Indicates an issue with a source generator feature
labels
Oct 4, 2022
@ghost
ghost
commented
Oct 4, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib

See info in area-owners.md if you want to be subscribed.
Issue Details
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes #76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Author:jkoritzinsky
Assignees:-
Labels:
area-System.Runtime.InteropServices, source-generator
Milestone:-
@elinor-fung
elinor-fung
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
What do you think about adding tests that just validate the Free of a marshaller implementation gets called? Similar to ones we have for OnInvoked and the guaranteed unmarshalling methods.
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
I'll try to come up with a test.
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Yes, it is.
@runfoapprunfoappBot
mentioned this pull request
Oct 5, 2022

Closed

@AaronRobinsonMSFT
AaronRobinsonMSFT
merged commit 3a578af
into
dotnet:mainOct 5, 2022
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 5, 2022

Copy link


Copy Markdown

Member
/backport to release/7.0
@github-actions
github-actionsBot
commented
Oct 5, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3193476808
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 5, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2022
@jkoritzinsky
jkoritzinsky
deleted the

element-free-fix

branch
March 22, 2024 01:25
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@jkotasjkotasAwaiting requested review from jkotas

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

MARSHALLED_UNICODE_STRING[] array marshalling leaks memory


3 participants

@jkoritzinsky@elinor-fung@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) by jkoritzinsky · Pull Request #76629 · dotnet/runtime · GitHub
Skip to content
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) - #76629
Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Oct 5, 2022
Merged
Ensure we cleanup the marshalling for elements of collections (stateful and stateless)#76629
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes#76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
@jkoritzinskyjkoritzinsky
added

area-System.Runtime.InteropServices

source-generator
Indicates an issue with a source generator feature
labels
Oct 4, 2022
@ghost
ghost
commented
Oct 4, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib

See info in area-owners.md if you want to be subscribed.
Issue Details
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes #76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Author:jkoritzinsky
Assignees:-
Labels:
area-System.Runtime.InteropServices, source-generator
Milestone:-
@elinor-fung
elinor-fung
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
What do you think about adding tests that just validate the Free of a marshaller implementation gets called? Similar to ones we have for OnInvoked and the guaranteed unmarshalling methods.
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
I'll try to come up with a test.
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Yes, it is.
@runfoapprunfoappBot
mentioned this pull request
Oct 5, 2022

Closed

@AaronRobinsonMSFT
AaronRobinsonMSFT
merged commit 3a578af
into
dotnet:mainOct 5, 2022
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 5, 2022

Copy link


Copy Markdown

Member
/backport to release/7.0
@github-actions
github-actionsBot
commented
Oct 5, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3193476808
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 5, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2022
@jkoritzinsky
jkoritzinsky
deleted the

element-free-fix

branch
March 22, 2024 01:25
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@jkotasjkotasAwaiting requested review from jkotas

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

MARSHALLED_UNICODE_STRING[] array marshalling leaks memory


3 participants

@jkoritzinsky@elinor-fung@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) by jkoritzinsky · Pull Request #76629 · dotnet/runtime · GitHub
Skip to content
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) - #76629
Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Oct 5, 2022
Merged
Ensure we cleanup the marshalling for elements of collections (stateful and stateless)#76629
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes#76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
@jkoritzinskyjkoritzinsky
added

area-System.Runtime.InteropServices

source-generator
Indicates an issue with a source generator feature
labels
Oct 4, 2022
@ghost
ghost
commented
Oct 4, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib

See info in area-owners.md if you want to be subscribed.
Issue Details
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes #76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Author:jkoritzinsky
Assignees:-
Labels:
area-System.Runtime.InteropServices, source-generator
Milestone:-
@elinor-fung
elinor-fung
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
What do you think about adding tests that just validate the Free of a marshaller implementation gets called? Similar to ones we have for OnInvoked and the guaranteed unmarshalling methods.
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
I'll try to come up with a test.
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Yes, it is.
@runfoapprunfoappBot
mentioned this pull request
Oct 5, 2022

Closed

@AaronRobinsonMSFT
AaronRobinsonMSFT
merged commit 3a578af
into
dotnet:mainOct 5, 2022
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 5, 2022

Copy link


Copy Markdown

Member
/backport to release/7.0
@github-actions
github-actionsBot
commented
Oct 5, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3193476808
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 5, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2022
@jkoritzinsky
jkoritzinsky
deleted the

element-free-fix

branch
March 22, 2024 01:25
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@jkotasjkotasAwaiting requested review from jkotas

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

MARSHALLED_UNICODE_STRING[] array marshalling leaks memory


3 participants

@jkoritzinsky@elinor-fung@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) by jkoritzinsky · Pull Request #76629 · dotnet/runtime · GitHub
Skip to content
Ensure we cleanup the marshalling for elements of collections (stateful and stateless) - #76629
Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Oct 5, 2022
Merged
Ensure we cleanup the marshalling for elements of collections (stateful and stateless)#76629
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom 
jkoritzinsky:element-free-fix
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes#76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
@jkoritzinskyjkoritzinsky
added

area-System.Runtime.InteropServices

source-generator
Indicates an issue with a source generator feature
labels
Oct 4, 2022
@ghost
ghost
commented
Oct 4, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib

See info in area-owners.md if you want to be subscribed.
Issue Details
We accidentally lost the element marshalling when moving to the released marshaller design. This PR adds it back with matching logic to the previous marshaller design.
Verified manually that we emit the right code for the case in #76584
Fixes #76584
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Author:jkoritzinsky
Assignees:-
Labels:
area-System.Runtime.InteropServices, source-generator
Milestone:-
@elinor-fung
elinor-fung
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
What do you think about adding tests that just validate the Free of a marshaller implementation gets called? Similar to ones we have for OnInvoked and the guaranteed unmarshalling methods.
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
I'll try to come up with a test.
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 4, 2022

Copy link


Copy Markdown

Member
Given the scope of the break that this fixes (memory leaks), I think this is a backport candidate.
Yes, it is.
@runfoapprunfoappBot
mentioned this pull request
Oct 5, 2022

Closed

@AaronRobinsonMSFT
AaronRobinsonMSFT
merged commit 3a578af
into
dotnet:mainOct 5, 2022
@AaronRobinsonMSFT
AaronRobinsonMSFT
commented
Oct 5, 2022

Copy link


Copy Markdown

Member
/backport to release/7.0
@github-actions
github-actionsBot
commented
Oct 5, 2022

Copy link


Copy Markdown

Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3193476808
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 5, 2022
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2022
@jkoritzinsky
jkoritzinsky
deleted the

element-free-fix

branch
March 22, 2024 01:25
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@jkotasjkotasAwaiting requested review from jkotas

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

MARSHALLED_UNICODE_STRING[] array marshalling leaks memory


3 participants

@jkoritzinsky@elinor-fung@AaronRobinsonMSFT