Skip to content

[mono] Fix incorrect version comparison in loader - #76665

Merged
akoeplinger merged 1 commit into
dotnet:mainfrom
uweigand:mono-assemblyversion-fix
Oct 6, 2022
Merged

[mono] Fix incorrect version comparison in loader#76665
akoeplinger merged 1 commit into
dotnet:mainfrom
uweigand:mono-assemblyversion-fix

Conversation

@uweigand

@uweiganduweigand commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

This should be backported to .NET 7 and .NET 6 as well.

@uweigand
[mono] Fix incorrect version comparison in loader
e126158
* Compare version components in the correct order in
assembly_names_compare_versions
* Fixes#76664
@ghostghost added area-AssemblyLoader-mono community-contribution Indicates that the PR has been added by a community member labels Oct 5, 2022
@ghost

ghost commented Oct 5, 2022

Copy link
Copy Markdown

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

This should be backported to .NET 7 and .NET 6 as well.

Author:uweigand
Assignees:-
Labels:

area-AssemblyLoader-mono

Milestone:-

@lambdageek

lambdageek commented Oct 6, 2022

Copy link
Copy Markdown
Member

/backport to release/7.0

@lambdageek

lambdageek commented Oct 6, 2022

Copy link
Copy Markdown
Member

/backport to release/6.0

@github-actions

github-actionsBot commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3194198853

@github-actions

github-actionsBot commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3194200068

@lambdageek

lambdageek commented Oct 6, 2022

Copy link
Copy Markdown
Member

@akoeplinger this is probably worth porting to mono/mono 2020-02, as well

This was referenced Oct 6, 2022
Merged
Merged
@lambdageeklambdageek self-assigned this Oct 6, 2022
akoeplinger
akoeplinger approved these changes Oct 6, 2022
View reviewed changes

@akoeplingerakoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Kind of amazing this got unnoticed so long 😄

@akoeplinger

akoeplinger commented Oct 6, 2022

Copy link
Copy Markdown
Member

/azp run sync-runtime-to-mono

@azure-pipelines

azure-pipelinesBot commented Oct 6, 2022

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@akoeplinger

akoeplinger commented Oct 6, 2022•
edited
Loading

Copy link
Copy Markdown
Member

hm looks like the sync pipeline got lost in the dnceng-public migration somehow. @uweigand would you mind manually porting this to mono/mono?

uweigand added a commit to uweigand/mono that referenced this pull request Oct 6, 2022
@uweigand
Fix incorrect version comparison in loader
95dd667
* Backport dotnet/runtime#76665
@uweiganduweigand mentioned this pull request Oct 6, 2022
Merged
@uweigand

uweigand commented Oct 6, 2022

Copy link
Copy Markdown
ContributorAuthor

hm looks like the sync pipeline got lost in the dnceng-public migration somehow. @uweigand would you mind manually porting this to mono/mono?

mono/mono#21553

@akoeplinger
akoeplinger merged commit 11b4ef9 into dotnet:mainOct 6, 2022
github-actionsBot pushed a commit to mono/mono that referenced this pull request Oct 6, 2022
@uweigand
Fix incorrect version comparison in loader
49dea11
* Backport dotnet/runtime#76665
akoeplinger pushed a commit to mono/mono that referenced this pull request Oct 6, 2022
@github-actions@uweigand
Fix incorrect version comparison in loader (#21554)
7cd0b7f
* Backport dotnet/runtime#76665
Co-authored-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
akoeplinger pushed a commit to mono/mono that referenced this pull request Oct 6, 2022
@uweigand
Fix incorrect version comparison in loader (#21553)
4cb02db
* Backport dotnet/runtime#76665
@ghostghost locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@vargazvargazAwaiting requested review from vargaz
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner

Assignees

@lambdageeklambdageek

Labels

area-AssemblyLoader-monocommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[mono] Incorrect version comparison in the loader

3 participants

@uweigand@lambdageek@akoeplinger