[mono][interp] Fix an issue with deopt and interpreter tiering.

[vargaz]

If a method is tiered while being run from interp_run_clause_with_il_state (), the clause_args argument to interp_exec_method () still contains the old IL offsets confusing the EH code, i.e. this line:

if (clause_args && frame == clause_args->exec_frame && context->handler_ip >= clause_args->end_at_ip)

Clear out clause_args at the beginning to avoid this.

Hopefully fixes
#76134
#74302

[ghost]

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

---

If a method is tiered while being run from interp_run_clause_with_il_state (), the clause_args argument to interp_exec_method () still contains the old IL offsets confusing the EH code, i.e. this line:

if (clause_args && frame == clause_args->exec_frame && context->handler_ip >= clause_args->end_at_ip)

Clear out clause_args at the beginning to avoid this.

Hopefully fixes
#76134
#74302

Author:	vargaz
Assignees:	vargaz
Labels:	area-Codegen-Interpreter-mono
Milestone:	-

[vargaz]

@BrzVlad this might also affect the other cases where clause_args is set i.e. interp_run_finally ()/interp_run_filter ().

[vargaz]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[BrzVlad]

We should probably update the native offset in clause args end_at_ip when tiering

[vargaz]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vargaz]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vargaz]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vargaz]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[lewing]

/backport to release/7.0

[github-actions]

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3252554294

[BrzVlad]

@vargaz From what I understand the problem with these issues was that the tiered ip was not updated in the clause_args. Your change disables tiering while running from EH. So what's the point of the rest of the change involving run_until_end, I also don't understand what that is supposed to do

[vargaz]

The first commit fixed the original issue when called from with_il_state, the second one fixes the potential issue when called from run_finally ()/run_filter (). Maybe the second one fixes the first issue as well, but clearing out clause_args seems cleaner.

[BrzVlad]

I understand now that clearing out the clause_args might make sense when running catch clauses of aot methods, since we run with interp all the way until the method end, but doing this also for filter clauses seems bogus.

[vargaz]

clause_args is only really used when running finally/filter clauses for 'real' interpreted methods, we just reuse the argument from with_il_state () to avoid having to add another argument. So this is why we clear it. Maybe we should clear it for catch clauses as well.