Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Properly handle filesizes larger than 8 Gb - #76756
Merged
Conversation
carlossanlop
approved these changes
Oct 7, 2022
ghost
commented
Oct 7, 2022
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsBackport of #76707 to release/7.0 /cc @jozkee Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
carlossanlop
commented
Oct 7, 2022
Contributor
Approved by Tactics via email. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
jozkee
commented
Oct 7, 2022
Member
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 7, 2022
carlossanlop
commented
Oct 10, 2022
Contributor
CI failures unrelated. Approved and signed off. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #76707 to release/7.0
/cc @jozkee
Customer Impact
Testing
size= 8,589,934,591) on all formats.size.Risk
New feature, no regression involved. There's risk on the newly added tests since those create 8 Gb files, but they are marked as outerloop and parallelization is disabled.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.