Cache allregs to avoid checking the type repeatedly - #76850

Merged
kunalspathak merged 8 commits into
dotnet:mainfrom
kunalspathak:cache_allregs
Jan 10, 2023
Merged

Cache allregs to avoid checking the type repeatedly#76850
kunalspathak merged 8 commits into
dotnet:mainfrom
kunalspathak:cache_allregs

Conversation

@kunalspathak

@kunalspathakkunalspathak commented Oct 11, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Cache the availableRegs in a table that we can look-up and return instead of comparing the type every single time in allRegs() method. Gives a nice TP:

image

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 11, 2022
@ghost

ghost commented Oct 11, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:kunalspathak
Assignees:kunalspathak
Labels:

area-CodeGen-coreclr

Milestone:-

This was referenced Oct 11, 2022
Closed
Closed
@kunalspathak
kunalspathak marked this pull request as ready for review October 11, 2022 23:29
@kunalspathak

kunalspathak commented Oct 12, 2022

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

@SingleAccretion

SingleAccretion commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

What's up with the regressions on x86?

@kunalspathak

kunalspathak commented Oct 12, 2022

Copy link
Copy Markdown
ContributorAuthor

What's up with the regressions on x86?

I will have to double check, but the regression is on Linux/arm MinOpts only.

image

@jakobbotsch

jakobbotsch commented Oct 12, 2022

Copy link
Copy Markdown
Member

I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:

image

image

(The libraries.crossgen2 collections have respectively 16 and 14 MinOpts contexts, so I don't think you can really read much from those)

@SingleAccretion

SingleAccretion commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Linux/arm MinOpts only.

Note it is present in Windows x86/MinOpts benchmarks / CG collections as well.

@jakobbotschjakobbotsch mentioned this pull request Oct 12, 2022
Closed
@jakobbotsch

jakobbotsch commented Oct 12, 2022

Copy link
Copy Markdown
Member

I wonder if it's because it makes allRegs(<constant type>) more expensive. I see a bunch of those throughout LSRA that could be replaced with the right availableXRegs field.

@kunalspathak

kunalspathak commented Oct 13, 2022

Copy link
Copy Markdown
ContributorAuthor

I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:

Ok, yeah I am still learning that I have to expand those details :)

Tried inlining the availableIntRegs directly at places where allRegs(TYP_INT) were present but it doesn't help much. Will disassemble and see what is different.

@kunalspathak

kunalspathak commented Nov 14, 2022

Copy link
Copy Markdown
ContributorAuthor

Still need to do the TP regression analysis for MinOpts.

@kunalspathak

kunalspathak commented Dec 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Ping to myself.

@kunalspathak

kunalspathak commented Jan 9, 2023

Copy link
Copy Markdown
ContributorAuthor

Hoping to review the TP analysis soon.

@kunalspathak

kunalspathak commented Jan 9, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

The biggest diffs in MinOpts for benchmarks on windows/x64 are these. I will investigate more.

-22555 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z+193049 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z-460532 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z+942354 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z
Base: 438977289, Diff: 437964751, -0.2307%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 481822 : +104.62% : 20.73% : +0.1098%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 170494 : +755.90% : 7.34% : +0.0388%
?defineNewInternalTemp@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@W4var_types@@I@Z : 2874 : +5.56% : 0.12% : +0.0007%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -2499 : -0.26% : 0.11% : -0.0006%
?identifyCandidates@LinearScan@@AEAAXXZ : -6888 : -3.02% : 0.30% : -0.0016%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -36677 : -0.23% : 1.58% : -0.0084%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -85337 : -0.94% : 3.67% : -0.0194%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -204706 : -2.84% : 8.81% : -0.0466%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -403823 : -100.00% : 17.38% : -0.0920%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -924883 : -6.09% : 39.80% : -0.2107%

@kunalspathak

kunalspathak commented Jan 9, 2023

Copy link
Copy Markdown
ContributorAuthor

I tried running locally and don't see any regression (at least on windows/x64):

image

@kunalspathak

kunalspathak commented Jan 9, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr superpmi-diffs

@azure-pipelines

azure-pipelinesBot commented Jan 9, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak

kunalspathak commented Jan 10, 2023

Copy link
Copy Markdown
ContributorAuthor

The latest run doesn't have any benchmarks regression. It just has TP regression on crossgen2 and I tried to eliminate some of that by eliminating the call to varTypeIsSIMD().

Here is the latest and I don't think there is anything much that can be done:

Base: 1801740, Diff: 1802793, +0.0584%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 5430 : +104.62% : 54.91% : +0.3014%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 21 : +7.95% : 0.21% : +0.0012%
memset : 16 : +0.17% : 0.16% : +0.0009%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -30 : -0.90% : 0.30% : -0.0017%
?identifyCandidates@LinearScan@@AEAAXXZ : -33 : -1.66% : 0.33% : -0.0018%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -103 : -0.34% : 1.04% : -0.0057%
?genFnPrologCalleeRegArgs@CodeGen@@IEAAXW4_regNumber_enum@@PEA_NPEAURegState@@@Z : -189 : -2.42% : 1.91% : -0.0105%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -526 : -2.45% : 5.32% : -0.0292%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -634 : -3.62% : 6.41% : -0.0352%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -1246 : -100.00% : 12.60% : -0.0692%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -1657 : -4.58% : 16.76% : -0.0920%

@jakobbotsch

jakobbotsch commented Jan 10, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@kunalspathak What if you change the initialization of the table to:

for (unsignedint i = 0; i < TYP_COUNT; i++)
{
availableRegs[i] = &availableIntRegs;
}
availableRegs[TYP_FLOAT] = &availableFloatRegs;
availableRegs[TYP_DOUBLE] = &availableDoubleRegs;
#ifdef FEATURE_SIMD
availableRegs[TYP_SIMD8] = &availableDoubleRegs;
availableRegs[TYP_SIMD12] = &availableDoubleRegs;
availableRegs[TYP_SIMD16] = &availableDoubleRegs;
availableRegs[TYP_SIMD32] = &availableDoubleRegs;
#endif

In any case it still looks minor to me.

@kunalspathak

kunalspathak commented Jan 10, 2023

Copy link
Copy Markdown
ContributorAuthor

@kunalspathak What if you change the initialization of the table to:

That's a reasonable approach, but as I mentioned earlier, this is LinearScan ctor which just gets invoked once per compilation. With the latest changes, the TP regression dropped, so I will go ahead and merge it.

image

This was a good exercise for me to learn how to analyze TP regression locally.

@kunalspathak
kunalspathak merged commit 7a6c31c into dotnet:mainJan 10, 2023
@ghostghost locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
+1 more reviewer
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@SingleAccretion@jakobbotsch@BruceForstall
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Cache allregs to avoid checking the type repeatedly - #76850
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Jan 10, 2023
Merged
Cache allregs to avoid checking the type repeatedly#76850
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
Oct 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Cache the availableRegs in a table that we can look-up and return instead of comparing the type every single time in allRegs() method. Gives a nice TP:
image
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Oct 11, 2022
@ghost
ghost
commented
Oct 11, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:kunalspathak
Assignees:kunalspathak
Labels:
area-CodeGen-coreclr
Milestone:-

This was referenced Oct 11, 2022

Closed


Closed

@kunalspathak
kunalspathak
marked this pull request as ready for review
October 11, 2022 23:29
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
What's up with the regressions on x86?
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
What's up with the regressions on x86?
I will have to double check, but the regression is on Linux/arm MinOpts only.
image
@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
image
image
(The libraries.crossgen2 collections have respectively 16 and 14 MinOpts contexts, so I don't think you can really read much from those)
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
Linux/arm MinOpts only.
Note it is present in Windows x86/MinOpts benchmarks / CG collections as well.
@jakobbotschjakobbotsch
mentioned this pull request
Oct 12, 2022

Closed

@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I wonder if it's because it makes allRegs(<constant type>) more expensive. I see a bunch of those throughout LSRA that could be replaced with the right availableXRegs field.
@kunalspathak
kunalspathak
commented
Oct 13, 2022

Copy link


Copy Markdown

ContributorAuthor
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
Ok, yeah I am still learning that I have to expand those details :)
Tried inlining the availableIntRegs directly at places where allRegs(TYP_INT) were present but it doesn't help much. Will disassemble and see what is different.
@kunalspathak
kunalspathak
commented
Nov 14, 2022

Copy link


Copy Markdown

ContributorAuthor
Still need to do the TP regression analysis for MinOpts.
@kunalspathak
kunalspathak
commented
Dec 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Ping to myself.
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
Hoping to review the TP analysis soon.
@kunalspathak
kunalspathak
commented
Jan 9, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
The biggest diffs in MinOpts for benchmarks on windows/x64 are these. I will investigate more.
-22555 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z+193049 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z-460532 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z+942354 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z
Base: 438977289, Diff: 437964751, -0.2307%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 481822 : +104.62% : 20.73% : +0.1098%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 170494 : +755.90% : 7.34% : +0.0388%
?defineNewInternalTemp@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@W4var_types@@I@Z : 2874 : +5.56% : 0.12% : +0.0007%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -2499 : -0.26% : 0.11% : -0.0006%
?identifyCandidates@LinearScan@@AEAAXXZ : -6888 : -3.02% : 0.30% : -0.0016%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -36677 : -0.23% : 1.58% : -0.0084%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -85337 : -0.94% : 3.67% : -0.0194%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -204706 : -2.84% : 8.81% : -0.0466%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -403823 : -100.00% : 17.38% : -0.0920%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -924883 : -6.09% : 39.80% : -0.2107%

@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
I tried running locally and don't see any regression (at least on windows/x64):
image
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Jan 9, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
The latest run doesn't have any benchmarks regression. It just has TP regression on crossgen2 and I tried to eliminate some of that by eliminating the call to varTypeIsSIMD().
Here is the latest and I don't think there is anything much that can be done:
Base: 1801740, Diff: 1802793, +0.0584%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 5430 : +104.62% : 54.91% : +0.3014%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 21 : +7.95% : 0.21% : +0.0012%
memset : 16 : +0.17% : 0.16% : +0.0009%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -30 : -0.90% : 0.30% : -0.0017%
?identifyCandidates@LinearScan@@AEAAXXZ : -33 : -1.66% : 0.33% : -0.0018%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -103 : -0.34% : 1.04% : -0.0057%
?genFnPrologCalleeRegArgs@CodeGen@@IEAAXW4_regNumber_enum@@PEA_NPEAURegState@@@Z : -189 : -2.42% : 1.91% : -0.0105%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -526 : -2.45% : 5.32% : -0.0292%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -634 : -3.62% : 6.41% : -0.0352%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -1246 : -100.00% : 12.60% : -0.0692%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -1657 : -4.58% : 16.76% : -0.0920%

@jakobbotsch
jakobbotsch
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak What if you change the initialization of the table to:
for (unsignedint i = 0; i < TYP_COUNT; i++)
{
availableRegs[i] = &availableIntRegs;
}
availableRegs[TYP_FLOAT] = &availableFloatRegs;
availableRegs[TYP_DOUBLE] = &availableDoubleRegs;
#ifdef FEATURE_SIMD
availableRegs[TYP_SIMD8] = &availableDoubleRegs;
availableRegs[TYP_SIMD12] = &availableDoubleRegs;
availableRegs[TYP_SIMD16] = &availableDoubleRegs;
availableRegs[TYP_SIMD32] = &availableDoubleRegs;
#endif
In any case it still looks minor to me.
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak What if you change the initialization of the table to:
That's a reasonable approach, but as I mentioned earlier, this is LinearScan ctor which just gets invoked once per compilation. With the latest changes, the TP regression dropped, so I will go ahead and merge it.
image
This was a good exercise for me to learn how to analyze TP regression locally.
@kunalspathak
kunalspathak
merged commit 7a6c31c
into
dotnet:mainJan 10, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@SingleAccretion@jakobbotsch@BruceForstall

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cache allregs to avoid checking the type repeatedly - #76850
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Jan 10, 2023
Merged
Cache allregs to avoid checking the type repeatedly#76850
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
Oct 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Cache the availableRegs in a table that we can look-up and return instead of comparing the type every single time in allRegs() method. Gives a nice TP:
image
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Oct 11, 2022
@ghost
ghost
commented
Oct 11, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:kunalspathak
Assignees:kunalspathak
Labels:
area-CodeGen-coreclr
Milestone:-

This was referenced Oct 11, 2022

Closed


Closed

@kunalspathak
kunalspathak
marked this pull request as ready for review
October 11, 2022 23:29
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
What's up with the regressions on x86?
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
What's up with the regressions on x86?
I will have to double check, but the regression is on Linux/arm MinOpts only.
image
@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
image
image
(The libraries.crossgen2 collections have respectively 16 and 14 MinOpts contexts, so I don't think you can really read much from those)
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
Linux/arm MinOpts only.
Note it is present in Windows x86/MinOpts benchmarks / CG collections as well.
@jakobbotschjakobbotsch
mentioned this pull request
Oct 12, 2022

Closed

@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I wonder if it's because it makes allRegs(<constant type>) more expensive. I see a bunch of those throughout LSRA that could be replaced with the right availableXRegs field.
@kunalspathak
kunalspathak
commented
Oct 13, 2022

Copy link


Copy Markdown

ContributorAuthor
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
Ok, yeah I am still learning that I have to expand those details :)
Tried inlining the availableIntRegs directly at places where allRegs(TYP_INT) were present but it doesn't help much. Will disassemble and see what is different.
@kunalspathak
kunalspathak
commented
Nov 14, 2022

Copy link


Copy Markdown

ContributorAuthor
Still need to do the TP regression analysis for MinOpts.
@kunalspathak
kunalspathak
commented
Dec 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Ping to myself.
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
Hoping to review the TP analysis soon.
@kunalspathak
kunalspathak
commented
Jan 9, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
The biggest diffs in MinOpts for benchmarks on windows/x64 are these. I will investigate more.
-22555 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z+193049 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z-460532 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z+942354 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z
Base: 438977289, Diff: 437964751, -0.2307%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 481822 : +104.62% : 20.73% : +0.1098%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 170494 : +755.90% : 7.34% : +0.0388%
?defineNewInternalTemp@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@W4var_types@@I@Z : 2874 : +5.56% : 0.12% : +0.0007%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -2499 : -0.26% : 0.11% : -0.0006%
?identifyCandidates@LinearScan@@AEAAXXZ : -6888 : -3.02% : 0.30% : -0.0016%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -36677 : -0.23% : 1.58% : -0.0084%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -85337 : -0.94% : 3.67% : -0.0194%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -204706 : -2.84% : 8.81% : -0.0466%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -403823 : -100.00% : 17.38% : -0.0920%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -924883 : -6.09% : 39.80% : -0.2107%

@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
I tried running locally and don't see any regression (at least on windows/x64):
image
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Jan 9, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
The latest run doesn't have any benchmarks regression. It just has TP regression on crossgen2 and I tried to eliminate some of that by eliminating the call to varTypeIsSIMD().
Here is the latest and I don't think there is anything much that can be done:
Base: 1801740, Diff: 1802793, +0.0584%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 5430 : +104.62% : 54.91% : +0.3014%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 21 : +7.95% : 0.21% : +0.0012%
memset : 16 : +0.17% : 0.16% : +0.0009%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -30 : -0.90% : 0.30% : -0.0017%
?identifyCandidates@LinearScan@@AEAAXXZ : -33 : -1.66% : 0.33% : -0.0018%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -103 : -0.34% : 1.04% : -0.0057%
?genFnPrologCalleeRegArgs@CodeGen@@IEAAXW4_regNumber_enum@@PEA_NPEAURegState@@@Z : -189 : -2.42% : 1.91% : -0.0105%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -526 : -2.45% : 5.32% : -0.0292%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -634 : -3.62% : 6.41% : -0.0352%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -1246 : -100.00% : 12.60% : -0.0692%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -1657 : -4.58% : 16.76% : -0.0920%

@jakobbotsch
jakobbotsch
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak What if you change the initialization of the table to:
for (unsignedint i = 0; i < TYP_COUNT; i++)
{
availableRegs[i] = &availableIntRegs;
}
availableRegs[TYP_FLOAT] = &availableFloatRegs;
availableRegs[TYP_DOUBLE] = &availableDoubleRegs;
#ifdef FEATURE_SIMD
availableRegs[TYP_SIMD8] = &availableDoubleRegs;
availableRegs[TYP_SIMD12] = &availableDoubleRegs;
availableRegs[TYP_SIMD16] = &availableDoubleRegs;
availableRegs[TYP_SIMD32] = &availableDoubleRegs;
#endif
In any case it still looks minor to me.
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak What if you change the initialization of the table to:
That's a reasonable approach, but as I mentioned earlier, this is LinearScan ctor which just gets invoked once per compilation. With the latest changes, the TP regression dropped, so I will go ahead and merge it.
image
This was a good exercise for me to learn how to analyze TP regression locally.
@kunalspathak
kunalspathak
merged commit 7a6c31c
into
dotnet:mainJan 10, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@SingleAccretion@jakobbotsch@BruceForstall

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cache allregs to avoid checking the type repeatedly - #76850
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Jan 10, 2023
Merged
Cache allregs to avoid checking the type repeatedly#76850
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
Oct 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Cache the availableRegs in a table that we can look-up and return instead of comparing the type every single time in allRegs() method. Gives a nice TP:
image
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Oct 11, 2022
@ghost
ghost
commented
Oct 11, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:kunalspathak
Assignees:kunalspathak
Labels:
area-CodeGen-coreclr
Milestone:-

This was referenced Oct 11, 2022

Closed


Closed

@kunalspathak
kunalspathak
marked this pull request as ready for review
October 11, 2022 23:29
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
What's up with the regressions on x86?
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
What's up with the regressions on x86?
I will have to double check, but the regression is on Linux/arm MinOpts only.
image
@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
image
image
(The libraries.crossgen2 collections have respectively 16 and 14 MinOpts contexts, so I don't think you can really read much from those)
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
Linux/arm MinOpts only.
Note it is present in Windows x86/MinOpts benchmarks / CG collections as well.
@jakobbotschjakobbotsch
mentioned this pull request
Oct 12, 2022

Closed

@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I wonder if it's because it makes allRegs(<constant type>) more expensive. I see a bunch of those throughout LSRA that could be replaced with the right availableXRegs field.
@kunalspathak
kunalspathak
commented
Oct 13, 2022

Copy link


Copy Markdown

ContributorAuthor
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
Ok, yeah I am still learning that I have to expand those details :)
Tried inlining the availableIntRegs directly at places where allRegs(TYP_INT) were present but it doesn't help much. Will disassemble and see what is different.
@kunalspathak
kunalspathak
commented
Nov 14, 2022

Copy link


Copy Markdown

ContributorAuthor
Still need to do the TP regression analysis for MinOpts.
@kunalspathak
kunalspathak
commented
Dec 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Ping to myself.
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
Hoping to review the TP analysis soon.
@kunalspathak
kunalspathak
commented
Jan 9, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
The biggest diffs in MinOpts for benchmarks on windows/x64 are these. I will investigate more.
-22555 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z+193049 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z-460532 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z+942354 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z
Base: 438977289, Diff: 437964751, -0.2307%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 481822 : +104.62% : 20.73% : +0.1098%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 170494 : +755.90% : 7.34% : +0.0388%
?defineNewInternalTemp@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@W4var_types@@I@Z : 2874 : +5.56% : 0.12% : +0.0007%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -2499 : -0.26% : 0.11% : -0.0006%
?identifyCandidates@LinearScan@@AEAAXXZ : -6888 : -3.02% : 0.30% : -0.0016%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -36677 : -0.23% : 1.58% : -0.0084%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -85337 : -0.94% : 3.67% : -0.0194%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -204706 : -2.84% : 8.81% : -0.0466%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -403823 : -100.00% : 17.38% : -0.0920%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -924883 : -6.09% : 39.80% : -0.2107%

@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
I tried running locally and don't see any regression (at least on windows/x64):
image
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Jan 9, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
The latest run doesn't have any benchmarks regression. It just has TP regression on crossgen2 and I tried to eliminate some of that by eliminating the call to varTypeIsSIMD().
Here is the latest and I don't think there is anything much that can be done:
Base: 1801740, Diff: 1802793, +0.0584%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 5430 : +104.62% : 54.91% : +0.3014%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 21 : +7.95% : 0.21% : +0.0012%
memset : 16 : +0.17% : 0.16% : +0.0009%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -30 : -0.90% : 0.30% : -0.0017%
?identifyCandidates@LinearScan@@AEAAXXZ : -33 : -1.66% : 0.33% : -0.0018%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -103 : -0.34% : 1.04% : -0.0057%
?genFnPrologCalleeRegArgs@CodeGen@@IEAAXW4_regNumber_enum@@PEA_NPEAURegState@@@Z : -189 : -2.42% : 1.91% : -0.0105%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -526 : -2.45% : 5.32% : -0.0292%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -634 : -3.62% : 6.41% : -0.0352%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -1246 : -100.00% : 12.60% : -0.0692%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -1657 : -4.58% : 16.76% : -0.0920%

@jakobbotsch
jakobbotsch
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak What if you change the initialization of the table to:
for (unsignedint i = 0; i < TYP_COUNT; i++)
{
availableRegs[i] = &availableIntRegs;
}
availableRegs[TYP_FLOAT] = &availableFloatRegs;
availableRegs[TYP_DOUBLE] = &availableDoubleRegs;
#ifdef FEATURE_SIMD
availableRegs[TYP_SIMD8] = &availableDoubleRegs;
availableRegs[TYP_SIMD12] = &availableDoubleRegs;
availableRegs[TYP_SIMD16] = &availableDoubleRegs;
availableRegs[TYP_SIMD32] = &availableDoubleRegs;
#endif
In any case it still looks minor to me.
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak What if you change the initialization of the table to:
That's a reasonable approach, but as I mentioned earlier, this is LinearScan ctor which just gets invoked once per compilation. With the latest changes, the TP regression dropped, so I will go ahead and merge it.
image
This was a good exercise for me to learn how to analyze TP regression locally.
@kunalspathak
kunalspathak
merged commit 7a6c31c
into
dotnet:mainJan 10, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@SingleAccretion@jakobbotsch@BruceForstall

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Cache allregs to avoid checking the type repeatedly - #76850
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Jan 10, 2023
Merged
Cache allregs to avoid checking the type repeatedly#76850
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
Oct 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Cache the availableRegs in a table that we can look-up and return instead of comparing the type every single time in allRegs() method. Gives a nice TP:
image
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Oct 11, 2022
@ghost
ghost
commented
Oct 11, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:kunalspathak
Assignees:kunalspathak
Labels:
area-CodeGen-coreclr
Milestone:-

This was referenced Oct 11, 2022

Closed


Closed

@kunalspathak
kunalspathak
marked this pull request as ready for review
October 11, 2022 23:29
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
What's up with the regressions on x86?
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
What's up with the regressions on x86?
I will have to double check, but the regression is on Linux/arm MinOpts only.
image
@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
image
image
(The libraries.crossgen2 collections have respectively 16 and 14 MinOpts contexts, so I don't think you can really read much from those)
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
Linux/arm MinOpts only.
Note it is present in Windows x86/MinOpts benchmarks / CG collections as well.
@jakobbotschjakobbotsch
mentioned this pull request
Oct 12, 2022

Closed

@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I wonder if it's because it makes allRegs(<constant type>) more expensive. I see a bunch of those throughout LSRA that could be replaced with the right availableXRegs field.
@kunalspathak
kunalspathak
commented
Oct 13, 2022

Copy link


Copy Markdown

ContributorAuthor
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
Ok, yeah I am still learning that I have to expand those details :)
Tried inlining the availableIntRegs directly at places where allRegs(TYP_INT) were present but it doesn't help much. Will disassemble and see what is different.
@kunalspathak
kunalspathak
commented
Nov 14, 2022

Copy link


Copy Markdown

ContributorAuthor
Still need to do the TP regression analysis for MinOpts.
@kunalspathak
kunalspathak
commented
Dec 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Ping to myself.
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
Hoping to review the TP analysis soon.
@kunalspathak
kunalspathak
commented
Jan 9, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
The biggest diffs in MinOpts for benchmarks on windows/x64 are these. I will investigate more.
-22555 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z+193049 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z-460532 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z+942354 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z
Base: 438977289, Diff: 437964751, -0.2307%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 481822 : +104.62% : 20.73% : +0.1098%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 170494 : +755.90% : 7.34% : +0.0388%
?defineNewInternalTemp@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@W4var_types@@I@Z : 2874 : +5.56% : 0.12% : +0.0007%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -2499 : -0.26% : 0.11% : -0.0006%
?identifyCandidates@LinearScan@@AEAAXXZ : -6888 : -3.02% : 0.30% : -0.0016%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -36677 : -0.23% : 1.58% : -0.0084%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -85337 : -0.94% : 3.67% : -0.0194%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -204706 : -2.84% : 8.81% : -0.0466%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -403823 : -100.00% : 17.38% : -0.0920%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -924883 : -6.09% : 39.80% : -0.2107%

@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
I tried running locally and don't see any regression (at least on windows/x64):
image
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Jan 9, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
The latest run doesn't have any benchmarks regression. It just has TP regression on crossgen2 and I tried to eliminate some of that by eliminating the call to varTypeIsSIMD().
Here is the latest and I don't think there is anything much that can be done:
Base: 1801740, Diff: 1802793, +0.0584%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 5430 : +104.62% : 54.91% : +0.3014%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 21 : +7.95% : 0.21% : +0.0012%
memset : 16 : +0.17% : 0.16% : +0.0009%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -30 : -0.90% : 0.30% : -0.0017%
?identifyCandidates@LinearScan@@AEAAXXZ : -33 : -1.66% : 0.33% : -0.0018%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -103 : -0.34% : 1.04% : -0.0057%
?genFnPrologCalleeRegArgs@CodeGen@@IEAAXW4_regNumber_enum@@PEA_NPEAURegState@@@Z : -189 : -2.42% : 1.91% : -0.0105%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -526 : -2.45% : 5.32% : -0.0292%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -634 : -3.62% : 6.41% : -0.0352%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -1246 : -100.00% : 12.60% : -0.0692%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -1657 : -4.58% : 16.76% : -0.0920%

@jakobbotsch
jakobbotsch
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak What if you change the initialization of the table to:
for (unsignedint i = 0; i < TYP_COUNT; i++)
{
availableRegs[i] = &availableIntRegs;
}
availableRegs[TYP_FLOAT] = &availableFloatRegs;
availableRegs[TYP_DOUBLE] = &availableDoubleRegs;
#ifdef FEATURE_SIMD
availableRegs[TYP_SIMD8] = &availableDoubleRegs;
availableRegs[TYP_SIMD12] = &availableDoubleRegs;
availableRegs[TYP_SIMD16] = &availableDoubleRegs;
availableRegs[TYP_SIMD32] = &availableDoubleRegs;
#endif
In any case it still looks minor to me.
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak What if you change the initialization of the table to:
That's a reasonable approach, but as I mentioned earlier, this is LinearScan ctor which just gets invoked once per compilation. With the latest changes, the TP regression dropped, so I will go ahead and merge it.
image
This was a good exercise for me to learn how to analyze TP regression locally.
@kunalspathak
kunalspathak
merged commit 7a6c31c
into
dotnet:mainJan 10, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@SingleAccretion@jakobbotsch@BruceForstall

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cache allregs to avoid checking the type repeatedly - #76850
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Jan 10, 2023
Merged
Cache allregs to avoid checking the type repeatedly#76850
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
Oct 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Cache the availableRegs in a table that we can look-up and return instead of comparing the type every single time in allRegs() method. Gives a nice TP:
image
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Oct 11, 2022
@ghost
ghost
commented
Oct 11, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:kunalspathak
Assignees:kunalspathak
Labels:
area-CodeGen-coreclr
Milestone:-

This was referenced Oct 11, 2022

Closed


Closed

@kunalspathak
kunalspathak
marked this pull request as ready for review
October 11, 2022 23:29
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
What's up with the regressions on x86?
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
What's up with the regressions on x86?
I will have to double check, but the regression is on Linux/arm MinOpts only.
image
@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
image
image
(The libraries.crossgen2 collections have respectively 16 and 14 MinOpts contexts, so I don't think you can really read much from those)
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
Linux/arm MinOpts only.
Note it is present in Windows x86/MinOpts benchmarks / CG collections as well.
@jakobbotschjakobbotsch
mentioned this pull request
Oct 12, 2022

Closed

@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I wonder if it's because it makes allRegs(<constant type>) more expensive. I see a bunch of those throughout LSRA that could be replaced with the right availableXRegs field.
@kunalspathak
kunalspathak
commented
Oct 13, 2022

Copy link


Copy Markdown

ContributorAuthor
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
Ok, yeah I am still learning that I have to expand those details :)
Tried inlining the availableIntRegs directly at places where allRegs(TYP_INT) were present but it doesn't help much. Will disassemble and see what is different.
@kunalspathak
kunalspathak
commented
Nov 14, 2022

Copy link


Copy Markdown

ContributorAuthor
Still need to do the TP regression analysis for MinOpts.
@kunalspathak
kunalspathak
commented
Dec 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Ping to myself.
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
Hoping to review the TP analysis soon.
@kunalspathak
kunalspathak
commented
Jan 9, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
The biggest diffs in MinOpts for benchmarks on windows/x64 are these. I will investigate more.
-22555 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z+193049 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z-460532 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z+942354 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z
Base: 438977289, Diff: 437964751, -0.2307%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 481822 : +104.62% : 20.73% : +0.1098%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 170494 : +755.90% : 7.34% : +0.0388%
?defineNewInternalTemp@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@W4var_types@@I@Z : 2874 : +5.56% : 0.12% : +0.0007%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -2499 : -0.26% : 0.11% : -0.0006%
?identifyCandidates@LinearScan@@AEAAXXZ : -6888 : -3.02% : 0.30% : -0.0016%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -36677 : -0.23% : 1.58% : -0.0084%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -85337 : -0.94% : 3.67% : -0.0194%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -204706 : -2.84% : 8.81% : -0.0466%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -403823 : -100.00% : 17.38% : -0.0920%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -924883 : -6.09% : 39.80% : -0.2107%

@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
I tried running locally and don't see any regression (at least on windows/x64):
image
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Jan 9, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
The latest run doesn't have any benchmarks regression. It just has TP regression on crossgen2 and I tried to eliminate some of that by eliminating the call to varTypeIsSIMD().
Here is the latest and I don't think there is anything much that can be done:
Base: 1801740, Diff: 1802793, +0.0584%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 5430 : +104.62% : 54.91% : +0.3014%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 21 : +7.95% : 0.21% : +0.0012%
memset : 16 : +0.17% : 0.16% : +0.0009%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -30 : -0.90% : 0.30% : -0.0017%
?identifyCandidates@LinearScan@@AEAAXXZ : -33 : -1.66% : 0.33% : -0.0018%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -103 : -0.34% : 1.04% : -0.0057%
?genFnPrologCalleeRegArgs@CodeGen@@IEAAXW4_regNumber_enum@@PEA_NPEAURegState@@@Z : -189 : -2.42% : 1.91% : -0.0105%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -526 : -2.45% : 5.32% : -0.0292%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -634 : -3.62% : 6.41% : -0.0352%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -1246 : -100.00% : 12.60% : -0.0692%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -1657 : -4.58% : 16.76% : -0.0920%

@jakobbotsch
jakobbotsch
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak What if you change the initialization of the table to:
for (unsignedint i = 0; i < TYP_COUNT; i++)
{
availableRegs[i] = &availableIntRegs;
}
availableRegs[TYP_FLOAT] = &availableFloatRegs;
availableRegs[TYP_DOUBLE] = &availableDoubleRegs;
#ifdef FEATURE_SIMD
availableRegs[TYP_SIMD8] = &availableDoubleRegs;
availableRegs[TYP_SIMD12] = &availableDoubleRegs;
availableRegs[TYP_SIMD16] = &availableDoubleRegs;
availableRegs[TYP_SIMD32] = &availableDoubleRegs;
#endif
In any case it still looks minor to me.
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak What if you change the initialization of the table to:
That's a reasonable approach, but as I mentioned earlier, this is LinearScan ctor which just gets invoked once per compilation. With the latest changes, the TP regression dropped, so I will go ahead and merge it.
image
This was a good exercise for me to learn how to analyze TP regression locally.
@kunalspathak
kunalspathak
merged commit 7a6c31c
into
dotnet:mainJan 10, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@SingleAccretion@jakobbotsch@BruceForstall

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cache allregs to avoid checking the type repeatedly - #76850
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Jan 10, 2023
Merged
Cache allregs to avoid checking the type repeatedly#76850
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
Oct 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Cache the availableRegs in a table that we can look-up and return instead of comparing the type every single time in allRegs() method. Gives a nice TP:
image
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Oct 11, 2022
@ghost
ghost
commented
Oct 11, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:kunalspathak
Assignees:kunalspathak
Labels:
area-CodeGen-coreclr
Milestone:-

This was referenced Oct 11, 2022

Closed


Closed

@kunalspathak
kunalspathak
marked this pull request as ready for review
October 11, 2022 23:29
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
What's up with the regressions on x86?
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
What's up with the regressions on x86?
I will have to double check, but the regression is on Linux/arm MinOpts only.
image
@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
image
image
(The libraries.crossgen2 collections have respectively 16 and 14 MinOpts contexts, so I don't think you can really read much from those)
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
Linux/arm MinOpts only.
Note it is present in Windows x86/MinOpts benchmarks / CG collections as well.
@jakobbotschjakobbotsch
mentioned this pull request
Oct 12, 2022

Closed

@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I wonder if it's because it makes allRegs(<constant type>) more expensive. I see a bunch of those throughout LSRA that could be replaced with the right availableXRegs field.
@kunalspathak
kunalspathak
commented
Oct 13, 2022

Copy link


Copy Markdown

ContributorAuthor
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
Ok, yeah I am still learning that I have to expand those details :)
Tried inlining the availableIntRegs directly at places where allRegs(TYP_INT) were present but it doesn't help much. Will disassemble and see what is different.
@kunalspathak
kunalspathak
commented
Nov 14, 2022

Copy link


Copy Markdown

ContributorAuthor
Still need to do the TP regression analysis for MinOpts.
@kunalspathak
kunalspathak
commented
Dec 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Ping to myself.
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
Hoping to review the TP analysis soon.
@kunalspathak
kunalspathak
commented
Jan 9, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
The biggest diffs in MinOpts for benchmarks on windows/x64 are these. I will investigate more.
-22555 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z+193049 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z-460532 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z+942354 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z
Base: 438977289, Diff: 437964751, -0.2307%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 481822 : +104.62% : 20.73% : +0.1098%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 170494 : +755.90% : 7.34% : +0.0388%
?defineNewInternalTemp@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@W4var_types@@I@Z : 2874 : +5.56% : 0.12% : +0.0007%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -2499 : -0.26% : 0.11% : -0.0006%
?identifyCandidates@LinearScan@@AEAAXXZ : -6888 : -3.02% : 0.30% : -0.0016%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -36677 : -0.23% : 1.58% : -0.0084%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -85337 : -0.94% : 3.67% : -0.0194%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -204706 : -2.84% : 8.81% : -0.0466%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -403823 : -100.00% : 17.38% : -0.0920%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -924883 : -6.09% : 39.80% : -0.2107%

@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
I tried running locally and don't see any regression (at least on windows/x64):
image
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Jan 9, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
The latest run doesn't have any benchmarks regression. It just has TP regression on crossgen2 and I tried to eliminate some of that by eliminating the call to varTypeIsSIMD().
Here is the latest and I don't think there is anything much that can be done:
Base: 1801740, Diff: 1802793, +0.0584%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 5430 : +104.62% : 54.91% : +0.3014%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 21 : +7.95% : 0.21% : +0.0012%
memset : 16 : +0.17% : 0.16% : +0.0009%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -30 : -0.90% : 0.30% : -0.0017%
?identifyCandidates@LinearScan@@AEAAXXZ : -33 : -1.66% : 0.33% : -0.0018%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -103 : -0.34% : 1.04% : -0.0057%
?genFnPrologCalleeRegArgs@CodeGen@@IEAAXW4_regNumber_enum@@PEA_NPEAURegState@@@Z : -189 : -2.42% : 1.91% : -0.0105%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -526 : -2.45% : 5.32% : -0.0292%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -634 : -3.62% : 6.41% : -0.0352%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -1246 : -100.00% : 12.60% : -0.0692%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -1657 : -4.58% : 16.76% : -0.0920%

@jakobbotsch
jakobbotsch
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak What if you change the initialization of the table to:
for (unsignedint i = 0; i < TYP_COUNT; i++)
{
availableRegs[i] = &availableIntRegs;
}
availableRegs[TYP_FLOAT] = &availableFloatRegs;
availableRegs[TYP_DOUBLE] = &availableDoubleRegs;
#ifdef FEATURE_SIMD
availableRegs[TYP_SIMD8] = &availableDoubleRegs;
availableRegs[TYP_SIMD12] = &availableDoubleRegs;
availableRegs[TYP_SIMD16] = &availableDoubleRegs;
availableRegs[TYP_SIMD32] = &availableDoubleRegs;
#endif
In any case it still looks minor to me.
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak What if you change the initialization of the table to:
That's a reasonable approach, but as I mentioned earlier, this is LinearScan ctor which just gets invoked once per compilation. With the latest changes, the TP regression dropped, so I will go ahead and merge it.
image
This was a good exercise for me to learn how to analyze TP regression locally.
@kunalspathak
kunalspathak
merged commit 7a6c31c
into
dotnet:mainJan 10, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@SingleAccretion@jakobbotsch@BruceForstall

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Cache allregs to avoid checking the type repeatedly - #76850
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Jan 10, 2023
Merged
Cache allregs to avoid checking the type repeatedly#76850
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:cache_allregs
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
Oct 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Cache the availableRegs in a table that we can look-up and return instead of comparing the type every single time in allRegs() method. Gives a nice TP:
image
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Oct 11, 2022
@ghost
ghost
commented
Oct 11, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:kunalspathak
Assignees:kunalspathak
Labels:
area-CodeGen-coreclr
Milestone:-

This was referenced Oct 11, 2022

Closed


Closed

@kunalspathak
kunalspathak
marked this pull request as ready for review
October 11, 2022 23:29
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
What's up with the regressions on x86?
@kunalspathak
kunalspathak
commented
Oct 12, 2022

Copy link


Copy Markdown

ContributorAuthor
What's up with the regressions on x86?
I will have to double check, but the regression is on Linux/arm MinOpts only.
image
@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
image
image
(The libraries.crossgen2 collections have respectively 16 and 14 MinOpts contexts, so I don't think you can really read much from those)
@SingleAccretion
SingleAccretion
commented
Oct 12, 2022

Copy link


Copy Markdown

Contributor
Linux/arm MinOpts only.
Note it is present in Windows x86/MinOpts benchmarks / CG collections as well.
@jakobbotschjakobbotsch
mentioned this pull request
Oct 12, 2022

Closed

@jakobbotsch
jakobbotsch
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
I wonder if it's because it makes allRegs(<constant type>) more expensive. I see a bunch of those throughout LSRA that could be replaced with the right availableXRegs field.
@kunalspathak
kunalspathak
commented
Oct 13, 2022

Copy link


Copy Markdown

ContributorAuthor
I guess the interesting ones are benchmarks.run.windows.x86.checked.mch and benchmarks.run.windows.x64.checked.mch:
Ok, yeah I am still learning that I have to expand those details :)
Tried inlining the availableIntRegs directly at places where allRegs(TYP_INT) were present but it doesn't help much. Will disassemble and see what is different.
@kunalspathak
kunalspathak
commented
Nov 14, 2022

Copy link


Copy Markdown

ContributorAuthor
Still need to do the TP regression analysis for MinOpts.
@kunalspathak
kunalspathak
commented
Dec 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Ping to myself.
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
Hoping to review the TP analysis soon.
@kunalspathak
kunalspathak
commented
Jan 9, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
The biggest diffs in MinOpts for benchmarks on windows/x64 are these. I will investigate more.
-22555 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z+193049 : ??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z-460532 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z+942354 : ??0LinearScan@@QEAA@PEAVCompiler@@@Z
Base: 438977289, Diff: 437964751, -0.2307%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 481822 : +104.62% : 20.73% : +0.1098%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 170494 : +755.90% : 7.34% : +0.0388%
?defineNewInternalTemp@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@W4var_types@@I@Z : 2874 : +5.56% : 0.12% : +0.0007%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -2499 : -0.26% : 0.11% : -0.0006%
?identifyCandidates@LinearScan@@AEAAXXZ : -6888 : -3.02% : 0.30% : -0.0016%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -36677 : -0.23% : 1.58% : -0.0084%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -85337 : -0.94% : 3.67% : -0.0194%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -204706 : -2.84% : 8.81% : -0.0466%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -403823 : -100.00% : 17.38% : -0.0920%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -924883 : -6.09% : 39.80% : -0.2107%

@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
I tried running locally and don't see any regression (at least on windows/x64):
image
@kunalspathak
kunalspathak
commented
Jan 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Jan 9, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
The latest run doesn't have any benchmarks regression. It just has TP regression on crossgen2 and I tried to eliminate some of that by eliminating the call to varTypeIsSIMD().
Here is the latest and I don't think there is anything much that can be done:
Base: 1801740, Diff: 1802793, +0.0584%
??0LinearScan@@QEAA@PEAVCompiler@@@Z : 5430 : +104.62% : 54.91% : +0.3014%
??$varTypeIsSIMD@W4var_types@@@@YA_NW4var_types@@@Z : 21 : +7.95% : 0.21% : +0.0012%
memset : 16 : +0.17% : 0.16% : +0.0009%
?LowerStoreLocCommon@Lowering@@AEAAXPEAUGenTreeLclVarCommon@@@Z : -30 : -0.90% : 0.30% : -0.0017%
?identifyCandidates@LinearScan@@AEAAXXZ : -33 : -1.66% : 0.33% : -0.0018%
?BuildCall@LinearScan@@AEAAHPEAUGenTreeCall@@@Z : -103 : -0.34% : 1.04% : -0.0057%
?genFnPrologCalleeRegArgs@CodeGen@@IEAAXW4_regNumber_enum@@PEA_NPEAURegState@@@Z : -189 : -2.42% : 1.91% : -0.0105%
?BuildUse@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -526 : -2.45% : 5.32% : -0.0292%
?BuildDef@LinearScan@@AEAAPEAVRefPosition@@PEAUGenTree@@IH@Z : -634 : -3.62% : 6.41% : -0.0352%
?allRegs@LinearScan@@AEAAIW4var_types@@@Z : -1246 : -100.00% : 12.60% : -0.0692%
?BuildNode@LinearScan@@AEAAHPEAUGenTree@@@Z : -1657 : -4.58% : 16.76% : -0.0920%

@jakobbotsch
jakobbotsch
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak What if you change the initialization of the table to:
for (unsignedint i = 0; i < TYP_COUNT; i++)
{
availableRegs[i] = &availableIntRegs;
}
availableRegs[TYP_FLOAT] = &availableFloatRegs;
availableRegs[TYP_DOUBLE] = &availableDoubleRegs;
#ifdef FEATURE_SIMD
availableRegs[TYP_SIMD8] = &availableDoubleRegs;
availableRegs[TYP_SIMD12] = &availableDoubleRegs;
availableRegs[TYP_SIMD16] = &availableDoubleRegs;
availableRegs[TYP_SIMD32] = &availableDoubleRegs;
#endif
In any case it still looks minor to me.
@kunalspathak
kunalspathak
commented
Jan 10, 2023

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak What if you change the initialization of the table to:
That's a reasonable approach, but as I mentioned earlier, this is LinearScan ctor which just gets invoked once per compilation. With the latest changes, the TP regression dropped, so I will go ahead and merge it.
image
This was a good exercise for me to learn how to analyze TP regression locally.
@kunalspathak
kunalspathak
merged commit 7a6c31c
into
dotnet:mainJan 10, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@SingleAccretion@jakobbotsch@BruceForstall