Uh oh!
There was an error while loading. Please reload this page.
[wasm] Misc fixes - #76942
Merged
Merged
Conversation
Set the manifest package version to use (`7.0.0` instead of `7.0.0-ci`) early. Fixesdotnet#76908 .
ghost
commented
Oct 12, 2022
Tagging subscribers to this area: @directhex Issue Details
Fixes #76908 .
|
radical
commented
Oct 12, 2022
MemberAuthor
Best reviewed with |
radical
marked this pull request as ready for review
October 12, 2022 17:55
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ViktorHofer
approved these changes
Oct 12, 2022
radical
commented
Oct 12, 2022
MemberAuthor
Thank you for the review! |
.. because it is not set at evaluation time. So, get it in a target, and move the WorkloadIds to a target too.
radical
commented
Oct 12, 2022
MemberAuthor
The error checks @ViktorHofer suggested are useful, and so I added couple of those. |
This was referenced Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasm.Build.Tests started to fail when installing the workload manifests with [release/7.0] Enable stable branding for GA #76849 which moved to
Stable branding for GA. This caused the workload installation to fail because the targets were using the incorrect manifest version - 7.0.0-ci instead of 7.0.0. It is fixed here by setting that early, and using that in all the relevant places.a. The
PackageVersionis not set at project evaluation time, so instead we move setting the Version used to a new target.Changes based on Viktor Hofer's review feedback in Mono toolchain workload #51327 (review)
FixesFollow up on mono toolchain workload PR feedback #73758 .